Git Product home page Git Product logo

Comments (5)

dedmen avatar dedmen commented on June 23, 2024

https://github.com/KoffeinFlummi/armake/blob/master/src/p3d.c#L1259 This is explosion shielding from v72
it actually belongs below invArmor and above special lods struct according to mikero

from armake.

dedmen avatar dedmen commented on June 23, 2024

https://github.com/KoffeinFlummi/armake/blob/master/src/p3d.c#L842
Second tileU should be tileV

from armake.

dedmen avatar dedmen commented on June 23, 2024

There is currently one level of "sectionsInherit"
https://github.com/KoffeinFlummi/armake/blob/master/src/model_config.c#L443
It should be recursive. If the inherited class has another sectionsInherit entry we need to follow that too.

from armake.

dedmen avatar dedmen commented on June 23, 2024

Parser error
https://github.com/KoffeinFlummi/armake/blob/master/src/rapify.l#L117
This rejects the "unquoted string" case if there happens to be a number at the front.
x = 0.0447031 * safezoneW + safezoneX;
Oh look a number at the front! That means this can't possibly be a unquoted string!
Not sure what the workaround is.. Maybe make sure that there aren't any stray non-number characters left after the number that was detected?

Yep that worked for me

    auto res = std::from_chars(trimmedString.data(), trimmedString.data() + trimmedString.size(), val);
    if (res.ec != std::errc::invalid_argument) {//It's a number. They don't have to be quoted

        auto end = trimmedString.data() + trimmedString.size();

        //Basically only whitespace is allowed after that, if we have any stray characters, then this is not just a number but infact a unquoted string
        auto isEndClean = std::all_of(res.ptr, end, [](char x)
            {
                return x == '\n' || x == '\r' || x == ' ' || x == '\t';
            });
       
        if (isEndClean)//If end is not clean, this is not JUST a number.
            REJECT;
    }

from armake.

dedmen avatar dedmen commented on June 23, 2024

https://github.com/KoffeinFlummi/armake/blob/master/src/keygen.c#L71
This can fail if the hex number would start with a 0. Like
0x08BF7BD...
The 0 at the start is ommited, meaning you end up with a string length that is not power of two.
len will be rounded down instead of up, resulting in 255 length when you expect 256, which will cut one whole byte off. Ending up with a 127 byte signature here: https://github.com/KoffeinFlummi/armake/blob/master/src/sign.c#L345

Here is a pbo where that happens with v2 signatures

core.zip

from armake.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.