Git Product home page Git Product logo

Comments (1)

dedmen avatar dedmen commented on September 4, 2024

Eliteness bug is fixed in #95

The crash is caused by armake writing too many texGen's.
There are only 8 texGen's. in armake they are called stage_transform.
Armake add's one transform per stage, which is simply wrong :D
We should only push a new transform/texGen if the actual transform (uvSource and uvTransform) doesn't exist yet. And throw an error if a user tries to use too many.

https://github.com/KoffeinFlummi/armake/blob/master/src/material.c#L385
Here. Only dynamically add a new transform if we can't find one with same values.

my armake++ hotfix for now is this

    if (num_transforms > 8) {
        logger.error("Too many texGen's being used in RVMAT! Armake will clip excess off and cause weird behaviour! %s\n", path.c_str());

        num_transforms = 8;
        transforms.resize(8);

        for (auto& it : textures) {
            if (it.transform_index > 7) it.transform_index = 7;
        }
    }

atleast until I implement the pushBackUnique style texGen list.

Could also force users to use texGen manually if over 7 Stages.
https://community.bistudio.com/wiki/Multimaterial#Example
But I prefer that armake tries to fix it by itself first. The user must use less transforms either way.

from armake.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.