kodecocodes / java-style-guide Goto Github PK

I think it would be wise to discourage the use of Enums in Android in preference to Static Constants. The reasoning for this is because Google recommend using static constants instead of Enums in Android due to the increased memory they require.

http://developer.android.com/training/articles/memory.html#Overhead

The Android style guide recommends using m and s prefixes for member fields and static fields respectively.

This is of questionable use, and a lot of the wider Java community has decided to drop this convention, since IDEs will inform you of this kind of thing.

What should we do?

Pretty sure this is a standard Java rule. Do we have an opinion?

Even if a field is final?

Because XML is arguably just as important as Java on the Android system, I propose that we come up with some sort of convention that also falls in line with the guides governing attributes of conciseness, readability and simplicity.

What I'm suggesting is based on a general look at how XML is declared for standard components/suggested names in Android Studio and looking at other similar guides on GitHub

Prefix view based .xml files with the type of view they represent.

• activity_login.xml
• fragment_main_screen.xml
• button_rounded_edges.xml

XML Indentation

Indentation for elements should be kept to 2 characters

Keep style based XML attributes in the styles.xml file

Unless there is good reason to deviate. All styling for your view components in your app should be done in the styles.xml file to keep style elements in one place.

Keep all strings in the strings.xml file

Again unless there is good reason to deviate we should keep any strings in the app in strings.xml for quick availability.

Mostly likely other things and I hope others chime in.

There is a section in the guide regarding the copyright header. Is this appropriate to have in there?

I think we should recommend explicitly stating the access level modifier of a member variable (private, protected, public). This will make sure there is no ambiguity to access modifiers for variables and reduce the chance accidentally omitting access levels.

It would be great if there were an installation files for Eclipse as well.