Comments (2)
The only thing that cargo-pgo
does when you execute cargo pgo build
is basically that it runs
$ RUSTFLAGS="-Cprofile-generate=..." cargo build
so values from config.toml
and Cargo.toml
should be respected.
That being said, it looks like if you use RUSTFLAGS
, it will override the [build.rustflags]
section (rust-lang/cargo#5376). This is the standard behaviour of cargo, so I'm not sure whether we can do anything about it. cargo-pgo
could in theory parse the config.toml
file, but that would reimplement what cargo does and it would deviate from the default behaviour of cargo.
For now I think that your best bet is to pass these flags using RUSTFLAGS
. In any case, the LTO section from Cargo.toml
should definitely be applied, if it's not, something is wrong.
from cargo-pgo.
I can't reproduce the LTO issue anymore. It was probably just a benchmark inconsistency. (I couldn't find any way to check directly.) The RUSTFLAGS
issue is definitely real, but I will probably just use the environment variable.
from cargo-pgo.
Related Issues (20)
- cargo pgo optimize: Invalid cross-device link (os error 18) HOT 6
- Stream output of `cargo` HOT 4
- Run without clearing PGO directory HOT 2
- A couple PGO+BOLT limitations worth documenting? HOT 5
- PGO for non-terminating programs HOT 2
- Reason for stdin(stdio::null)? HOT 4
- Evaluate PGO coverage HOT 4
- Bolt can be installed starting with LLVM 15 - README potentially needs an update HOT 6
- LLVM ERROR: Broken module found, compilation aborted HOT 4
- Add support for more PGO modes HOT 6
- Github action HOT 2
- options for older OS HOT 20
- cargo pgo does not run (nothing happens after cargo pgo build or run) HOT 1
- Overwriting profile is not possible HOT 4
- PGO optimization for non-Rust dependencies in Rust projects HOT 4
- PGO as part of cargo install? HOT 4
- can't find crate for `profiler_builtins` HOT 1
- Does not allow for optimizations for WASM targets HOT 2
- Difference between "cargo bench" and "cargo pgo bench" HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from cargo-pgo.