Git Product home page Git Product logo

Comments (4)

Kobzol avatar Kobzol commented on May 18, 2024 1

I think that the mere existence of this issue is enough, if someone will look for PGO + native/C/C++ dependencies, they will find the discussion about it here :)

from cargo-pgo.

Kobzol avatar Kobzol commented on May 18, 2024

Hi, yeah, I agree that this would be quite difficult to support in the general case (although for specific crates it shouldn't be that hard). I'm not sure how we should document this though. "If you have native code, cargo-pgo won't PGO optimize it?". I'm not sure if that adds any relevant value, as cargo-pgo doesn't promise anything about C/C++ PGO optimizations.

from cargo-pgo.

Kobzol avatar Kobzol commented on May 18, 2024

In any case, if you have something specific in mind, I'd be happy to accept a PR :)

from cargo-pgo.

zamazan4ik avatar zamazan4ik commented on May 18, 2024

I agree that this would be quite difficult to support in the general case (although for specific crates it shouldn't be that hard)

I think the default recommendation could be something like "If you need to optimize your native non-Rust dependency with PGO - please create an issue in the upstream package to support PGO build mode". And in the Rust crates something_sys the maintainers could implement some build.rs PGO-related magic (if the real need exists).

I'm not sure how we should document this though. "If you have native code, cargo-pgo won't PGO optimize it?". I'm not sure if that adds any relevant value, as cargo-pgo doesn't promise anything about C/C++ PGO optimizations.

Hah, I also do not know how would be better to highlight (and should we at do it or not). But maybe for someone it would surprising to understand, that only Rust dependencies are optimized in the Rust projects, even if you (re)compile whole Rust project with cargo-pgo.

from cargo-pgo.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.