kobting / stsfriendlyminions Goto Github PK
View Code? Open in Web Editor NEWLibrary for adding Custom Characters that can spawn Friendly Minions
Library for adding Custom Characters that can spawn Friendly Minions
In AbstractFriendlyMonster, MinionMoveGroup moves is protected. However, in cards you may desire to modify or adjust the display of moves, which makes this awkward to access.
Likewise, in MinionMoveGroup, ArrayList moves is private.
My specific use case is, I have a card for which I wish to reset the moves of a minion. Instead of simply calling moves.move.clear(), I must now use reflection or subclass AbstractFriendlyMonster to Instantiate a completely new MinionMoveGroup, both of which are clunky solutions.
While making a 'clearAllMoves' function is probably your first thought, I submit that there may be other reasons besides clearing for which people may wish to access these fields. Such as reordering moves, modifying existing moves on the fly, etc. Thus, making them public hurts no one and would be of great help.
I am not sure if it is intended or not, but when I summoned the minion during the Transient fight, it started partially tanking his atk debuffs. Insult to injury, the "will receive the lost attack at the end of the turn" effect was retained by the Transient regardless of who received the debuff, resulting in 100+ damage on not even the final attack.
Also, if it is not the fault of this mod, but rather the one that implemented the particular minion, I am sorry, I just saw the part about minions being able to be chosen for debuffs in the description.
The mod in question is The Mystic, the card Summon Fox.
Your version field still reads '0.1', instead of '0.0.4'. It's a bit confusing. In your next release, would you update it to match the Github release number?
It doesn't work if the battle happens in the event,is it a bug?
If a minion dies because of their own actions or powers the game throws an exception.
This is because the minion triggers a ArrayList.remove() action while in the middle of that a ArrayList.forEach loop, making the loop break because of a missing minion.
Can be reproduced by adding the following to a child of AbstractFriendlyMonster
:
@Override
public void applyEndOfTurnTriggers(){
this.die();
super.applyEndOfTurnTriggers();
}
This can be prevented by:
forEach
loopremoveMinion()
function in the die()
functionisDead
, remove it at the end of the iterator loopI have already made a branch for this, if you allow me to push it you can review and add it to the code.
This will ensure it is loaded first and that it is loaded.
A declarative, efficient, and flexible JavaScript library for building user interfaces.
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
An Open Source Machine Learning Framework for Everyone
The Web framework for perfectionists with deadlines.
A PHP framework for web artisans
Bring data to life with SVG, Canvas and HTML. ๐๐๐
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
Some thing interesting about web. New door for the world.
A server is a program made to process requests and deliver data to clients.
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Some thing interesting about visualization, use data art
Some thing interesting about game, make everyone happy.
We are working to build community through open source technology. NB: members must have two-factor auth.
Open source projects and samples from Microsoft.
Google โค๏ธ Open Source for everyone.
Alibaba Open Source for everyone
Data-Driven Documents codes.
China tencent open source team.