knuckles-team / listmonk-api Goto Github PK

File attachement is now possible for transactional emails.

https://listmonk.app/docs/apis/transactional/#file-attachments

Please add the feature in the binding.

Looking at the latest docs, it appears that the parameter for send_type is now just type
https://listmonk.app/docs/apis/campaigns/#post-apicampaigns

Hey,
thanks for your work! Unfortunately I got an error while trying to use the api wrapper.

Environment

• listmonk v2.3.0 in docker behind a nginx-reverse proxy with a single list and a single subscriber
• python script on remote computer using this api in version 0.1.2

Code
lm_client = listmonk_api.Api(url=listmonk_api_url, username=username, password=password) print(f"Subscribers: {lm_client.get_subscribers()}")

Error
Traceback (most recent call last): File "/home/random/repositories/test/files.py", line 22, in <module> print(f"Subscribers: {lm_client.get_subscribers()}") File "/home/random/repositories/test/.venv/lib/python3.10/site-packages/listmonk_api/decorators.py", line 19, in wrapper return function(self, *args, **kwargs) File "/home/random/repositories/test/.venv/lib/python3.10/site-packages/listmonk_api/listmonk_api.py", line 65, in get_subscribers total_pages = int(response.headers['X-Total-Pages']) File "/home/random/repositories/test/.venv/lib/python3.10/site-packages/requests/structures.py", line 52, in __getitem__ return self._store[key.lower()][1] KeyError: 'x-total-pages'

At first I thought it may be caused by the nginx dropping an empty header, but even a local request from inside the container isn't containg an 'X-Total-Pages'-header.

A possible solution could be to fall back to 1 if the header doesn't exist (seems to be the case if the response isn't paged at all?).