knative / caching Goto Github PK

This makes (some) implementations simpler, e.g. WarmImage PoC.

However, the real motivation for this is that if we want to build a controller that automagically creates Image resources for Deployment or other built-in K8s types then we won't easily be able to pick the "right" pull secret to attach, and should probably just attach them all.

Expected Behavior

create an images.caching.internal.knative.dev resource and it will be updated with the status of caching

Actual Behavior

nothing happened

Steps to Reproduce the Problem

1. apply the following resource

apiVersion: caching.internal.knative.dev/v1alpha1
kind: Image
metadata:
  annotations:
    serving.knative.dev/creator: admin
  labels:
    app.kubernetes.io/version: v2.0.0
  name: sample-go-func
  namespace: default
spec:
  image: ypjin/sample-go-func:v1

2. check if the image gets cached and if the resource gets any status update

Additional Info

I'm using latest knative serving. There seems not much info on image caching. Appreciate your help!

/kind question

Can the purpose of this repo be clarified? Does caching mean warm-image kind of caching or fission kind of caching, or both? I know this repo just got created like a week ago, but it will be great to have the vision clearly stated.

/kind feature

Expected Behavior

1. add reconciler framework for images.caching.internal.knative.dev (add annotation // +genreconciler)，Convenient for third-party controllers to do some work，such as image warm
2. change status to duckv1.status
   • from https://github.com/knative/caching/blob/main/pkg/apis/caching/v1alpha1/image_types.go#L109
   • to https://github.com/knative/pkg/blob/main/apis/duck/v1/status_types.go#L38