Git Product home page Git Product logo

xenontrade's People

Contributors

klayver avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

xenontrade's Issues

Crashing On Search

Win 10 Pro 64 bit.
When attempting to perform a search at all it will fail to provide any information and end up crashing.

Failed to get price prediction

First off thanks so much for this utility. Absolutely wonderful.

My issue is that when pricing things faster than roughly 5-6 seconds per item I get a lot of "failed to get price prediction" However if I wait more than the 5 to 6 seconds its no issue.

I assume this is some sort of flood protection in poeprices.info API. Is there anyway we could just get a queue message? Its becoming cumbersome to have to click the x for each of these messages.

Below is attached log section :

[04/01/2019 09:32:00] [warn] Request to poeprices.info failed. { "name": "StatusCodeError", "statusCode": 403, "message": "403 - undefined", "options": { "json": true, "uri": "https://www.poeprices.info/api?i=UmFyaXR5OiBSYXJlDQpTa3VsbCBLbm90DQpUd28tU3RvbmUgUmluZw0KLS0tLS0tLS0NClJlcXVpcmVtZW50czoNCkxldmVsOiAzNQ0KLS0tLS0tLS0NCkl0ZW0gTGV2ZWw6IDc5DQotLS0tLS0tLQ0KKzE2JSB0byBGaXJlIGFuZCBDb2xkIFJlc2lzdGFuY2VzDQotLS0tLS0tLQ0KQWRkcyA4IHRvIDEzIFBoeXNpY2FsIERhbWFnZSB0byBBdHRhY2tzDQo5JSBpbmNyZWFzZWQgTGlnaHRuaW5nIERhbWFnZQ0KKzc5IHRvIEV2YXNpb24gUmF0aW5nDQorMiBMaWZlIGdhaW5lZCBmb3IgZWFjaCBFbmVteSBoaXQgYnkgeW91ciBBdHRhY2tzDQoyMCUgaW5jcmVhc2VkIEVsZW1lbnRhbCBEYW1hZ2Ugd2l0aCBBdHRhY2sgU2tpbGxzDQ%3D%3D&l=Betrayal&s=xenontrade", "simple": true, "resolveWithFullResponse": false, "transform2xxOnly": false }, "response": { "statusCode": 403, "headers": { "server": "nginx/1.10.3 (Ubuntu)", "date": "Fri, 04 Jan 2019 15:31:57 GMT", "content-type": "text/html; charset=UTF-8", "content-length": "0", "connection": "close" }, "request": { "uri": { "protocol": "https:", "slashes": true, "auth": null, "host": "www.poeprices.info", "port": 443, "hostname": "www.poeprices.info", "hash": null, "search": "?i=UmFyaXR5OiBSYXJlDQpTa3VsbCBLbm90DQpUd28tU3RvbmUgUmluZw0KLS0tLS0tLS0NClJlcXVpcmVtZW50czoNCkxldmVsOiAzNQ0KLS0tLS0tLS0NCkl0ZW0gTGV2ZWw6IDc5DQotLS0tLS0tLQ0KKzE2JSB0byBGaXJlIGFuZCBDb2xkIFJlc2lzdGFuY2VzDQotLS0tLS0tLQ0KQWRkcyA4IHRvIDEzIFBoeXNpY2FsIERhbWFnZSB0byBBdHRhY2tzDQo5JSBpbmNyZWFzZWQgTGlnaHRuaW5nIERhbWFnZQ0KKzc5IHRvIEV2YXNpb24gUmF0aW5nDQorMiBMaWZlIGdhaW5lZCBmb3IgZWFjaCBFbmVteSBoaXQgYnkgeW91ciBBdHRhY2tzDQoyMCUgaW5jcmVhc2VkIEVsZW1lbnRhbCBEYW1hZ2Ugd2l0aCBBdHRhY2sgU2tpbGxzDQ%3D%3D&l=Betrayal&s=xenontrade", "query": "i=UmFyaXR5OiBSYXJlDQpTa3VsbCBLbm90DQpUd28tU3RvbmUgUmluZw0KLS0tLS0tLS0NClJlcXVpcmVtZW50czoNCkxldmVsOiAzNQ0KLS0tLS0tLS0NCkl0ZW0gTGV2ZWw6IDc5DQotLS0tLS0tLQ0KKzE2JSB0byBGaXJlIGFuZCBDb2xkIFJlc2lzdGFuY2VzDQotLS0tLS0tLQ0KQWRkcyA4IHRvIDEzIFBoeXNpY2FsIERhbWFnZSB0byBBdHRhY2tzDQo5JSBpbmNyZWFzZWQgTGlnaHRuaW5nIERhbWFnZQ0KKzc5IHRvIEV2YXNpb24gUmF0aW5nDQorMiBMaWZlIGdhaW5lZCBmb3IgZWFjaCBFbmVteSBoaXQgYnkgeW91ciBBdHRhY2tzDQoyMCUgaW5jcmVhc2VkIEVsZW1lbnRhbCBEYW1hZ2Ugd2l0aCBBdHRhY2sgU2tpbGxzDQ%3D%3D&l=Betrayal&s=xenontrade", "pathname": "/api", "path": "/api?i=UmFyaXR5OiBSYXJlDQpTa3VsbCBLbm90DQpUd28tU3RvbmUgUmluZw0KLS0tLS0tLS0NClJlcXVpcmVtZW50czoNCkxldmVsOiAzNQ0KLS0tLS0tLS0NCkl0ZW0gTGV2ZWw6IDc5DQotLS0tLS0tLQ0KKzE2JSB0byBGaXJlIGFuZCBDb2xkIFJlc2lzdGFuY2VzDQotLS0tLS0tLQ0KQWRkcyA4IHRvIDEzIFBoeXNpY2FsIERhbWFnZSB0byBBdHRhY2tzDQo5JSBpbmNyZWFzZWQgTGlnaHRuaW5nIERhbWFnZQ0KKzc5IHRvIEV2YXNpb24gUmF0aW5nDQorMiBMaWZlIGdhaW5lZCBmb3IgZWFjaCBFbmVteSBoaXQgYnkgeW91ciBBdHRhY2tzDQoyMCUgaW5jcmVhc2VkIEVsZW1lbnRhbCBEYW1hZ2Ugd2l0aCBBdHRhY2sgU2tpbGxzDQ%3D%3D&l=Betrayal&s=xenontrade", "href": "https://www.poeprices.info/api?i=UmFyaXR5OiBSYXJlDQpTa3VsbCBLbm90DQpUd28tU3RvbmUgUmluZw0KLS0tLS0tLS0NClJlcXVpcmVtZW50czoNCkxldmVsOiAzNQ0KLS0tLS0tLS0NCkl0ZW0gTGV2ZWw6IDc5DQotLS0tLS0tLQ0KKzE2JSB0byBGaXJlIGFuZCBDb2xkIFJlc2lzdGFuY2VzDQotLS0tLS0tLQ0KQWRkcyA4IHRvIDEzIFBoeXNpY2FsIERhbWFnZSB0byBBdHRhY2tzDQo5JSBpbmNyZWFzZWQgTGlnaHRuaW5nIERhbWFnZQ0KKzc5IHRvIEV2YXNpb24gUmF0aW5nDQorMiBMaWZlIGdhaW5lZCBmb3IgZWFjaCBFbmVteSBoaXQgYnkgeW91ciBBdHRhY2tzDQoyMCUgaW5jcmVhc2VkIEVsZW1lbnRhbCBEYW1hZ2Ugd2l0aCBBdHRhY2sgU2tpbGxzDQ%3D%3D&l=Betrayal&s=xenontrade" }, "method": "GET", "headers": { "accept": "application/json" } } } }

Would it be possible to make it work in other languages?

Hello!
I just started using your tool, which seems great, but I noticed it only works if the game client is in English. I am currently playing in another language and was wondering if it was possible to make it work with other languages than English.

Thanks :)

Support for Scarab Pricing

I attempted to add this support myself however I am unable to really determine the cause of this errors I am receiving. I added the following to parserTypes.json file under the Normal Array:

    {
      "regex": "Can be used in the Templar Laboratory or a personal Map Device to add modifiers to a Map.",
      "type": "Scarab"
    }

As well as extended the API's in the poe ninja api.

      {overview: "item", type: "Scarab"},

However still no luck, just a yellow icon, no errors logging.

Ninja supports: https://poe.ninja/api/data/itemOverview?league=Betrayal&type=Scarab

I will continue to try and hack on this but maybe I am missing something?

Oil do not get prices

Expected behaviour

Xenontrade should give us the price of Oils, like other items

Actual behaviour

Yellow ! and no price

Your specifications

  • Platform: Latest Manjaro
  • XenonTrade Version: 0.5.0-alpha

Add hotkey for toggling minimize/restore

Whenever I want to price the stuff I just got from a delve/map, I have to tab out of POE, find Xenon in the task bar, then come back to POE. It would be really nice if there was a hotkey I could use in-game to bring up xenon and being pricing things immediately.

Ideally this hotkey would toggle, but isn't required. Minimizing the app is simple since it already on-screen; the primary inconvenience is restoring it after it has been minimized.

Some king of conversion for decimal points or other currencies

Detailed Description

some items are worth 0.18 chaos orbs and I have no idea how much that should be?

Possible Implementation

Easy feature implementation would be to use flour() function on result so u get an integer for price, so 0.18 c will be 1 c.

Harder feature implementation would be to display items in other currencies
lets say orb of augmentation is 0.07 c so my item 0.18 is worth 2 orbs or augmentation.

Additional context

Add any other context or screenshots about the feature request here.

Automatically hide window when there are no entries

Make it transparent whenever there is no cards open, right now it obscures buffs in default position. Might also be useful for some people if there is an option to enable click through when there is no info shown too. Option to set it on the bottom of the screen opening upwards would be nice too.

Allow for lower scale factor than 0.5

For performance reasons I am running PoE in Linux in Wine with lower resolution and I don't think XenonTrade is properly respecting DPI settings (I had similar issue with Discord so maybe it is Electron thing). Ideal solution would be to allow downscaling up to 0.1 scale.

A trade should NOT close out from Xenon's list when the option is un-selected.

Expected behaviour

A trade should NOT close out from Xenon's list when the option is un-selected.

Actual behaviour

Trades close out from Xenon's list even when the option is selected.

To reproduce

Options->Trade Helper->toggle the green slider

Your specifications

Xenon .5a on Ubuntu

  • [no ] Running XenonTrade as admin
  • [no] Exclude XenonTrade in my antivirus program
  • [yes ] Closed similar tools that might interfere with XenonTrade

Add option to disable price-check error messages or add timeout for them

It is extremely annoying that I have to manually delete all price check failure messages. Best would be to simply add option to disable them and if that is too much then maybe just adding configurable timeout for those messages like everything else has. Maybe add configurable timeout for all error messages? Not sure if there are any except these price check failures.

Systems without apt or rpm can't manually say "yes I have wmctrl"

I'm trying to add a check for pacman that mirrors the RPM check as we speak, but running into build issues with node and such; seems newer node and whatever version of nan is used are incompatible for some reason. If I get it sorted I'll PR the pacman check, but I'm not familiar with this ecosystem so I won't be able to add some sort of a check box the user can tick to say "I have wmctrl even though you don't know how to check for it on my system".

Trading feature needs more delay

It often happens that when using any message button the input to open the chat is missed and it ends up opening any menu with hotkeys.

The solution is to add a delay between inputs, a 50-150 milliseconds delay was enough if I recall correct.

item search in inventory

Hello,

I am running alpha 5.0.
On my previus install, there was a icon to search an item in the inventory, next to the name, after receiveing a trade request.
How do I get the icon / search function back ?

Thank you

Fix: Handle 503 errors instead of showing in price checker

Right now, if the price checker gets a 503 response, it just puts the entire HTML result into the price checker window, causing the screen to fill up with ugly unparsed HTML. Hopefully we can get a fix for this so it just displays something like "Gateway Timed Out (503)" instead.

Pause Autoclose on Mouse Over

AutoClose is a nice feature.
What really could help while checking redictive prices or just for double checking would be if the countdown would pause for an item as long as the mouse is over it.
this could be a toggleable option.

don't know if this works if xenotrade does not have focus tho

Xenon Trade Doesn't Seem To Work Any More

Expected behaviour

When I run XenonTrade it should automatically show itself over my display.

Actual behaviour

XenonTrade runs and is in my icon bar, but clicking show doesn't show it over my display and it isn't discernibly visible anywhere on my monitor.

To reproduce

No Idea.

Your specifications

Windows 10
XenonTrade Version 0.4.1

I have tried the following

Reinstalling XenonTrade, running as an administrator, closing similar tools, etc

  • Running XenonTrade as admin
  • Exclude XenonTrade in my antivirus program
  • Closed similar tools that might interfere with XenonTrade

Chat function have disappeared

I re-installed fully my computer.

I always download the latest version of Xenontrade.

But, before, like 2 weeks ago, I had a version of Xenontrade that would ask for the path of poe, and would allow chat command, like reply / thanks / sold

On this version. it is not present anymore.
What do i have to do to get the chat function back ???

Doesn't work as an overlay

I used the command for setting PoE to bottom and the app doesn't let me interact with it unless I alt-tab to it.

Set default league to Betrayal

Detailed Description

Change the config to show that Betrayal is the correct starter league

Possible Implementation

src\modules\helpers.js:245 league: "Delve", >> league: "Betrayal",

Xenontrade can lose focus so that buttons aren't clickable

Quite hard to reproduce reliably. Easier without having auto-close on. This seems to happen because of a hidden area under the title is focusable for a short while sometimes. This triggers this.window.setIgnoreMouseEvents(true, {forward: true}) in gui._initializeWindowsTransparency without resetting the focus on reenter. Hovering over the title restores the focus.

removing:

el.addEventListener("mouseenter", () => {
  // If entries div is empty
  if (!$.trim($(".entries").html())) {
    this.window.setIgnoreMouseEvents(true, {forward: true})
  }
});

Seems to fix the problem, but i'm not sure if this have any other side effects.

Unusable with not-QWERTY keyboard layouts

Expected behaviour

Pressing CTRL+C opens XenonTrade.

Actual behaviour

Pressing CTRL+C does nothing.

To reproduce

Set your keyboard layout to anything where C is in a different location, such as Dvorak.

Your specifications

  • Platform: Windows 7
  • XenonTrade Version: 0.5a

I have tried the following

  • Running XenonTrade as admin
  • Exclude XenonTrade in my antivirus program
  • Closed similar tools that might interfere with XenonTrade

Also tried pressing the key that would be in the QWERTY C location (J on my keyboard), which is what Xenon is actually listening for, but that also doesn't work because PoE is not listening for that key, it's listening for the correct key.

Additional context

Caused by hard-coding the scancode when attaching the keydown listener.
Ideally this could just be configured in the settings to be whatever we like, but at the very least should respect the current keyboard layout instead of assuming the scancode.

Autotracking of valuable items feature request

As posted on the Reddit thread, I'll also post it here.
A very nice to have feature would be autotracking of valuable drops. Your overlay activates upon using a key combo, whereas what I'm suggesting autoscans whatever drops (needs to be ID'd, of course) and notifies you immediately if anything is over a certain chaos threshold. (User setting, default, say 5c)

PoE doesn't like stuff that's invasive, but CurrencyCop is as far as I know a tool that's allowed to use. It scans items you have in your stash tabs and then shows you an overview of what everything's worth.

It'd be pretty easy to use that feature to bring about the feature I'm requesting. You'll let the user define a dump tab that they can store items into (ID'd prerequisite on rares or otherwise ignored). The feature does a periodic scan of the stash tab, and displays the few items in the overlay that are worth more than the user defined chaos threshold. User can then proceed to move item into sell tabs or whatever. All other items in dump tab can be vendored at will.

You can find the code for CurrencyCop here: https://github.com/currency-cop/currency-cop. This'll save you most the effort of coding the pulling from stash tabs. You'll have to combine that then with the price check integrations you've implemented yourself and lastly have a view in the overlay that displays all the items that meet the threshold requirement.

Of course, I'm not encouraging you to steal someones code and effort, be sure to check up first with the guy behind CC ;)

Would be pretty amazing if you'd be able to implement a feature like this in due time.

Price checking doesn't work anymore.

Price checking doesn't work anymore.
I use to work like yesterday, but suddently stop working.
It gives the error of incorrect league, even so the correct league is checked
[16/03/2020 20:55:43] [warn] Failed updating poe.ninja prices, Error: The data from the requested Currency API (League: Delve) could not be processed because the format is invalid or the response is empty. Possible reasons: 1) Invalid league name, 2) poe.ninja is down, 3) poe.ninja changed their API structure

I am running Xernontrade on Manjaro, with the app.image.

I have tried deleting the locale folder of Xenontrade, check parameter again, but same issue.

Rare price prediction not showing correctly despite poeprices.info showing data

Hello,

When running querries on several items prediction shown by xenontrade displayes:
"Failed to get price prediction
Request to poe.prices.info was unsuccessful. Recieved an ampty response"

Going to the site manually and pitting the copied item does land a prediction however, both in Machine Learning Section and in Recommended Price section

Items in question

Rarity: Rare
Miracle Twine
Stygian Vise
--------
Requirements:
Level: 68
--------
Sockets: A 
--------
Item Level: 86
--------
Has 1 Abyssal Socket
--------
27% increased Lightning Damage
+35 to maximum Life
+32% to Cold Resistance
+29% to Lightning Resistance
23% increased Life Recovery from Flasks
50% increased Elemental Damage with Attack Skills
--------


Rarity: Rare
Dusk Clasp
Stygian Vise
--------
Requirements:
Level: 48
--------
Sockets: A 
--------
Item Level: 86
--------
Has 1 Abyssal Socket
--------
11% reduced Enemy Stun Threshold
+66 to maximum Life
+39% to Cold Resistance
13% increased Stun and Block Recovery
30% increased Elemental Damage with Attack Skills
--------


Rarity: Rare
Horror Leash
Stygian Vise
--------
Requirements:
Level: 28
--------
Sockets: A 
--------
Item Level: 86
--------
Has 1 Abyssal Socket
--------
30% increased Lightning Damage
+65 to maximum Life
26% increased Elemental Damage
22% increased Life Recovery from Flasks
--------

Windows 7, no minimise

Price checks never minimise on Windows 7.

Could not find any logging, can test further if prompted to.

For verification from the Reddit post, the app does auto focus, minimise and stay on top.

Xenon stealing focus from PoE

Running PoE in Windowed Fullscreen, alt-tab out of PoE, then click back into PoE. PoE will have focus for 0.5-1s before focus is lost / stolen by Xenon. Xenon does not have Always focus PoE turned on.

Magic items do not give any visible response

I understand that magic items aren't supported right know (or if they ever will be)

I got slightly confused when I tried to price-check some magic jewels and thought it was some kind of bug as nothing happened. Not until I actually read the code I understood why nothing happened.

I suggest that a message shows up that magic items aren't supported when you try to price check them. This might reduce unnecessary bug reports in the future.

Avoid opening repeated searches

Option to avoid opening repeated searches, refresh the timer instead if there is one or just don't open another card if there is a card already open with the same search. Could be a toggle in options or could be just core, I don't see any value in having the same search open more than once, but I could be missing something and it has a use case scenario.

More Size Settings

More settings to adjust things like icon/font sizes would be nice. Currently being small is good if the app is being overlayed on top of the game but for those who may put it on another monitor having a bigger interface would help.

[Suggestion] Auto leave party option in Trade Helper

An option similar to 'close' that auto-leaves the party after sending the whisper. Most other trade helpers have this and it's one of the most useful features, to be able to say 'Thanks' and leave party all at once.

Create Issues for Contributors

Hi, I found your project from the Reddit thread.

I realize this is early stages but I wanted to encourage you to consider, if you're open to it, allocating some of your time to creating actionable issues that may foster outside contribution. You may also want to add a License and some kind of minimal guidelines for contribution. I don't want to create more work for you and you should probably ignore this request if you desire to maintain full control/ownership of the codebase.

Cheers!

Mouse Lag

Win 10 Pro 64bit
When loading xenontrade and being on the desktop the mouse will become basically unusable due to the lag. Opening up task manager seems to work around this until you get into the game at which so far the issue does not happen.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.