klaudiosinani / hyper-star-wars Goto Github PK

Is it possible to have 2k and 4k backgrounds the plugin via a switch on the config?
Some of them dont look all the great on a 2k screen. The bb8 and r2d2 are probably the most anoying

Allow us to set a given character theme without the characters avatar in the background in ~/.hyper.js

We can use this form link https://forms.gle/6zoiq8jdagoMm9N48 to recommend @klaussinani for GitHub Sponsor Matching Funds

Totaly worth for his work! 🚀

Original idea from klaudiosinani/ao#96

This is not a issue at all, I just saw the pictures in the /backgrounds folder of this repository and would really like to use them as my desktop wallpaper. Unfortunately they all have a resolution of only 1920x1080. So my question is if you can be so kind to provide them in a higher resolution, maybe even 4k? That would be greatly appreciated. :)

In the title!

Is your feature request related to a problem? Please describe.
No

Describe the solution you'd like
Darth Maul character option, maybe others as well?

Additional context
N/A

Description

[On windows OS]
Users with spaces in their user folders won't be able to see the background images since you are setting the background property using an url and are not wrapping the url with double quotes ("). That produces that the path can't be resolved.

I solved it by manually wrapping the URL in the node_modules folder. It's a really quick fix that could help people.

Index.js file, Line 138.

Use

background: url("file://${pathToTheme}") center;

Instead of:

background: url(file://${pathToTheme}) center;

Error Message (if any)

Theme settings

Relevant Links (if any)

Environment

Windows 10 - 64 bits
Hyper 1.3.3
Hyper-star-wars 1.0.0

Is your feature request related to a problem? Please describe.
Would be nice to edit/custom some colors of the theme (Like option), cause for some theme, I can't seem what the text is.. (See image below)

Describe the solution you'd like
Add option to custom some colors.

Additional context

I would love to have Darth-Vader on the purple background of Emperor Palpatine!
Is it possible to do it myself from the .hyper.js config?

Description

Theme not working after upgrade to Hyper 2.0

Theme settings

StarWarsTheme: {
  character: 'boba-fett', // Define your favorite star wars character
  lightsaber: 'false', // Activate your theme's lightsaber mode
  unibody: 'true', // Define the color of the Hyper window header
  avatar: 'true'  // Activate your theme's background avatar
},

Environment

MacOS
Hyper 2.0
Latest hyper-star-wars

Additional Information

Hi! : )
To celebrate the Hacktoberfest festivities, everyone is welcome to update the project's dependencies and devDependencies to their latest versions. It should be really simple and easy. Here are the links to the packages on npmjs.com, you can find their latest version on the right side of the page:

• yaml-lint
• home-dir
• xo
• js-yaml

Happy Hacktoberfest and happy hacking! 🎉

Describe the bug
A clear and concise description of what the bug is.

I have lightsaber: True, but glowing cursor is not.

Technical Info (please complete the following information)

• OS: MacOS 10.15.4
• Hyper version: 3.0.2
• Hyper-Star-Wars version: 3.2.1

Additional context
Add any other context about the problem here.

Description

Her name is spelled wrong. If you could help out an overly OCD developer and "hyper" SW nerd out, that would be great.

Relevant Links (if any)

http://starwars.wikia.com/wiki/Rey

Additional Information

Thanks for the plugin!

If you don't modify the hyper.js file and add the StarWarsTheme config item it will crash on startup. Maybe it would be better to have it show a warning or automatically add default values for this on install. I'll create a pull request later with one of those changes. I just thought it should be mentioned.