kkukshtel / castledb-unity-importer Goto Github PK

I had to place preprocessor directives (#if UNITY_EDITOR) around several parts to allow building my app. I can send a PR if that helps. Thanks for writing this plugin, its freaking amazing and I will be contributing hopefully.

Thanks!

CastleDB supports images in rows. It's an open question right now if this should support that functionality now as well as how it should be supported. Per the CastleDB documentation: "the string of the MD5 of the image content bytes, stored in the separate .img JSON data".

I think that a possible (crazy) use would be essentially generating runtime textures from the .img data and then accessing that in code. This would likely be pretty hard and also require a change to the config file as each user would want to use this differently.

I haven't tested this with this plugin at all, but CastleDB has a built in level-editor that may be useful for some people. If someone wants to take this on, be my guest!

CastleDB supports "file" types, stored as "the relative (if possible) or absolute path to the file". I think using this now would make this be a string at runtime, so if this is fine maybe this is already implemented by proxy. I'm not sure if other people would want more out of supporting this file type.

Right now the CastleDBGenerator class makes heavy use of string concatenation to build the classes. Using StringBuilder would make the generation far more efficient.

The SimpleJSON.cs as part of this importer is outdated. It contains some bugs, e.g. floats/doubles faulty being imported as integers on several systems where commas are used instead of dots. If people are facing same issue, update the simpleJSON.

From changelog simpleJSON:

https://github.com/Bunny83/SimpleJSON/blob/master/Changelog.txt

• [2018-01-09 Update]
  Changed all double.TryParse and double.ToString uses to use the invariant culture to avoid problems on systems with a culture that uses a comma as decimal point.

Maybe add a license to this super cool useful thing???

CastleDB supports custom types. Writing a guide for how to use them with this tool would be great! I don't really understand how they work, but I think it would be possible to write a custom type that would be default map to a type in Unity, wheter it's a built in class or your own created class.

I've been reading a lot about C#'s new features around Roslyn and am wondering if any of the stuff it is capable of would be able to be leveraged for this project? There's a lot of manual code gen happening right now, but if there was some way to intelligently parse the CastleDB file and generate a C# class that had proper Attributes/etc., this code could get a lot cleaner and be a lot more resilient.

That said, I'm a big noob here so would love to hear if other people have any experience or opinions or can point to relevant projects.

Does this plugin support runtime operations. Or its purely edit time (editor).

Say I would like to have item templates where they have some dynamic attributes. And on runtime I would generate items from those templates and save them to DB

CastleDB supports RGB encoded colors. Just need to implement a conversion function inside either the CastleDB utils or generated CastleDB class to turn that value into a properly generated UnityEngine.Color.

Is there, or would there be a possibility to have file encryption activated?

Currently, it would be very simple to cheat in the game if the progress is saved in the final game as a simple JSON file.

Is there any possibility to have encryption implemented in the build?

While this tool still works, the repo is in maitencne mode as most of my efforts are now directed to Depot. Depot aims to replicate most of the functionality of CastleDB, but in a context separate from Haxe and without needing a separate application (it runs in VS Code).

People who use this tool are encouraged to instead use Depot.

Is it possible to simulate inheritance using CastleDB and your importer ?

Let's say I have the following sheets: Enemy, FlyingEnemy, BossEnemy
FlyingEnemy and BossEnemy inherit from Enemy.

I don't want to duplicate columns in each sheets but use the Enemy sheet to set all base Enemy properties. I guess it is acceptable to simply add a reference to Enemy in FlyingEnemy and BossEnemy. But it will generate a lot of duplicate according how references are handled.

Do you think it would be better to add en Enum column in Enemy that would indicate the specific Enemy type and another column that would indicate the id of the specific type in its sheet ?

The other issue I'm thinking of is how to select an Enemy from another sheet ? Should I use a reference of Enemy type ? Doing that I won't be able to know the specific type of the Enemy is really wanted.