kitbrennan90 / laravel-sendgrid-webhooks Goto Github PK

If I'm not mistaken the "sendgrid/sendgrid" that is required in the composer.json isn't used anyway. To keep the package light, I think it whould be a good idea to remove it.

-I run:
php artisan migrate
-This throw error.

We have a migration to change the table structure in 1.1.0. In order to ensure people can still run migrations when they upgrade from 1.* (including 1.0 before the migration), we should keep the migration in place in 2.*, but then remove the migration and update initial table creation in 3.*.

It would be super useful to be able to fire a Laravel event that the library user's application can listen to whenever a new Sendgrid webhook is received.

For example, this would allow a user to save to their own analytics software whenever an email is opened.

DESCRIPTION:
InnoDB has a limitation of 768 bytes per index key and you won't be able to create an index longer than that.

ERROR 1:
SQLSTATE[42000]: Syntax error or access violation: 1170 BLOB/TEXT column 'categories' used in key specification without a key length

FILE: UpdateCategoryColumnToArray

 Schema::table('sendgrid_webhook_events', function (Blueprint $table) {
            $table->jsonb('categories')->default(json_encode([]))->index();
        });

DESCRIPTION:
MySql does not support JSON type

ERROR 2:
SQLSTATE[42000]: Syntax error or access violation: 1064 You have an error in your SQL syntax; check the manual that corresponds to your MariaDB server version for the right syntax to use near 'json) wherecategoryis not null' at line 1

FILE: UpdateCategoryColumnToArray

 default: {
                DB::table('sendgrid_webhook_events')
                    ->whereNotNull('category')
                    ->update(['categories' => DB::raw("CAST(concat('[\"', category, '\"]') AS json)")]);
                break;

Currently our logging sits within the library's controller which is leading to a bit of bloat, especially if we decide to add more events later. We should move the logging into a separate class and write unit tests for this class specifically.