kissmetrics / kmts Goto Github PK

Seeing lots messages like this in my logs while running an import script:

<Thu Jan  4 10:39:15 2018> Failed to open TCP connection to trk.kissmetrics.com:443 (getaddrinfo: nodename nor servname provided, or not known) for host https://trk.kissmetrics.com

It's unclear whether or not the request was retried or discarded. In the context of this script, I would prefer to retry if it failed, but I don't think my code has access to whether or not this call succeeded.

I am using this gem to send data to Kissmetrics, but I often see this warning in my logs:

~/.rbenv/versions/2.4.2/lib/ruby/2.4.0/uri/rfc2396_parser.rb:305: warning: regexp match /.../n against to UTF-8 string

I finally figured out that this happens when the data includes some latin character, such as ñ because all of the values are encoded as URL query params using URI.escape:

KMTS.record("user-1234", "viewed page", { "viewed page - page_title" => "En Español" })
# /e?_p=user-1234&_n=viewed%20page&viewed%20page%20-%20page_title=En%20Espa%C3%B1ol

I'm guessing it's related to this line, but I could be wrong.

My data is in UTF-8 encoding, so I don't think I'm doing anything wrong, but these warnings are concerning because I'm not sure if my data is being sent/received/encoded correctly.

I am using gem version 3.0.2.

"The source :gemcutter is deprecated because HTTP requests are insecure."

The javascript can use ssl. Why should this not do the same?

Let me know if you'd like for me to make a pull request.

Note: If I write test cases they won't test actual timeout windows working obviously, just perhaps that the parameter is set and that there is some sort of sane logging of the error returned (Timeout::Error).

This would be an option passed in at initiation, not when performing an action, for that there's always:

begin
   Timeout::timeout(5) do
      KMTS.record(...)
   end
rescue Timeout::Error => e
   ...do something
end

It turns out that the current code forces the API to be contacted as HTTP. It should allow (and default to?) HTTPS.

I've added the init to my controller and try to use a record in a method but it doesn't do anything. Is there something more that needs to be done with Rails to make it work?

When you yanked the prior version from rubygems.org, you broke our deploys without notice. We had to change our gemfile to point to the last ref before the version change to fix it. Please don't yank prior versions. Give us an update and include deprecation notices if necessary, but updates shouldn't break existing usage without ample notice.