'kmts' gem yanked ? what's the alternative? about km HOT 10 CLOSED

Greetings @robgleeson - I believe one of our engineers pulled it yesterday due to a change in the Thread logic.

See: #12 (comment)

@percyhanna will have an update available soon.

from km.

okay. how "soon" is soon? doing something like this blocks a whole deploy & build process for anything that depends on kmts.

from km.

I had to fork the kmts gem & host it privately until a new release happens & we can update to the new API.
it looks like the new version is not backwards compatible. So, the old gem is gone, the existing API people are using won't work anymore when they can upgrade, and there's nothing to upgrade to right now.

Why not keep the old version and bump a new release(a MAJOR bump if it is not backwards compatible) ? Or at least some transparency on the issue. There's nothing but a pull request comment and a (unreleased) branch that doesn't have a compatible API with earlier versions of the same gem. A normal release process that saw a new release which addressed the bug would have avoided this mess.

from km.

it looks like kmts v1.0.2 is the (not thread-safe) km gem. o_O
source code is the same. KM.identify looks like it could end up mis-identifying people because it re-assigns @id on something that's globally reference-able(KM module) and could be called from 2+ threads. I don't know if this has an impact on my code, need to investigate and upgrade to the new code (a release would be appreciated).

from km.

Hi Rob, my apologies for causing these issues for you. I jumped the gun on yanking the gem when I probably shouldn't have.

The main reason that I did that is, as you pointed out, that version 1.0.2 of kmts had somehow lost the thread-safe commit, and basically became the same as the km gem. I made the (wrong) decision to yank the gem until we had a proper fix for it.

We're working on getting a 2.x kmts gem out ASAP. Sorry again for the trouble.

from km.

@percyhanna thanks. it turns out this does not impact my code. I'm using the thread-safe version on the branch you created for now though.

from km.

We've release version 2.0.0 of the kmts gem, available here: https://github.com/kissmetrics/kmts and on RubyGems.

from km.

thanks, I'll upgrade now.
👍 for the new repository.

from km.

that repository doesn't exist right now. it'd be great if it did to avoid confusion. +1 for the KMTS namespace change too.

from km.

Sorry, forgot to make it public. Should be good now.

from km.