kinghodor / ethereum-rlp Goto Github PK

Hi,

Great lib! What is the license in order to use it? Can I assume it's MIT?

Cheers,
Ben

Below two lines in RLP.c must be changed.
Your code just can create right RLP only when chain ID is small number.

Add below function and fix your code.
(I know this function is not great but can solve facing problem.)

int calculateLengOfV(uint32_t v) {
    // 1byte
    if ((v & 0xFF) == v) {
        return 1;        
    // 2byte
    } else if ((v & 0xFFFF) == v) {
        return 2;
    // 3byte
    } else if ((v & 0xFFFFFF) == v) {
        return 3;
    // 4byte
    } else if ((v & 0xFFFFFFFF) == v) {
        return 4;
    } else {
        return -1;
    }
}

And fix the code right.

totalLength += calculateLengOfV(new_tx->signature_v);

...

copyPos = wallet_copy_rpl(data + copyPos, &new_tx->signature_v, calculateLengOfV(new_tx->signature_v), copyPos);

free(pbytes) is not always called because the conditional scoping which can result in memory issues.

i use the example result to broadcast:
f86c008504a817c80082520894e0defb92145fef3c3a945637705fafd3aa74a241880de0b6b3a7640000001ba009ebb6ca057a0535d6186462bc0b465b561c94a295bdb0621fc19208ab149a9ca0440ffd775ce91a833ab410777204d5341a6f9fa91216a6f3ee2c051fea6a0428

the error message is:
Error: rlp: non-canonical integer (leading zero bytes) for uint64, decoding into (types.Transaction)(types.txdata).AccountNonce