Git Product home page Git Product logo

ambientmusicmod's People

Contributors

kieronquinn avatar varuns2002 avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

ambientmusicmod's Issues

Sound Model incompatible on Pixel

I want to use this implementation on my pixel 4 because I gave up using the original feature after Google forced analytics for pixel 4 and above.

Sad to see the device is not recognized as being compatible :(
if this is a reimplantation, why is it not compatible with the original devices?

Oneplus 8T - using bottom mic (intended for calls) instead of top one (intended for ambient sound recongition)

Problem:

Judging by terrible quality of any input playback from recognition test + fact that device needs to be directed specifically at the sound source + having to be relatively close to sound source - the wrong mic is being used.

That is a directional mic (located at the bottom of device) that is designed for recording voice during phone calls and not being optimal for ambient sounds.

Solution:
Is it possible to switch to the main mic (located at the top of device) that is probably designed to recognize ambient sounds?

AmbientMusicMod: 1.1.1
EdXposed: 0.5.2.2 (Yahfa)
Magisk: 22104 (latest canary build)
OS: OxygenOS 11.0.8.12 (stock rom, Android 11 based)

AmbientMusic Recognise Feature

On Samsung devices without root, the Recognise feature only records static. However, when recording via another app to recognize music (ie. Shazam, Google app, or Google assistant), the song gets recognized mostly without any issue.

Adjusting Gain does not yield any improvement, with static still largely remaining.

Using AmbientMusicMod 2.0.1 apk via Shizuku.

Android 12 Support

Due to changes in Sound Trigger in AOSP Android 12, you may find this module does not work on it.

I do not currently have access to an Android 12 device that is rooted, and is not a Pixel (ie. one this module can be tested on). Once I do, I will attempt to update it to support it.

For more information, see #36 and #37

Was working fine, then suddenly "Ambient music failed to start"

I am using oneplus 7 pro with pixel experience rom.
This mod was working fine, then a new update to pixel ambient services came.
Unfortunately i didn't disable the auto update, but then i reverted "pixel ambient services" back to stock and disabled auto updates now.
But now the mod doesn't work. It just shows "Ambient music failed to start".
I have tried removing the mod from magisk and apk and then reinstalling, but still doesn't work.
Any way i could fix this?
Cause the mod was working perfectly fine.

Sound seems too loud

I've made a first test on a OnePlus 8 Pro (Pixel Experience) and it works perfectly.
I've made the same test without root on Galaxy S22+ running OneUI
According to the playback function, the music is not audible at all, I can only hear distortions and strange noises, even with gain at 0.1x.
Every microphone is clear and working (tested using camera, call, recorder)

Audio on bluetooth and alarm breaks with Magisk module enabled

Device - Xiaomi Mi 10 Lite 5G
Android version - 11
Rom - CrDroid

I've followed the install instructions, everything is functional but bluetooth and alarm audio refuses to play. On bluetooth on top if you change the output device it always takes the phone, regardless of it being a bluetooth device or not.
I've built the module according to instructions but can't replicate earlier errors (codes varied a lot) I had on Sound Model compatible. I do however get currently result code -8880 while it stating being compatible.

[Bug] Ambient music failed to start.

Device - Asus Zenfone Max Pro M1 (X00td)
Android version - 10
Rom - Pixel Experience

When i try to test recognition, the process fails with "Ambient music failed to start"
ambient_music_mod_log_dump_2021-04-20T19_22_39.353.zip

i found the lsposed logs to be interesting so attaching them as well

LSPosed Log
--------- beginning of information
Manufacturer: asus
Brand: asus
Device: ASUS_X00T_2
Product: X00TD
Model: ZenFone Max Pro M1
Fingerprint: google/coral/coral:11/RP1A.201105.002/6869500:user/release-keys
ROM description: coral-user 11 RP1A.201105.002 6869500 release-keys
Architecture: arm64-v8a
Android build: QQ3A.200805.001
Android version: 10
Android sdk: 29
LSPosed version: v1.3.5 (5551)
Riru version: v25.4.2.r415.f42e9c3 (415)
Riru api: 25
Magisk: 1469b82a (21101)
2021-04-20 17:03:44.044 E/?(1471-1471): de.robv.android.xposed.XposedHelpers$ClassNotFoundError: java.lang.ClassNotFoundException: com.android.server.soundtrigger_middleware.SoundTriggerHw2Compat
	at de.robv.android.xposed.XposedHelpers.findClass(Unknown Source:13)
	at de.robv.android.xposed.XposedHelpers.findAndHookMethod(Unknown Source:0)
	at com.kieronquinn.app.ambientmusicmod.xposed.apps.Android.setupSoundTriggerHooks(Android.kt:57)
	at com.kieronquinn.app.ambientmusicmod.xposed.apps.Android.onAppHooked(Android.kt:41)
	at com.kieronquinn.app.ambientmusicmod.xposed.Xposed.handleLoadPackage(Xposed.kt:25)
	at de.robv.android.xposed.IXposedHookLoadPackage$Wrapper.handleLoadPackage(Unknown Source:2)
	at de.robv.android.xposed.callbacks.XC_LoadPackage.call(Unknown Source:6)
	at de.robv.android.xposed.callbacks.XCallback.callAll(Unknown Source:28)
	at X0.beforeHookedMethod(:1)
	at de.robv.android.xposed.LspHooker.handleHookedMethod(Unknown Source:75)
	at LspHooker_.startBootstrapServices(Unknown Source:8)
	at com.android.server.SystemServer.run(SystemServer.java:516)
	at com.android.server.SystemServer.main(SystemServer.java:359)
	at java.lang.reflect.Method.invoke(Native Method)
	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:491)
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:918)
Caused by: java.lang.ClassNotFoundException: com.android.server.soundtrigger_middleware.SoundTriggerHw2Compat
	at java.lang.Class.classForName(Native Method)
	at java.lang.Class.forName(Class.java:454)
	at z0.b(Unknown Source:49)
	at de.robv.android.xposed.XposedHelpers.findClass(Unknown Source:5)
	... 15 more
Caused by: java.lang.ClassNotFoundException: com.android.server.soundtrigger_middleware.SoundTriggerHw2Compat
	... 19 more

Lsposed configuration

Ambient Mod not showing on Lockscreen

Hi there
I just recently updated your Ambient music mod and found some of the features is not working for me.

  1. Now playing is not showing up on Lockscreen
  2. Offline recognition not working

Android version - Android 12
Device - Realme 2 Pro
ROM - Derpfest
Magisk - magisk v23.0

Lsposed installed instead of Edxposed

Hi i have installed Lsposed instead of xposed and in lsposed you have to give permission to the module to certain app in order to effect those apps and i was wondering what app should i give permission to?
Ps: i have given permission to "System Framework" but the module not working

Error due to connection timeout to service popping up minute for minute whenever playing back audio in-app

First, congrats for releasing v2/v2.1, you've really outdone yourself. Thanks to the update the app is finally working well on my OnePlus 8 Pro AOSP 12.1.

However I still have a minor issue: Whenever I play audio in an app like TikTok, YouTube or Plex I get the error notification in set intervals while playing back (a video for example). Would it be possible to check for other apps playing audio and if they do not try to run the recognition?

Says Exposed is not installed but is installed

I'm on the OP 6, with awaken os aka. Pixel experience Rom android 12.
I have installed everything like the guide say's, but if I test the mod is says failed to start. And in the log dump it says Xposed not installed.
Screenshot_20220422-125754_Shell.png
AndScreenshot_20220422-125749_Shell.png

I have Lsposed

Non-root version which has to be triggered manually

I'm not aware of a open-source song recognition app that works offline, so even being able to do it triggered manually is a very useful feature for privacy enthusiasts. Having it as a normal app in app stores also means more people can be informed of the enhanced root+Xposed version available via the app.

Mod app loads forever

So I noticed this behavior where the app needs to have it's cache cleared and force stopped or else the "now playing" tab would load continuously/way longer than usual

lv_0_20220619231032.mp4

Ask Google after song recognition not working

When the song is recognised, I select "Ask Google" nothing happens. Is this not working (known bug)?
Anyways now playing working very good on my device, very much thanks for such a mod.
Screenshot_20220620-201842_Ambient Music Mod

Sometimes the "now playing history" shortcut and probably also the recognition stops

I assume that this might not only affect the shortcut but that's the only place where I noticed it, sometimes the shortcut for the now playing history stops working, and using Scoop I recorded the crash log and hope you can find any use in it

FATAL EXCEPTION: DefaultDispatcher-worker-1
Process: com.google.intelligence.sense, PID: 24499
android.view.ViewRootImpl$CalledFromWrongThreadException: Only the original thread that created a view hierarchy can touch its views.
at android.view.ViewRootImpl.checkThread(ViewRootImpl.java:9392)
at android.view.ViewRootImpl.requestLayout(ViewRootImpl.java:1757)
at android.view.View.requestLayout(View.java:25595)
at android.view.View.requestLayout(View.java:25595)
at android.view.View.requestLayout(View.java:25595)
at android.view.View.requestLayout(View.java:25595)
at android.view.View.requestLayout(View.java:25595)
at android.widget.AbsListView.requestLayout(AbsListView.java:2034)
at android.view.View.requestLayout(View.java:25595)
at android.view.View.requestLayout(View.java:25595)
at android.view.View.requestLayout(View.java:25595)
at android.view.View.requestLayout(View.java:25595)
at android.widget.ImageView.setImageDrawable(ImageView.java:605)
at com.kieronquinn.app.ambientmusicmod.xposed.apps.PixelAmbientServices$setAlbumArtImage$1.invokeSuspend(PixelAmbientServices.kt:477)
at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(ContinuationImpl.kt:33)
at kotlinx.coroutines.DispatchedTask.run(DispatchedTask.kt:106)
at kotlinx.coroutines.scheduling.CoroutineScheduler.runSafely(CoroutineScheduler.kt:571)
at kotlinx.coroutines.scheduling.CoroutineScheduler$Worker.executeTask(CoroutineScheduler.kt:750)
at kotlinx.coroutines.scheduling.CoroutineScheduler$Worker.runWorker(CoroutineScheduler.kt:678)
at kotlinx.coroutines.scheduling.CoroutineScheduler$Worker.run(CoroutineScheduler.kt:665)

Test recognition failed

Screenshot_20210420-141540

Tried all the stuff mentioned in the trouble shooting guide.

Handset redmi note 6 pro-tulip

Rom Posp April, gapps nik gapps full latest

Magisk latest, edxposed and riru installed

Whitelisted the apps as said in troubleshooting guide and also disabled battery optimization for those apps

Latest pixel ambient services not supported

Latest pixel ambient services doesn't seem to be supported, or at least, gives a warning.
Version tested to not work: 1.0.382690186

Opened this issue as an heads-up, to let know of the new version.

'Hey Google' issue

When the feature is on 'Hey Google' doesn't work. OnePlus 7 pro, android 11, Pixel epxeircen custom rom

LSPosed Invisible

Ambient Music Mod does not show up in the LSPosed app list. I've enabled the module for "System Framework" and "Pixel Ambient Services" but Ambient Music Mod app is missing.

Ambient Music Failed To Start

My device :
Redmi Note 9 Pro Max (Excalibur)
Android -10
I have Magisk Installed
And EdExposed module is also running.I tried other troubleshooting options but that doesn't seem to work.

When I tested recognition it gave Ambient Music Failed To Start Error.
Initially I tried to bypass the 'Sound Model Compatibility' but after a reboot It says that it is compatable.

BTW here is the Log Dump :

ambient_music_mod_log_dump_2021-04-20T17:10:12.463.zip

Doesn't Recognise Songs - Noise during playback

I have tried recognising songs manually from the Ambient Music Mod App. I played a song, the app showed no results found. Tried playing the playback and it was full of noise. Tried lowering the gain upto 0.1x and still the noise was there.

I am using Galaxy S20 FE 5G, not rooted. Can give logs if needed.

Thanks for your Awesome work!

can't get the right pixel ambient services app

So my phone is oneplus 7t pro, and I don't have pixel ambient services app in stock. So I tried different version of this from apkmirror, but still cannot get the right one. I tried the oldest version which is 1.0.17, but still when I click "lauch ambient music app" button I got the mod app shut down immediatly, and it says that pixel ambient services version is not right. I try click "test recognition" and it fail to start.

Incorrect window insets

Device - Asus Zenfone Max Pro M1 (X00td)
Android version - 10
Rom - Pixel Experience

Window insets aren't being applied properly, resulting in parts of UI falling under the navbar in 3 button navigation mode

image
image

Sound model Incompatible issue POCO F1

I don't have any sound modules active whatsoever, magisk and edxposed working fine but still can't get it fixed on my POCO F1. I tried it on pixel experience rom and other roms as well but still showing the same message!!

Servers offline?

Had issues where databases wouldn't download and the app could not connect to the server so I tried a reinstall. Now it's not even able to fetch the Now Playing apk file. Are the servers down for maintenance?
Screenshot_20220620-221100_Ambient Music Mod.png

Didn't Install Pixel Ambient Services and causes Play Services to crash

So I tried to follow the instructions just like you mentioned, Installed the Magisk module, enabled the XPosed module and whitelisted the apps, but at that point I realized that I don't have the Pixel Ambient Services (I assume the module is supposed to install it themselves because you no where mention which version is even supported). It also made my play services continuously crash. I don't know if this is because my Phone (OnePlus 7 Pro) was listed as incompatible but I don't think that's the cause. Please let me know if this is my fault or if there's something I can do to fix it, thank you

Screenshot_20211205-203406
Screenshot_20211205-204053

Ambient Music failed to start

Screenshot_20210529-084711874
System: Android 10 Pixel Expirence
Device: Xiaomi 9se (grus)

Magisk module and Exposed have installed, but I can't test recognize

Adaptive notifications not working after enabling mod

It seems that after enabling this module adaptive notifications stops working?
It's even gone from the settings within android: Screenshoot

Not sure of what other info I can provide regarding this and if there's any one else experiencing this.

OnePlus 8 on Android 11
Mod: 1.1.1

Overlay causing bootloop with some OEMs (Samsung, OnePlus)

  • Oneplus 8
  • Android 12
  • Version 2.0.1

When installing the overlay a round hole near the supposed camera location appears and the clock disappears from the statusbar. The power button seems to be remapped from opening the power menu, to opening the Google Assistant. To open the power menu I need to do Power+Vol Up.

See attached image:

image

Any other info needed let me know.

[Request] Tasker Enable/Disable intents

It would be great to have some intents automate as we want in Tasker. Some like:

  • Enable Now Playing
  • Disable Now Playing
  • Start Recognise On Device
  • Start Recognise Online

InstallerBuildViewModel.kt and InstallerBuildViewModelImpl.kt are missing from source code

The classes com.kieronquinn.app.ambientmusicmod.app.ui.installer.build.InstallerBuildViewModel and com.kieronquinn.app.ambientmusicmod.app.ui.installer.build.InstallerBuildViewModelImpl are mentioned in AmbientApplication.kt but the whole ui/installer/build package is missing with them in it. Therefore the app wont build or if outcommenting those the whole Magisk module builder tab is missing.

Often 'Ambient music failed to start' But sometimes it works

As you can see it worked once and then it's broken again.

I know you need the logs but I'm not sure which ones you need, check screenshot.

Latest magisk & exposed + riru
Oneplus 7 Pro - Oxygen OS 11.0.0.2
Battery optimization for both disabled

Screenshot_20210420-120308
Screenshot_20210420-120330

Screenshot_20210420-115457
Screenshot_20210420-115644
Screenshot_20210420-115727
Screenshot_20210420-115737

[Request] Wear OS companion app

The smartphone app works very well, but I imagine how it would be even better if I could do some things directly from my watch.

If that were possible, the companion app could have the following features:

  • Complications to start recognize "on device" or "online".
  • Tile to see last recognized song and start a new recognize.
  • UI with Now Playing History

Audio playback distored.

Great job on releasing V2 .
But there is a lack of option to reduce amplification, my playback is getting distorted at even at 1xGrain.

Ruined my OnePlus 7 pro

When installed and rebooted my op I got bootloop and now after few bootlops my lock screen not working so I can't access my phone. Please help quick

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.