I like M-s h r for highlighting a regexp throughout my buffer: I can, for example, do that, type in foo.*bar and it highlights what you'd expect.

I'd like cc-isearch-menu to become my go-to interface for search-related stuff, and indeed the h option seems like it should be able to replace the above M-s h r. But it doesn't seem to work: if I do C-s, enter foo.*bar, then F2 to invoke the menu, and do h, it doesn't highlight that regexp.

It seems that in the above workflow, the string passed along isn't interpreted as a regexp, but as a literal string.

Is this a bug, or is there some nice way to do this kind of regexp highlighting?

Rationale provided in kickingvegas/casual-lib#6.

Here's a workflow that gives a "this should never happen" error:

1. I start a search with C-s.

2. I realize I actually want regexp searching. I hit F2 to get a lovely menu :) I then do X.

3. I see the Regexp I-search prompt in the minibuffer -- but the first character I type results in showing the Warning buffer:

   ⛔ Error (transient): Inconsistent transient state detected.
   This should never happen.
   Please open an issue and post the shown command log.

The messages buffer shows this, which I think is related:

Unbound suffix: ‘f’ (Use ‘C-g’ to abort, ‘?’ for help) [isearch-printing-char]

Not sure if this is related, but after step (1), if I type in some text, then do F2 and X, I expected to see my currently-entered text -- since the menu says "toggle". But I get a blank prompt. It would be nice if the menu, when toggling, would pull in the existing search string.

For the "pull..." items, you can use those keys multiple times to pull in multiple things. It would be nice if your lovely transient menu showed the keybinding to make it easier for the user to do those more than once.

Example workflow:

1. I do C-s to start isearch and want to search for the word at point
2. I do F2 to show your menu, see "Pull next word or character from buffer" and do w.
3. That pulls in the word. But now I want the next word.
4. I could do F2 then w again, but I know there's some easy keybinding I can just repeatedly use. What is that?

Idea; just add the isearch keybinding to your description, so for example, the menu would show

w Pull next word or character from buffer (C-w)

...or similar, so that after seeing that once, I know I can just keep hitting C-w to pull in more words.

At current the menu gets dismissed when a toggle item is selected. Change so that whenever any toggle item is selected, the menu is not dismissed.

Per suggestion from @dandrake in #21, display the search text in the minibuffer upon raising cc-isearch-menu.

Upgrade Makefile to be in alignment with Casual Suite.

UX Change

When pulling in search text (symbol, thing, line, word), keep the menu displayed rather than having it dismiss when the next word is selected.

This way the user still has the option to query replace without having to raise the dialog again.

Update install instructions to use keymap-set.

• README.org
• casual-isearch.el

At current the default binding for casual-isearch-tmenu is <f2>. As this binding only applies when in isearch mode, argument is to change the default binding to C-o to be consistent with Casual Suite.

key sequence "t" then "r" will cause a Transient error. Issued ticket to Transient for investigation.

magit/transient#281

Rebind keys so that:

• "r" is bound to isearch-query-replace
• "q" is bound to dismissing the menu

Currently "q" is bound to isearch-query-replace which upon reflection is idiosyncratic:

• the original menu binding fixated too much on "query" rather than "replace".
• "q" is often used to quit or dismiss a window in Emacs.

Given the above, make a UI change.

Per input from @dandrake from https://mathstodon.xyz/@ddrake/112037755737321142, add multi-isearch-buffers like behavior to cc-isearch-menu.

Rename this package to be in alignment with the Casual Suite of porcelains.

Change navigation to conform to Transient conventions.

Motivated from this issue: kickingvegas/casual-info#9