kiandra / delta-jquery-ui-theme Goto Github PK

On Linux, your button-order detection uses Windows button ordering.

While there's no reliable way to match Linux button order (It's configurable and the default varies between desktop environments), all data I've been able to find indicates that the majority of Linux users are on desktop environments which default to MacOS button order. (GNOME, Xfce, LXDE, and anything else based on GTK+)

KDE and a newcomer named Razor-Qt are the only ones which default to Windows button order and, since it's controlled by the theme, if the user decides to use a GTK+ theme via QGtkStyle, then it'll obey GTK+'s decision to default to MacOS order too.

Also, there are good, objective reasons that it's better to default to "OK in the corner, the rest to the left" and then make an exception if you detect Windows.

If you really want to be as accurate as possible, use this detection logic:

Is the OS Windows?
    Yes: Put cancel on the right.
    No: Continue to next question.
Is the browser Konqueror, Arora, or rekonq? (QtWebKit-based browsers for Linux)
    Yes: put cancel on the right.
    No: Fall back to putting OK on the right.

having 42 ! important statements in your stylesheets is really bad, and make them hard to customize..

Looking through the demo I noticed a few things. Might be worth creating individual tickets for some:

• no autocomplete (menu!), accordion and progressbar on the demo page
• radio button set doesn't show the pressed button
• datepicker: next/prev month hover styles are odd (pixel shifting), missing hover styles on dates
• dialog: the close icon looks very out of place, doesn't really fit into the otherwise nice theme

Let me know if you have any questions, also on #jqueryui-dev on Freenode.

With jQuery UI 1.10... the modal close does not show the image and sometimes moves position on-click (preventing ability to click).

After some troubleshooting on the issue... looks like as of jQuery UI 1.10 the dialog "close" is now a <button> with all the button classes (as opposed to <a>). Because the buttons styles in the .css document are well after the the dialog styles, there are a lot of styles being over-ridden.

the theme don't work with this plugin:
http://trentrichardson.com/examples/timepicker/

Twitter users @mmilo and @ashuvashu both raised the following issue when going into "dark mode" in the demo page and FF15.