kgoedecke / loopback-swift-crud-example Goto Github PK

It seems to me that the intended way to create a new model object is something like the following:

let newWidget = repository.modelWithDictionary(nil) as! Widget

instead of let newWidget = Widget() found at Line 33 of WidgetViewController.swift (although the above looks a bit too wordy and I think the API needs refinements).

If a model is created in the above way, we can call newWidget.saveWithSuccess(...) directly, instead of converting a model to a dictionary and then recreate a model (MyTableViewController.swift#L99-L100 and LBRepositoryController.swift#L64)

Also, if a model is returned from the framework, I think we can call destroyWithSuccess() directly without performing findById() as seen at LBRepositoryController.swift#L103

I'm wondering if the above points are possibly something better be considered. Could you share some thoughts on this?