Weird "next tab" behavior to reach Goto tab with arrows about quickmove-extension HOT 6 CLOSED

Indeed, good catch, thank you for debugging! The code is still a bit fragile, but I'm taking the easy path today. Took care in a8bafcd

from quickmove-extension.

Huh, I was experiencing this while testing and thought I fixed it. Will take another look.

from quickmove-extension.

Can you double check you have 2.7.0? For that version the order or the tabs is move,copy,goto,tag: https://github.com/kewisch/quickmove-extension/blob/v2.7.0/src/popup/popup.html#L25

from quickmove-extension.

🤷‍♂️

from quickmove-extension.

Hmm wait, there is a different behavior depending on how the popup is raised:

• if I click on the Quick Move button then use arrows, it behaves as expected
• If I use ctrl-shift-N, then use arrows, then it's buggy

from quickmove-extension.

The bug disappears when I do

diff --git a/src/background.js b/src/background.js
index 6d35860..e20efd4 100644
--- a/src/background.js
+++ b/src/background.js
@@ -129,7 +129,7 @@ browser.runtime.onInstalled.addListener(({ reason, previousVersion }) => {
 
 browser.commands.onCommand.addListener(async (name) => {
   let popupOrder = [browser.messageDisplayAction, browser.browserAction];
-  let popupUrl =`/popup/popup.html?action=${name}&allowed=move,copy,tag,goto`;
+  let popupUrl =`/popup/popup.html?action=${name}&allowed=move,copy,goto,tag`;
   if (name == "goto") {
     popupOrder = popupOrder.reverse();
   }

Note that there is also a "move,copy,tag,goto" in src/popup/popup.js L51 but I didn't have to change it.

from quickmove-extension.