kevinwolz / hisafer Goto Github PK

This will help with tile plots and other analyses.

Currently it is always renamed to "weather.wth"

Should be generic and require the supply of a year.

For crop water, nitrogen and thermal stress between two selected phenological phases. Francesco has some scripts that do this.

Make build_pld, build_sim, and build_tree more generic by reading in the tempalte files as a list, making edits, and the re-writing out using those lists.

This function cannot support multiple tree species with geometryOption = 1 or any trees under geometryOption = 3.

Francesco has some scripts that do this

This could display: 3D scene, core variables of interest in a nice output (pdf?)

Do this instead of having them hard-coded in utils.R

What data to include? LER data?

Francesco has ideas and some scripts for this.

Add crop and forestry template files to the hisafer extdata folder, and include these as valid “default” template options when defining simulations. Maybe store the paths to these on the útiles.R script and then just reference these paths where necessary.

Francesco has some scripts that do this. This can be used as a check before merging to hops and also as a way to determine which parameters should be used as columns to augment the hop data.

Marie has this in the hisafe_R_code repository.

• current hisafe version number
• release date
• location on computer
• Capsis data
• Java data

This is only necessary if there are duplicate parameter names across files!!

add check to plot_hisafe_voxels() to throw error/warning when depths used between Sims are not the same

Is this even supported by hisafe anymore?

do it during define from the start?

Marie has an old script for this on the N cycle in the hisafe_R_code repository.

Hi-sAFe doesn't support this directly, but it could be done when building a crop rotation.

Francesco has some scripts that do this.

I can't find where to extract the Capsis and STICS version numbers from within the Capsis folder.

This would make the function output a table of the data to plot rather than the plot itself

Create a new class called “face” for Forestry, Agroforestry, and Crop Experiment. This object will be a list of three hop objects, one for each of the respective system types. Future analysis functions to calculate LER, compare values, etc. can act on face objects. create_face() can run several checks on the respective hop objects to make sure they contain what they are supposed to.

Have these examples leverage example data included within the package?

The last column to not plot in the data frame varies by output profile. Right now, the name of that column is hard-coded into plot_hisafe_ts(), and all columns after this one are plotted. Are these first set of columns constant and not changeable by a user? It seems so, which means the currently solution is fine, but if not, then another solution will be needed (or all numeric columns will need to be plotted even if they are dumb).