kevinjump / jumoo.usync Goto Github PK

Hi KevinJump,

I want to report an issue, which happens when I use usync with Umbraco 7.2 RC.

As you might know, a new feature in Umbraco 7.2 is Compositions (which is like Mixins).
When I create a new document type, usync writes out new def.config file, with section. But when I go to another computer, pull code and run, there is error (please see attached file).

After I deleted that section, usync worked again.

Please update usync to be compatible with this new feature.
Thank you.

We've encountered an issue several times where the json for a grid layout is modified by multiple developers (even simple changes like which grid editors are allowed) on their feature branches and then merging them is difficult because the json is collapsed down to a single line. In these cases we've resorted to extracting out the raw json from both and putting them in beyond compare. It would be very nice though if instead, these values were wrapped in a CDATA and line feeds were preserved.

Here is an abbreviated example of what we see:

<DataType Name="Grid - Text Page" Key="" Id="Umbraco.Grid" DatabaseType="Ntext">
  <PreValues>
    <PreValue Id="1134" Value="{&#xD;&#xA;  &quot;styles&quot;: [&#xD;&#xA;    {&#xD;&#xA;      &quot;label&quot;: &quot;Background Image&quot;,&#xD;&#xA;      &quot;description&quot;
    ...58,000+ chars..." Alias="items" />
  </PreValues>
</DataType>

We are using LeBlender but I don't think that matters. I believe storing json in Ntext is becoming more popular too so maybe a generic fix would be best. Some suggestions:

• Always use CDATA for PreValue so the line feeds are preserved
• Detect when CDATA for PreValue would be better, maybe any of these:
  • First char is {
  • Value contains \n
  • Character length > 300

Thanks!

The Media Items is using UmbracoFile to determine the filename, which is where the problem is.

We are currently using the NuGet uSync package and require a NuGet package for uSync Content Edition.

If you rename a node with a different character case (Example: from "Page Title" to "page title"). the function "jumoo.usync.content.ContentEvents.SaveContentItemsToDisk" raises a "Source and destination path must be different" exception.

if ( (sourceName!= null) && (item.Name != sourceName ) )
                {
                    LogHelper.Info<ContentExporter>("Rename {0}", () => item.Name);
                    w.RenameContent(item, SourceInfo.GetName(item.Key));
                }

the following condition "renames" the content even when the content name is just changed from lowercase/uppercase. because windows filesystem is case insensitive, source and destination files got exactly the same name.

Not sure if this is something that will be addressed or not, though would be nice to track it through GitHub.

it is possible for media types to associate multiple files, and for extra files to be stored in other values than umbracoFile, at the moment uSync only handles the files in umbracoFile.

extend the File Classes so when it's exporting files it prefixes them with their property ? (so umbracoFile_somelongfilename.jpg
thumbnail_somethumbnailname.jpg

then on import of the files we can take the first bit of the name, and use it to match the element back to the property within umbraco (and the code won't need to much altering on an import this way)