/undo throws error while /undo KevDaDev (or your username) works correctly

Add multiple materials to voxelreplace

To Reproduce
Steps to reproduce the behavior:

1. Select ballBrush with a voxel material of air
2. rightclick a block in range
3. See how the brush fires twice

Expected behavior
The brush should only fire once

Block ids are the old minecraft system of identifying blocks. This was removed in MC 1.13. Voxelsniper currently translates these old ids into the new blocks, but this list is outdated, does not always return the correct block in all situations and does not include any blocks since 1.13. Because of this, and because it might take some time to fix all the inconsistencies, we ask for feedback on whether this should be removed. Any comment is greatly appreciated.

Description:
Using a brush while the player is above the world height limit will truncate the raycast and use the brush as if the targeted block was exactly at the worldheight.

Repro steps:

• Fly above the world height limit (y=320)
• Use the ball tool
• Target a block on the ground and right click

Expected:
Ball appears on the ground

Actual:
Ball appears in the air at the height limit.

Minecraft version: 1.19.2
Voxelsniper version: 8.1.3
Server/client software: Spigot

From the comment, it looks like this is supposed to check if the block is solid? Would Material#isSolid work here?
Also: how are water and snow considered solid blocks 😮

Originally posted by @Lennart99 in #30 (comment)

https://github.com/KevinDaGame/VoxelSniper/blob/master/src/main/java/com/thevoxelbox/voxelsniper/brush/GenerateTreeBrush.java#L181-L183

randomise blocks easily on a brush

    Dont really like this passing around of 'airFound' maybe something like this would be better:

airFound = checkBlock(world, x + 1, y, z ) || airFound

Originally posted by @Lennart99 in #82 (comment)

Say a player owns two plots, seperated by a road (not yet merged). As such:

If the snipe target block is located in plot A, and (for example due to a large brush) it has changes inside plot B. Should blocks in plot B be affected?

Describe the bug
The set brush seems to not properly clear it's cache after the first use

To Reproduce
Steps to reproduce the behavior:

1. select the set brush
2. Select first point
3. Select the second point
4. It does what it should
5. Now select another first point
6. It immediately does a new set operation

Describe the bug
/B e smooth apparently makes an air ball

Desktop (please complete the following information):

• Minecraft version: 1.19.3
• Voxelsniper version: 8.4.0
• Server/client software Paper

Describe the bug
BiomeBrush and BiomeBallBrush are not undoable

To Reproduce
Steps to reproduce the behavior:

1. select a biome brush
2. use the brush
3. attempt to undo

Expected behavior
The brush should be undone when trying to undo

Desktop (please complete the following information):

• Minecraft version: 1.19.2
• Voxelsniper version: 8.2.1
• Server/client software Paper

Additional context
Undo should be abstracted and have subclasses with their own undo behaviour

Hello, as I mentioned earlier today on discord, I'd like to add a feature that would allow me to have no brush selected on my arrow/gunpowder at all.

This is the reason why I want this, copied from discord: "because the default brush is set to "snipe" and some admins that have perms for voxelsniper will accidentally delete blocks, or even worse chests while opening them and having an arrow in their hand, not realizing what's about to happen lol"

Describe the bug
When the version is for example set to 8.7.0-dev, the VersionChecker will throw a numberformatexeption

Rot2DBrush: sometimes still goes wrong (places extra blocks, probably rounding error or something, also present in old version)
Rot2DvertBrush: Same issue as above
Rot3DBrush: doesn't seem to work at all

Additionally, we should look into abstracting this in a way to prevent duplicate code. The code for the 2d brushes, for example, is almost identical. Creating a generic rotation method, that can be used by all three brushes, might be a good start.

Describe the bug
The /performer doesn't recognize polybrushes as performer brushes

Expected behaviour
The command should check if it is a polybrush and if yes, it should check if it has a performer property

Describe the bug
Performance issues in version 8.2.0

To Reproduce
Steps to reproduce the behavior:

1. Install v8.2.0
2. Use erode brush at size 10

Expected behavior
It should be faster

Desktop (please complete the following information):

• Minecraft version: 1.19.2
• Voxelsniper version: 8.2.0
• Server/client software: Spigot

The current implementation does not use the not so new 3d biomes added in 1.15

Describe the solution you'd like
A brush that places down snow layers. If there already is a snow layer, it should add to that.

It should only try to place snow layers on (full, solid?) blocks with a block below it,

Parameters

Brush size: The size of the affected area

1st image:
so it would place snow like this. It would "see" (sorry... not that smart with how plugins work...) that there is a 7 block gap in the rear one, so it would place a 7 high snow, then a 6 high, etc etc to be smooth. Or the middle one, it would see its only 6 and skip a level to compensate. And so on so forth. It would leave 1 block at the end to be a snow block to improve the smoothness.

2nd img/3rd:
I think it would also be important for it to see that if there are two blocks across from each other it would do something like the second image and not like the img.

No idea if this makes sense
Image

idk if its possible but my suggestion is that within the brush size it will try to go from something like this in the 1st img to one click to the second image

and i made it simple to show but I think it would be really cool if it could figure it out itself on how it would work so you could use it on a gentle slope for example and it would be able to sort it out to be smooth


I think it would also have to see what snow is already place down so if you were running the brush along a slope it wouldn't conflict with the last time the brush was used if they overlapped if that makes sense?

Also, since we are on topic on brushes, anyway to make a "config" of "Natural" blocks to add and remove so you don't have to add a full list, on what to avoid. this is for /b eraser
https://www.spigotmc.org/threads/voxelsniper.571866/#post-4532766

Describe the bug
For example snipe brush will repeat previous actions whenever you snipe

Describe the bug
Voxelsniper throws a NPE when a player without op/permission joins the server.

To Reproduce
Steps to reproduce the behavior:

1. Install plugin
2. Join server while not having OP and not having any voxelsniper permission
3. See error

Expected behavior
No exception being thrown by voxelsniper

Screenshots

Desktop (please complete the following information):

• Minecraft version: 1.19.3 (from stacktrace)
• Voxelsniper version: 8.4.2
• Server/client software: AdvancedSlimePaper

MessageType is scheduled for removal

Examples: ExtrudeBrush, PullBrush, OceanBrush, FlatOceanBrush, ErodeBrush

Doesnt accept this: /vvar height 2

Hi,
Since VoxelSniper 8.4.0, I couldn't load EcoEnchant and VoxelSniper at the same time on my Paper server 1.19.3.

To Reproduce

1. Run Paper server 1.19.3 with :

• Voxelsniper 8.4.0
• EcoEnchant 9.15.3
• eco 6.48.3 (eco is required for ecoenchant)

2. See that kotlin seems to be causing the bug

Expected behavior
To load EcoEnchant plugin.

Desktop:

• Minecraft version: 1.19.3
• Voxelsniper version: 8.4.0
• Server software : Paper

Additional context
I didn't have this error before VoxelSniper 8.4.0.

server log/crash report
https://pastebin.com/h8Gxi35G

Thanks for reading me

This would allow for example easy gradients on a ball brush for terraforming

Describe the bug

This message has the placeholder after the correct replacement
To Reproduce
Steps to reproduce the behavior:

1. /b b mm

Code right now does almost the same thing 8 times in a row, without using loops, resulting in bad code.

https://github.com/KevinDaGame/VoxelSniper/blob/master/src/main/java/com/thevoxelbox/voxelsniper/brush/GenerateTreeBrush.java#L120

https://github.com/KevinDaGame/VoxelSniper/blob/master/src/main/java/com/thevoxelbox/voxelsniper/brush/GenerateTreeBrush.java#L298

Remove or new keybind?

Describe the bug
I download the plugin on my spigot server in 1.19.3 and the server doesn't recognize the plugin. (I write /plugins in the console)

To Reproduce
Steps to reproduce the behavior:

1. Download VoxelSniper 8.6.0
2. Put it in the "plugins" folder
3. Restart the server
4. lunch "/plugins"
5. See that there aren't Voxel Sniper there

Expected behavior
I want to have voxel sniper in my server
Screenshots

Desktop (please complete the following information):

• Minecraft version: 1.19.3
• Voxelsniper version: 8.6.0
• Server/client software: Spigot

According to Zyra it works on voxelsniper 6.1.2 on 1.17

hello , I'm testing the new version (1.19)with the voxel sniper , I'm brushing walls (eg stone in granite) , with the usual command /b b p cm , he places me new blocks (he does not convert them he increases them ). My question are there commands that have been replaced ? maybe I'm also completely wrong with the question here , sorry if so .

https://github.com/KevinDaGame/VoxelSniper/blob/master/src/main/java/com/thevoxelbox/voxelsniper/brush/DrainBrush.java#L36

[18:58:44] [Server thread/INFO]: [VoxelSniper] Enabling VoxelSniper v8.1.1
[18:58:45] [Server thread/ERROR]: Error occurred while enabling VoxelSniper v8.1.1 (Is it up to date?)
java.lang.NoSuchMethodError: org/yaml/snakeyaml/LoaderOptions.setProcessComments(Z)V (loaded from file:/var/directory_serv/minecraft_381837/cache/patched_1.16.5.jar by jdk.internal.loader.ClassLoaders$AppClassLoader@798c5748) called from class com.thevoxelbox.voxelsniper.util.YamlConfiguration (loaded from file:/var/directory_serv/minecraft_381837/plugins/VoxelSniper-8.1.1.jar by PluginClassLoader{plugin=VoxelSniper v8.1.1, pluginEnabled=true, url=plugins/VoxelSniper-8.1.1.jar}).
at com.thevoxelbox.voxelsniper.util.YamlConfiguration.getYaml(YamlConfiguration.java:25) ~[?:?]
at com.thevoxelbox.voxelsniper.util.YamlConfiguration.(YamlConfiguration.java:50) ~[?:?]
at com.thevoxelbox.voxelsniper.util.Messages.load(Messages.java:367) ~[?:?]

A system that moves configuration files to a backup folder on voxelsniper update

          I'm aware that it won't affect existing installs. That's fine. I think that we should make a migration setting that moves the old config (and lang files) to a backup folder so they are recoverable in any case, which should fix the existing server problem

Originally posted by @KevinDaGame in #140 (comment)

It is likely this line in BlockHelper

final int i = (bestMatch.getArt().getId() + (back ? -1 : 1) + Art.values().length) % Art.values().length;

This was a feature of the old plugin that has seemingly been removed by ervinchai, the past maintainer. If we were to implement this we would have to redo the file structure since the old version uses binary with item ids. I suggest using json for this

https://www.mcmiddleearth.com/community/wiki/voxel-reference-guide-tutorials/

When this part of the plugin worked I would used the command /b sl oak which would select the custom oak stencil. when I clicked a targeted block with the gun powder the custom oak tree as defined by the stencil would be place on top of the targeted block. because there was more than one oak tree file schematic in the stencil list defined oak tree, it randomizes which one is placed when i click the targeted block. I have compressed the stencils and stencilLists folders into .zip files

See examples below. Stencils can (as far as I know) only be opened with a hex editor
stencils.zip
StencilLists.zip

Describe the bug
There are 3 problems with the GenerateTreeBrush where issues 1 and 2 are kinda related.

1. Root parameters (rootMin, rootMax, rootLength and rootFloat (I don't know what this one is supposed to do) are supposed to change correctly the roots behavior of the generated tree.
   No matter what I change I only get either really really thin straight roots going to 4 directions, or 1 root block in 4 corners (Issue is circled in red).
   I also can make the roots competely disappear when lowering rootLength.
   The whole problem might be related to the rootMax parameter seemingly being backend-limited to 3.
   I can set it to 50 but when using rootMin it auto limits itself to 2 to not exceed maxHeight (which is supposed to be 50).

2. When using minHeight and maxHeight, I'm also somehow backend-limited to a minHeight of 14 and a maxHeight of 19.
   We can see this because minHeight and maxHeight auto limits themselves even when the values are supposed to be correct.

3. When generating a rather big tree, the leaves are not connected close enough to the wood and thus are falling (Issue is circled in blue).
   The "branch" don't put any wood in it, hence the issue when having long branches (branchLength parameters).

Suggested improvement for the third issue:
Let people choose among all blocks of the game when using Leaves and Wood parameters ?
Don't limit them to woods materials and leaves materials only (allow players to edit metadata of the block maybe, this way we would be able to specify [persistent=true] and have no decay on leaves)
Though this wouldn't fix the base issue where branches are supposed to be made of the tree-material. Here, they are generated as 100% of the leaves material

Expected behavior

Screenshots
see here

Desktop (please complete the following information):

• Minecraft version: 1.19.2
• Voxelsniper version: 8.4.3
• Server/client software: Purpur 1.19.2-1858

Additional informations
I'm Shook#0781 on Discord if you need more informations. I will answer faster here

This occurs in master, as well as abstraction

Is your feature request related to a problem? Please describe.
Support for worldguard & plotsquared

Describe the solution you'd like
Currently, I have a worldguard/plotsquared setup on a creative server and it'd be great if voxelsniper also adheres to the plot permissions of each player (current situation allows players to grief roads with voxel).

This doesn't make much sense to me, since you never really want to get the (String) handles from the class, but the other way around is necessary every time another brush is selected

https://github.com/KevinDaGame/VoxelSniper/blob/master/src/main/java/com/thevoxelbox/voxelsniper/VoxelBrushManager.java#L92

Exact command: /btool assign arrow stone_shovel