kevcodez / gradle-upgrade-interactive Goto Github PK

even if i select all dependencies to update, only the toplevel build.gradle was edited and all others remain the seme (even without an error or warning message).

First, wow thank you so much for making this awesome program.
It works really great and is extremely helpful :)

The Gradle Versions Plugin supports selecting different revision types.

Could you add support for that as well?

PS: The gif you uploaded seems to be broken/missing. If you upload it to github as a comment in an issue/PR then you can just use that instead of hosting it elsewhere.

Please fix in the file index.js the line number 291:
const reportJsonPath = "${outputDir}/report.json";
the variable outputDir is not set because of " sign
The right way should be:
const reportJsonPath = ${outputDir}/report.json;

Cheers

Installing the "new" 0.8.0 results in this error for me:

mduft@fril0666 /work/workspaces/deployment/deployment $ gradle-upgrade-interactive 
file:///home/mduft/.nvm/versions/node/v20.9.0/lib/node_modules/gradle-upgrade-interactive/buildFiles.js:7
  exports.buildFiles = buildFiles;
  ^

ReferenceError: exports is not defined in ES module scope
This file is being treated as an ES module because it has a '.js' file extension and '/home/mduft/.nvm/versions/node/v20.9.0/lib/node_modules/gradle-upgrade-interactive/package.json' contains "type": "module". To treat it as a CommonJS script, rename it to use the '.cjs' file extension.
    at getBuildFiles (file:///home/mduft/.nvm/versions/node/v20.9.0/lib/node_modules/gradle-upgrade-interactive/buildFiles.js:7:3)
    at file:///home/mduft/.nvm/versions/node/v20.9.0/lib/node_modules/gradle-upgrade-interactive/index.js:37:20
    at ModuleJob.run (node:internal/modules/esm/module_job:217:25)
    at async ModuleLoader.import (node:internal/modules/esm/loader:316:24)
    at async loadESM (node:internal/process/esm_loader:34:7)
    at async handleMainPromise (node:internal/modules/run_main:66:12)

Node.js v20.9.0

Just to be sure, I also tried with older node.js LTS versions (18 & 16) with the same result. Downgrading to 0.7.4 brings it back to working order :)

Thanks for making something possible in Gradle that has been available for Maven for a long time :)

One possible improvement could be to provide support for versions that are defined in another file, such as gradle/dependencies.gradle.

The separate file is only part of the problem. Some like to define the dependency itself like:

ext {
    versions = [
        springBootVersion: '2.2.2.RELEASE',
    ]
    libs = [
        springBootStarterWeb: "org.springframework.boot:spring-boot-starter-web:${versions.springBootVersion}",
}

In such case the dependency would be referenced in build.gradle with something like implementation libs.springBootStarterWeb.

Quickly browsing through the code it seems that it's just reading the build file as a string and doing string replacements. Do you think it would be feasible to try to implement separate file support with the current approach?