kentdlee / coco Goto Github PK

CoCo don't have garbage collection currently, so we have memory leak.

The PyObject.refCount may help if we call incRef,decRef when we need copy or delete PyObject.
But if we have circular reference, refCount won't work.
So we need GC strategy which can handle circular references. I'm trying to use Recycler:

[1] "A Pure Reference Counting Garbage Collector", 2001, Bacon, D. F., Attanasio, C. R., Rajan, V. T., Smith, S. E., & LEE, H.

https://github.com/thrunduil/cyclic_rc

#include "cyclic_rc/shared_ptr.h"

class PyObject;
using PyObjectPtr = cyclic_rc::shared_ptr<PyObject, false>;

class PyObject : public cyclic_rc::cyclic_rc_base<false> {
 public:
  PyObject();
  virtual ~PyObject();
  virtual void visit_children(int t) override {}
  PyObjectPtr callMethod(PyObjectPtr& my_ptr, string name, vector<PyObjectPtr>* args);
  ...
};

class PyList : public PyObject {
 public:
  void visit_children(int t) override {
    for (auto &i : data) {
      i.visit_children(t);
    }
  }

 protected:
  vector<PyObjectPtr> data;
};

The built-in print function does not process strings right now for tabs, newlines, and other escape sequences like the other print functions do. This needs to be corrected. Probably should put the process string function in the util module.