Git Product home page Git Product logo

personal---portfolio's Introduction

Hi there ๐Ÿ‘‹ I am Catherine ๐Ÿ˜ƒ

  • ๐Ÿ’ป I am a certified software developer.
  • ๐Ÿ”ญ Iโ€™m currently open to work.
  • ๐Ÿ’ฌ Ask me about anything. Happy to help:smiley:
  • ๐Ÿ˜„ Fun-fact: I am quite chatty ๐Ÿ˜Š

๐Ÿค Contact me

๐Ÿ‘ค Linkedin

๐Ÿ‘ค Twitter

โš–๏ธ Cathy's Stats

Cathy's GitHub stats

Top Langs

personal---portfolio's People

Contributors

jord4n-ac avatar kemigabocatherine avatar tadessedev avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar

personal---portfolio's Issues

Peer review

Retky

  • The code is well organized and clear. ๐Ÿ‘
  • I think there is missing a design between the mobile version (min: 480px) and desktop version (992px) because when resizing the content display without style.

Tadesse

  • The mobile and desktop version is perfect. I love how you fit the styles. ๐Ÿ‘
  • Design a responsive page for screen size between 480px to 992px. the style breaks on those screens. and I think that got something to do with the max-width property.
  • It would be better to have one images folder inside the project and organize different types of images only within that folder.
  • it would be good to have a separate ID for each section. since we won't have a repeated section.

Chidiebere

Peer-Review-Session-2022-02-25

Good points ๐Ÿ‘

  • Good HTML semantics ๐Ÿ’ช.
  • HTML code looks clean.
  • Site is very responsive.
  • Sections were clearly defined.
  • CSS code also looks very clean and readable for humans ๐Ÿค“.
  • Nice use of comments in your HTML code.

To take note ๐Ÿ“

  • There is some indentation that could be fixed so it looks cleaner. (line 183).
  • Suggest that use more descriptive class names. Eg. The cards could use a class of "cards". ๐Ÿ“
  • Line 273 hard coded whitespace could be styled with padding or margin.
  • Suggest that the break-point for the media query for mobile should not be 992px rather 600px or less.
  • Could be more descriptive on the README.md file by explaining how to clone the repo, as well as mentioning the handlers.
  • Try not to leave commented code when presenting.
  • In the cards suggest not using buttons for the tech tags.
  • Should have a .gitignore file.
  • Your title could be more descriptive so it has more meaning.
  • It could help you get more organized by having the image assets in one folder rather than having many folders. ๐Ÿ“‚
  • Alts in images could be more descriptive for better accessibility.
  • Could help review git flow

No issues

Code was good and well organized @oshanedesign

The code is clean and the portfolio looks great @AbrahaKahsay

The code is easy to understand, well organized, project meets the requirement.. However I suggest using classes in one style in order to not repeat code and make it shorter.. @Jord4N-AC

Bugs:Hide and seek

In this issue;

-We found a bug in the javascript of the popup window code;

  • There was a point where the code was referenced before it was loaded and this prevented the referenced code from displaying the required content when run.

  • This was fixed by placing the referenced code before the one that is referring to it.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.