keijiro / kino Goto Github PK

Screen effects cause some DLSS issues with the screen being cropped when using these effects.
You can reproduce this by adding the Nvidia DLSS package into your project, apply 'maximum quality' or 'maximum performance' settings on the DLSS and watch the screen crop.

Hey!

It would be awesome if you implemented blur effect (which support transparent objects)!

best regards;
Pimpace

I have tried to install Kino from the Package Manager in order to get work with HDRP, but I recieve some errors.

According to you readme.
The package could not be found here
"jp.keijiro.kino.post-processing": "https://github.com/keijiro/jp.kino.post-processing.git#upm"

right one is
"jp.keijiro.kino.post-processing": "https://github.com/keijiro/kino.git#upm",

I've been messing around with his awesome package for a while and found out a major limitation to this, since this is using the unity default Gradient tool it is limited to only have 8 Keys in a Gradient. For example if you're trying to do a toon look with the Recolor effects Fill and have the gradient to have a mode of Fixed you have to be very picky about which keys you have to use, thus preventing you from mapping out all the luminosities you need.

If it's possible, could splitting up the gradient into two separate ones be done?

Other than these little issues, I'd like to thank you for sharing this graphics toolset with us, it's been awesome to use so far, great job!

As the title indicates, would the glitch effect be exported to Unity 2019.3f and above, the old one doesnt work in new version, I believe to due to Unity's update to cameras. And some of us dont really use HDRP yet--

this is a continue of a closed issue: #14

hey Keijiro!

No, not depth-of-field. A full screen blur effect as a post-process method. Or what would be better, the ultimate goal would be when you can put a shader on a plane or on a UI element which can blur every object behind.
I found this project https://github.com/sebastianhein/urp_kawase_blur with URP, but the problem is with this, alpha-pixels/transparent object wont show with this method.

That's why I asked you that it could possible to implement such a blur effect into your Kino project. I'm searching a good blur effect for a year from now and I found none. :( I know that it's differ in HDRP and URP, but I couldn't see any solution neither of them.
Maybe you can explain that it's even possible? I mean show transparent object behind blur effect.

This is the effect I can achieve so far. As you can see, transparent object cannot see behind this shader. There is a ScriptableRenderFeature script in this little project but I cannot figure out how can it work to achieve my goal.
ShaderTest3_2.zip

If you have spare time, can you investigate this sample project please?
Thanks for your help!

Pimpace

ui.: I'm using the latest Unity 2019.4.2f1 LTS version

Originally posted by @pimpace in #14 (comment)

Shader error, failed to open source file: 'PostProcessing/Shaders/StdLib.hlsl' at line 6 (on d3d11)

Every shader are give this error.

Streak gives:
RenderingCommandBuffer: invalid pass index 1 in DrawMesh
RenderingCommandBuffer: invalid pass index 2 in DrawMesh
RenderingCommandBuffer: invalid pass index 3 in DrawMesh

Hello, i'm trying to access to the glitch parameters via code with the volume component, in order to control them with midi input. But i have an error : "The name 'glitch' does not exist in the current context". I don't understand which name i have to use ? I hope my question is clear.

Thank you.

Hey Keijiro!

I wanted to know if there's a way to limit the range of where the isoline starts/finish drawing, I found that the range is given by the camera near/far plane, and tried to modify the ComputeViewSpacePosition in DepthUtils.hlsl but with no success on trying to remap the z buffer.
Was trying to get the isoline grow away from the camera based on some value. Would be great if this feature existed. Thanks a lot! Awesome work as always.

Any Unlit/... shaders give overbright for Streak. Test in 2018.3.0f2
More info in screenshots
https://prnt.sc/mbj7dq - in editor (work fine)
https://prnt.sc/mbj6vs - in game (have glitch)

p.s.
UI image with full black color too impact Streak fx, if canvas render mode - World Space

:(

After downloading the project and running on Unity 2018.2.0f2, the project produces a tonne of errors.

Pretty please :) I'm especially interested in the Glitch effect.

Thank you in advance!

I tried all effects include fill color in recolor, only edge detection doesn't work.