keep-starknet-strange / blobstream-starknet Goto Github PK

Celestia is moving towards a ZK solution for Blobstream due to the cost-prohibitive nature of signature verification on L1.

We would like to know if this remains cost prohibitive on L2. A simple benchmark of gas usage and estimated cost to run the Blobstream Contracts data root submission.

This benchmark of signature verification should be run and displayed against the cost to verify the succinct snark proof.

References

• https://github.com/celestiaorg/blobstream-contracts/blob/ddd2b50ad68af541c27f3dffbe4fdfc4f843bb8c/src/Blobstream.sol#L299

• https://github.com/celestiaorg/blobstream-contracts/blob/3e631e09f391b6654ae6a8b54374ef9a10fd1a93/src/test/BlobstreamBenchmark.t.sol#L58

Implement DAVerifierTest for the Cairo verifier module:

• https://github.com/celestiaorg/blobstream-contracts/blob/master/src/lib/verifier/test/DAVerifier.t.sol

Implement RollupInclusionProofTest for the Cairo verifier module:

• https://github.com/celestiaorg/blobstream-contracts/blob/master/src/lib/verifier/test/RollupInclusionProofs.t.sol

Update the main contract to BlobstreamX:

• keep any components we currently have
• maintain any functionality beyond stubs that we currently have

References

https://github.com/succinctlabs/blobstreamx/blob/main/contracts/src/BlobstreamX.sol

Implement the Blobstream events in the contract and test their emission:

• DataRootTupleRootEvent
• ValidatorSetUpdatedEvent

These can include stubs or full implementation of calling contract code.

References

https://github.com/celestiaorg/blobstream-contracts/blob/e2b8e53ea6f42a3bbbf2e88c41f038b18adf3c86/src/Blobstream.sol#L66

• add header range feat

NOTE -> ISuccinctGateway can be commented or stubbed for the time being (work done in #73 )

References

HeaderRangeRequested
requestHeaderRange

https://github.com/succinctlabs/blobstreamx/blob/364d3dc8c8dc9fd44b6f9f049cfb18479e56cec4/contracts/src/interfaces/IBlobstreamX.sol#L26

https://github.com/succinctlabs/blobstreamx/blob/364d3dc8c8dc9fd44b6f9f049cfb18479e56cec4/contracts/src/BlobstreamX.sol#L100

build out tree for issue creation

References

https://github.com/celestiaorg/blobstream-contracts/tree/master/src/lib/tree

Implement and test the Binary Merkle Tree from the Celestia Blobstream contracts.

References

Verify if there is anything reusable from the alexandria merkle tree implementation

Ensure the following tests are implemented and pass:
https://github.com/celestiaorg/blobstream-contracts/blob/master/src/lib/tree/binary/test/BinaryMerkleTree.t.sol

scaffold project and init unit testing

References

https://github.com/celestiaorg/blobstream-contracts/tree/master/src

keep-starknet-strange/piltover#8

Integrate a script that benchmarks the average cost for Starknet to submit blob data to Ethereum L1 for comparison.

Should display a nice readout of the data.

• Total Blob Size
• Blob Fee
• Blob Gas Used
• Gas if ETH calldata (blobscan calls it Blob As Calldata Gas)
• Gas if Celestia blob was used

Refs

• https://blobscan.com/blob/0x01394306d3a5e6456771c2a4689e98269d220636723a877e44f19e11f6e57e6d

Implement SuccinctGateway

References

https://github.com/succinctlabs/succinctx/blob/b272dbbd19af831a313f78b61d6571b26230e048/contracts/src/SuccinctGateway.sol

keep-starknet-strange/piltover#11

keep-starknet-strange/piltover#5

keep-starknet-strange/piltover#3

rename tag mapping

Add the components necessary to make the Blobstream contract upgradable via a proxy contract:

• please ensure a test via snfoundry and the devnet

References

https://github.com/OpenZeppelin/cairo-contracts/blob/main/src/upgrades/upgradeable.cairo

Continuation #42

Next.js application in the project root called blobby that implements the application logic for the Figma designs bootstrapped here:

#59 (comment)

refactor proj structure

Implement SuccinctFeeVault from Succinct X contracts

Can make Ownable + Upgradable instead of TimelockedUpgradeable

References

• https://github.com/succinctlabs/succinctx/blob/b272dbbd19af831a313f78b61d6571b26230e048/contracts/src/payments/SuccinctFeeVault.sol

Overview -> RW Celestia

test the github workflow

References

• github

keep-starknet-strange/piltover#10

Buildout book docs w/ diagrams

bump scarb version to 2.5.0 and handle any breaking changes

Once Herodotus Verifier implements a fact registry implement the logic for verifying the Proving Fact sent in updateState and correlating logic.

References

https://github.com/starkware-libs/cairo-lang/blob/ab6d079f0265f903630aac9287e93d9e7cfb6fcf/src/starkware/starknet/solidity/Starknet.sol#L303

In the blobby demo, read the base64 svg encoding given in step 6, then decode and display the SVG like in step 1.

Example base64 SVG encoding : data:image/svg+xml;base64,CiAgICAgIDxzdmcgeG1sbnM9Imh0dHA6Ly93d3cudzMub3JnLzIwMDAvc3ZnIiB2aWV3Qm94PSIwIDAgMTAwIDEwMCI+CiAgICAgICAgPGNpcmNsZSBjeD0iNTAiIGN5PSI1MCIgcj0iNDAiIGZpbGw9IiNhZDExZjciIC8+CiAgICAgICAgPHRleHQgeD0iNTAiIHk9IjUwIiBmb250LXNpemU9IjEyIiBmb250LWZhbWlseT0ic2Fucy1zZXJpZiIgdGV4dC1hbmNob3I9Im1pZGRsZSIgZHk9Ii4zZW0iIGZpbGw9IndoaXRlIj5GbG9yaWFuPC90ZXh0PgogICAgICA8L3N2Zz4KICAgIA==

( Decode the CiAgICA... part using base64 )

References

Continuation of #42

Blobby: https://github.com/keep-starknet-strange/blobstream-starknet/tree/main/blobby

add link to contrib

keep-starknet-strange/piltover#6

Reentrancy Guard

Initialize the contract bindings similar to the original contracts Go bindings.

Tasks:

• evaluate what language to write the bindings in Rust || Go
• communicated it in this ticket and on TG
• implement or start the implementation of the bindings

References

• https://github.com/celestiaorg/blobstream-contracts/blob/master/wrappers/Blobstream.sol/wrapper.go

Develop the Namespace Merkle Tree Hasher such that it passes the Celestia tests.

References

Verify if we need a full implementation of abi.encodePacked or not (some util funcs here:
https://github.com/keep-starknet-strange/blobstream-starknet/blob/main/src/utils.cairo

(coordinate with #23)

Blobstream(sol) https://github.com/celestiaorg/blobstream-contracts/blob/master/src/lib/tree/namespace/test/TreeHasher.t.sol

Similar UI demo of interacting with the blobstream contracts on Starknet as was developed here

References

https://www.based64.xyz

In the blobby demo, dynamically create an SVG from the inputted text and display in Step 1. Something like this :

<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 100 100">
     <circle cx="50" cy="50" r="40" fill="#F37567" />
     <text x="50" y="50" font-size="12" font-family="sans-serif" text-anchor="middle" dy=".3em" fill="white">{svg}</text>
</svg>

( With better sizing and placement, similar to what exists now )

Also, encode the generated SVG in base64 and replace the existing CiAgIC... bit here with the encoded value.

References

Continuation of #42

Blobby: https://github.com/keep-starknet-strange/blobstream-starknet/tree/main/blobby

Create integration tests (scripts) for the Blobstream contract(s) by doing the following :

• Launch a Katana node
• Declare & Deploy the BlobstreamX contract ( & dependencies such as the gateway ) to the Katana node
• Make calls to public functions on BlobstreamX contract & check state updates are correct

Possibly use mock implementations where needed.

References

https://github.com/keep-starknet-strange/blobstream-starknet/blob/main/src/lib.cairo

Crossover payment for Beerus work

Implement and create tests for the IDAOracle.verifyAttestation for BlobstreamX contract.

References

Implement the frozen functionality from Succinct's BlobstreamX contract.

References

https://github.com/succinctlabs/blobstreamx/blob/a2ca7f434b013eaa3b7bd39dd0a2a405f99eb056/contracts/src/BlobstreamX.sol#L124
https://github.com/succinctlabs/blobstreamx/blob/a2ca7f434b013eaa3b7bd39dd0a2a405f99eb056/contracts/src/BlobstreamX.sol#L72 ( change to get / set pair )

Create high fidelity mockups similar to based64.xyz using Figma.

Responsive layout based on Tailwind recommandations (5 breakpoints).

Implement and test the Namespace Merkle Tree from the Celestia Blobstream contracts.

References
Verify if there is anything reusable from the alexandria merkle tree implementation

Ensure the following tests are implemented and pass:
https://github.com/celestiaorg/blobstream-contracts/blob/master/src/lib/tree/namespace/test/NamespaceMerkleTree.t.sol

keep-starknet-strange/piltover#9

Build out a minimal core contract for an L3 to utilize for state update.

Will be used for testing the query of the DA Oracle from the blobstream contracts, will be necessary for L3 integration.

References

messaging cairo contract - https://github.com/dojoengine/dojo/blob/main/crates/katana/core/contracts/messaging/cairo/src/appchain_messaging.cairo

solidity core contract - https://github.com/starkware-libs/cairo-lang/blob/master/src/starkware/starknet/solidity/Starknet.sol

keep-starknet-strange/piltover#4

Develop the Binary Merkle Tree Hasher such that it passes the Celestia tests:
https://github.com/keep-starknet-strange/blobstream-starknet/blob/main/src/tree/binary/tests/test_hasher.cairo

References

Verify if we need a full implementation of abi.encodePacked or not (some util funcs here:
https://github.com/keep-starknet-strange/blobstream-starknet/blob/main/src/utils.cairo

Blobstream(sol) https://github.com/celestiaorg/blobstream-contracts/blob/master/src/lib/tree/binary/test/TreeHasher.t.sol

Implement the Blobstream errors in the contract and tests:

• MalformedCurrentValidatorSet
• InvalidSignature
• InsufficientVotingPower
• InvalidValidatorSetNonce
• SuppliedValidatorSetInvalid
• InvalidDataRootTupleRootNonce

These can include stubs or full implementation of calling contract code.

References

https://github.com/celestiaorg/blobstream-contracts/blob/e2b8e53ea6f42a3bbbf2e88c41f038b18adf3c86/src/Blobstream.sol#L80

PENDING #66

Do we need to have a function to emulate:

• abi.encode
• abi.encodePacked
• abi.encodeWithSelector

Open Questions:

• if we do need them should they be added to alexandria and imported?

Finish general functions implementation:

• tests
• commitHeaderRange
• requestNextHeader
• commitNextHeader
• getHeaderHash

NOTE -> ISuccinctGateway can be commented or stubbed for the time being (work done in #73 )
NOTE -> requestHeaderRange is being handled by #68

Refs

• https://github.com/succinctlabs/blobstreamx/blob/364d3dc8c8dc9fd44b6f9f049cfb18479e56cec4/contracts/src/BlobstreamX.sol#L81

For type Namespace, impl:

• NamespacePartialOrd
• NamespacePartialEq

Ensure type param <Namespace>.id type change to bytes31 is safe, add test to prove.

References

https://github.com/celestiaorg/blobstream-contracts/blob/master/src/lib/tree/Types.sol

Implement FunctionRegistry from Succinct X contracts

References

• https://github.com/succinctlabs/succinctx/blob/b272dbbd19af831a313f78b61d6571b26230e048/contracts/src/FunctionRegistry.sol

Remove Succinct contracts and call the external contracts:

• https://github.com/keep-starknet-strange/succinct-starknet