Git Product home page Git Product logo

Comments (2)

kcleal avatar kcleal commented on May 31, 2024

Hi @johannesgeibel,
I think you are probably correct, the error looks like it is caused by of those short reference contigs. I have modified the function so it skips the re-mapping step for short reference contigs < 1kb::

        if ref_genome.get_reference_length(e.chrA) < 1000 or ref_genome.get_reference_length(e.chrB) < 1000:
            ....
            continue

Is this a satisfactory fix for you? I guess the remapping could also be tried for short reference contigs also, but its unclear how robust it would be for very short reference contigs anyway. I have uploaded the current fix, but you will have to build from source whilst I get the patch uploaded to pypi.

from dysgu.

johannesgeibel avatar johannesgeibel commented on May 31, 2024

Hi @kcleal,
thanks. The fix seems to solve the issue. Excluding the very small contigs should not cause any larger trouble, as they are anyway disregarded in most cases. It's just common practice to keep them in the mapping process to reduce mismappings.

from dysgu.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.