Hi.

A friend https://www.facebook.com/groups/379533023004717/user/100000544281866/ or https://github.com/cefasheli offered some of his work, but it's webm.

• Add the pack in the zip

Thank you for the great module.
turnmaker.zip

Describe the bug
When creating an encounter, the turn marker is added to the first Actor in the encounter list, even if the Encounter has not been started, and initiative has not yet been rolled.

This makes it difficult to "pre-set" encounters, as the players may be able to see the turn marker through walls.

Environment Details
Foundry VTT Version: 0.6.4
Turn Marker Version: 2.6.9

To Reproduce
1: Add some Actors to a new encounter
2: The turn marker appears on the first actor in the encounter list

Expected behavior
Turn marker should not appear until the GM clicks "Begin Encounter"

The new features for filtering announcements have english only language files.

I'm not qualified to do the translation for the other languages, so this is a issue for the rest of the languages. If anyone's willing to pick this up, I'd be very grateful.

It'd be nice to see markers rotating in the settings based on how the user has configured the animation setting.

Describe the bug
Players were left seeing ghost icons for movement start location. As the GM I code not see this, I had to have them send a snap. It appears that player view was not policing the graphic after turn change....
https://media.discordapp.net/attachments/729428633885737031/734481323288297482/Capture.JPG

Environment Details
Foundry VTT Version: Example 0.6.5
Turn Marker Version: Example 2.6.9

To Reproduce
Not sure, just normal play.

Expected behavior
A clear and concise description of what you expected to happen.
Start icons icons should clean up on next player/mob turn.

Screenshots
If applicable, add screenshots to help explain your problem.

Additional context
Add any other context about the problem here.

jaltepeter/TurnMarker#13

IF ANYONE HAS REPRODUCTION STEPS PLEASE COMMENT!

Possible conflicts if I don't resolve this. Settings files especially will need to be updated, so there won't possibly be two of the same module in one installation.

Turn Marker messages currently lack any internal information for what they're for.

I'd like something as follows
<div class='turn-marker'> to wrap all the content
Same div should have something like data-actor-id="actorID" just because.

<p>PLAYER NAME</p> should include class='user' or similar.

and the <em>Turn Marker</em>... I don't know removed or add class='note' or something?

This would allow at minimum for example custom CSS to be used to alter the appearance of the message instead of current state of it being indistinguishable from any other chat message.

I'm getting this error when using turn marker during combat.
It triggers every time the turn is passed to a new actor.

Would be nice if TurnMarker start supporting CUB Hidden Name funcionality. It works great with multiple modules, sadly, TurnMarker's round announcement displays token name plain in sight. CUB hides name with "Unknow Creature" or any other string user defines in CUB settings.

I'm using Foundry 0.8.6 with Pathfinder 2E (2.0.3) and Turn Marker 2.8.0

If the scene's token vision is turn ON, then the players do not see the turn marker tile. If I disable the token vision setting, the turn marker tile appears.

#1 When I end combat, the "on deck" turn marker remains and then cannot be deleted, giving a weird error messages. Two screenshots depicting Issue #1 and Issue #2.

#2 I have some kind of weird dots rotating around instead of the rotating turn marker. Not sure why that is. Another module, perhaps?

placeTurnMarker returns only the marker id. The code above sets markerId and animator to undefined. Therefore pause/unpause doesn't stop/start the spinning animation.

I also noticed that !game.paused && is missing here:

EDIT: And the pauseGame hook doesn't need to be async.

In your README.mD, is the compatibility section talking about old versions (https://github.com/kckaiwei/TurnMarker-alt#compatibility), is it correct or is the text just not updated?

I found and locally fixed a trivial issue that prevents chat message from appearing.
In the following code at the bottom of chatter.js, I replaced combatant._actor with combatant.actor:

    static placeImage(combatant) {
        if (Settings.getIncludeAnnounceImage()) {
            let img = combatant.img;
            if (combatant.actor.data.img) {
                img = combatant.actor.data.img;
            }
            return `<div style="flex:3;padding-right:4px"><img src="${img}" style="border: none;" /></div>`;
            // return `<div style="flex:3;"><video><source="${combatant.img}"></video></div>`;
        } else return '';
    }

There is another issue that already existed in utils.js in , when deleting the tiles, which I've patched locally as well. This code, which is invoked from ready, assumes that there is a scene on the canvas. A guard clause for the existence of canvas.scene before using it to call getEmbeddedCollection(...) will prevent it from spewing an error in the console.log on startup.

I have no idea what other issues exist. This module looks like it is capable of doing a lot more than what little I use it for, so as I get more into it, I'll see what I find.

Hello AdagioT,

thank you for your amazing module. I found a small glitch: In SWADE, initiative is determined by drawing poker cards. When the end of the combat round comes along and the tracker draws new cards, I receive two turn announcements in chat: One for the first actor in the past combat round and immediately after that the correct turn announcement of the first actor of the current turn.

Is this something you can help with?`

Best regards,
Razortide

Currently on deck markers will show for any marker. A new setting needs to be added to decide who to show on deck for.

Like Turn announcements:

• Players only
• All
• NPCs only

utils.js:getNextTurn should pull from settings similar to this: Settings.shouldAnnounceTurns()

You can use combat.combatant.actor.hasPlayerOwner to check if it's a player token, or npc token, as you iterate to the next token in the stack. If for some reason the next to go is the same as the current token, it's probably best to still have the marker show up. The case where that happens is likely a single player game, where I would anticipate the DM would use show on deck for all instead of player only, since it's only a single player.

Clicking through the initiative rapidly messes up the dimension of the marker sometimes. Might've been introduced in the 0.8.6 compatibility update.

Foundry 0.8.6
Turnmarker 2.8.0

To reproduce: cycle through the initiative order quickly.

Whenever combat begins, a new actor is added to the combat tracker, or the turn changes in combat, this error is generated:

Error: The key xXAPcjxrashacwIO does not exist in the EmbeddedCollection Collection

Additionally, the turn marker does not move to the current actor's turn until the actor's token is moved. Furthermore, the start marker only appears at the first location of the first actor in the first combat in a scene - it then never changes, moves, or disappears, even when that combat is ended and a new one begins.

I'm happy to share the list of other modules I have enabled if it helps identify the issue. Let me know what you need and I'll get the data for you.

To recreate:

• Enable Turn Marker mod
• Enable Start Marker (I'm using bluesky.png asset)
• Begin combat, move tokens for each of their turns
• End combat (at this point, the start markers will be gone)
• Exit World/ Log Out
• Re-enter World
• Start Markers will reappear for every turn for every actor, showing up as "Tiles" which can then be deleted. They are visible and cause some lag.

It seems that turning off visibility will hide the marker properly, but enabling visibility right after seems to not show the marker.

The corresponding hook is updateToken, it's likely due to a visibility calculation error somewhere.

Note in the image attached, the token is now visible, but the marker isn't (this is GM view)

I really like the simplicity of this module and the fact that it has a simple purpose: to help manage who is playing, nothing else.

In order to make it even more awesome, I would like to suggest some addons.

Sound
I think it will be very useful if it would be possible to enable/disable "sounds" for different events in combat. The module could have already some defaults sounds set but it would be nice if it would be customizable (so that every group could choose their own sounds). Of course, all these settings should be configured on GM side (and maybe some on the player side too?).

I think the following sounds would be relevant:

• Combat Starts - this one would play to everyone but only when combat starts and would replace the "round start" for the first round
• Round start - this one would play to everyone when a new round of combat starts. IF combat start is not enabled, then it would play when 1st round starts
• You are next - this one would only play to the owner of the actor that is next in the initiative.
• Your turn - this would only play to owners of the actor which can play his turn now
• Combat End - this would play to everyone once the combat ends

Overlay Notification
I think it would be helpful to get a notification to highlight what is happening in the combat. Of course, all these settings should be configured on GM side (and maybe some on the player side too?).

The idea for these notifications would be to be shown at the centre of the canvas to catch the player's attention and alert him. could be a notification that must be manually closed by the user OR it could also close automatically after X sec if the user doesn't close it.

I think the following notifications would be relevant:

• You are next - this one would only show for the owner of the actor that is next in the initiative.
• Your turn - this would only show to the owners of the actor which can play his turn now

There are a couple of further restrictions and customization we could suggest regarding what to show to DM and what to now sow to DM since the DM has to manage multiple monsters and may get annoying to ear sounds and notification for every single monster but, that would be also sorted with a config to enable disable certain sounds/notification for the GM controlled actors.

I think these would improve this module a lot and would make it perfect and contained (so that we don't need to install multiple different modules because, one adds notification,s the other sounds, the other chat msg, the other a token highlight, etc...

Hope it helps 👍

Pretty self explanatory. Everything works fine for DM. Players get sound notifications, but no turn marker animation is playing.

Hello,
First of all great module.
I was wondering if there was a way to disable the names of the enemies in chat when their turn comes up. I know I can turn this off completely for all actors, so nothing comes up in chat, but it would be great to keep it on, and for it just to say "unknown creature" instead of it's name. I have CUB hiding the names of creatures everywhere else but it doesn't work on with this module.

Thanks

Observed on Version 9 - Build 238

[Detected 2 packages: turnmarker, drag-ruler]
    at modules/turnmarker/scripts/turnmarker.js:96
    at Function._call (foundry.js:294)
    at Function.callAll (foundry.js:253)
    at ClientDatabaseBackend.callback (foundry.js:10216)
    at foundry.js:10186
    at Array.map (<anonymous>)
    at ClientDatabaseBackend._handleUpdateEmbeddedDocuments (foundry.js:10186)
    at ClientDatabaseBackend._updateEmbeddedDocuments (foundry.js:10068)
    at async Function.updateDocuments (common/abstract/document.mjs:373)
    at async DragRulerRuler.animateEntities (modules/drag-ruler/src/foundry_imports.js:89)
    at async DragRulerRuler.moveEntities (modules/drag-ruler/src/foundry_imports.js:40)

I opened a ticket with them too: manuelVo/foundryvtt-drag-ruler#136

version 0.7.9
I'm hosting on The Forge.

After returning to the game, the Turn Marker remains on the last highlighted token.

Steps:

1. End a combat.
2. Leave the game.
3. Return to game.

Observed:
Marker remains active.

Expected:
Marker to have been "closed" or "stopped".

Describe the bug
When using TurnMarker and FXMaster, moving to a new turn causes the weather effect to reload. On reload, weather effects vanish and re-coalesce (as though the scene were reloaded). The effect is quite jarring.

Environment Details
Foundry VTT Version: 0.6.6
Turn Marker Version: 2.6.9

To Reproduce
Steps to reproduce the behavior:
_1. Enable the Turn Marker and FXMaster modules
2. Load a scene and turn on a fog effect in FXMaster
3. Start a combat encounter and move to the next turn
4. On each new turn, the weather effect reloads

Expected behavior
The process by which the TurnMarker moves the marker token should be able to avoid triggering the weather effect reload for FXMaster.

Screenshots
Not applicable

Additional context
Not applicable

jaltepeter/TurnMarker#17

It happens rather often that the marker is aligned with the pc/npc incorrectly. Sometimes just a block while other times way of.
I think it happens more often when you have more creatures on the scene that is part of combat.

Not a big or frequent issue, but I ran a combat where a bunch of boars ran through the scene at the same time.

I had them in the turn tracker and deleted them as they ran out of the scene. But some of them left a turn-marker that i had to delete.

After taking over the repo, I realized since it's my "first" module, there's a lot about releasing to be figured out. I've pretty much all of it figured out, but should write some docs incase other maintainers want to assist, or if eventually someone ends up taking over this project from me.

Add a marker that shows when someone is next to move.

Note that having options for announce/display filters complicates this a bit more since we can't just throw it on whoever is next on the initiative order. It's likely we can just filter by isPlayerOwned and find the next player.

Since I'm not much of an artist, it will likely reuse available tokens already. And hence needs a second selection setting.

Would it be possible to implement compatibility with the Levels module by theripper93 (https://github.com/theripper93/Levels)?
Currently if a token is standing on an elevated level, the Turn Marker does not show up underneath it.

updatePreview currently breaks out the turnmarker and deckmarker previews into two functions. They are both very similar, and I did a quick copy/paste to get the functionality working at first. It will be beneficial to make these two into a function that can just accept the differing arguments for cleanliness.

activateListeners is also the same code twice more or less, and can be split into helper functions as well to reduce code complexity.

I'm not sure if it's possible but is there a way you can make TurnMarker work with the Savage Worlds Game System? The issue is, at the start of every combat round new initiative rolls are made in savage worlds and TurnMarker seems to automatically select the first token that was listed in the previous round as opposed to the new rounds token order.

I really like the simplicity of this module and the fact that it has a simple purpose: to help manage who is playing, nothing else.

In order to make it even more awesome, I would like to suggest some addons.

Sound
I think it will be very useful if it would be possible to enable/disable "sounds" for different events in combat. The module could have already some defaults sounds set but it would be nice if it would be customizable (so that every group could choose their own sounds). Of course, all these settings should be configured on GM side (and maybe some on the player side too?).

I think the following sounds would be relevant:

• Combat Starts - this one would play to everyone but only when combat starts and would replace the "round start" for the first round
• Round start - this one would play to everyone when a new round of combat starts. IF combat start is not enabled, then it would play when 1st round starts
• You are next - this one would only play to the owner of the actor that is next in the initiative.
• Your turn - this would only play to owners of the actor which can play his turn now
• Combat End - this would play to everyone once the combat ends

Overlay Notification
I think it would be helpful to get a notification to highlight what is happening in the combat. Of course, all these settings should be configured on GM side (and maybe some on the player side too?).

The idea for these notifications would be to be shown at the centre of the canvas to catch the player's attention and alert him. could be a notification that must be manually closed by the user OR it could also close automatically after X sec if the user doesn't close it.

I think the following notifications would be relevant:

• You are next - this one would only show for the owner of the actor that is next in the initiative.
• Your turn - this would only show to the owners of the actor which can play his turn now

There are a couple of further restrictions and customization we could suggest regarding what to show to DM and what to now sow to DM since the DM has to manage multiple monsters and may get annoying to ear sounds and notification for every single monster but, that would be also sorted with a config to enable disable certain sounds/notification for the GM controlled actors.

I think these would improve this module a lot and would make it perfect and contained (so that we don't need to install multiple different modules because, one adds notification,s the other sounds, the other chat msg, the other a token highlight, etc...

Hope it helps 👍

I use the Pathfinder 1 system.

Steps to reproduce :

• Create a monster with any attack
• Put the monster on the scene
• Double-click on the monster's token to open its sheet
• Use one of its attacks
  OR
• Create a monster with any attack
• Put the monster on the scene
• Right click on the monster's token
• Use one of its attacks from its quickbar under the token

Do NOT add the monster to the encounter tracker.

=> On the console, this error is displayed :

Uncaught (in promise) TypeError: Cannot read property 'token' of undefined
    at turnmarker.js:56
    at Function._call (foundry.js:2496)
    at Function.call (foundry.js:2481)
    at foundry.js:29991
    at Array.reduce (<anonymous>)
    at Scene.updateEmbeddedEntity (foundry.js:29978)
    at Token.update (foundry.js:11475)
    at ActorPF.updateEmbeddedEntity (foundry.js:31318)
    at ActorPF.PatchCore.ActorTokenHelpers.updateEmbeddedEntity (patch-core.js:199)
    at ItemPF.update (foundry.js:32513)

This error will also break the attack's calculation if you use the dialogue that appears when you use the attack to change some values.

Expected behaviour : I should be able to use a monster's attack even if it is not in the encounter tracker without breaking my roll's calculation

Hi!

Your mod is a must have. Is/will there be support for Foundry v9?

/Cheers

Splash screen is part of the release process, and needs to be updated with every release.

settings.js and settingsForm.js use a lot of getter/setters for settings that could probably be shared between Turnmarker and Deckmarker.

I've already refactored a few when adding the original feature, but there are a few more to do, and this is a good first issue for anyone who wants to get into Foundry modding.

Good examples include Settings.setImage(), Settings.setIsEnabled().

version 0.7.9
SWADE version 0.16.2

When the turn cycles (either by selecting "next" on last combatant or selecting "next turn"), the marker remains on the last combatant. It doesn't switch to the new order. I believe this is due to how SWADE does initiative (there's a pause while it draws cards and then sets order...).

Steps:

1. Start combat --> marker highlights first combatant
2. Cycle through all combatants.
3. Select "next" combatant or "next turn" arrow.
4. Observe: New initiative cards are drawn, then oder is set based on draw.

Observed:
Marker remains on last combatant.

Expected:
Marker to switch to combatant at top of the list.

Start marker is still showing visible even when the controlled token cannot see the unit starting.

Reproduced by controlling a PC (in a client browser), then switching turns to a NPC in GM browser, and a start marker will be seen.

TurnMarker doesn't work in Foundry 0.8.5.

I did spend a little time to see if I could quickly update it, but it looks like it might end up being a little complicated.

If you want it as a starting point, here's my initial work towards this:
https://github.com/illandril/TurnMarker-alt/tree/08x-test

This manages to fix a lot of the errors and deprecation warnings... unfortunately, the turn marker doesn't update at all so I either missed something or broke something along the way, and I don't have the time to continue this effort.

When logging in as a player, custom Turn Marker images are replaced by warning signs and I get the following errors in the Console:

Error: The requested texture icons/target-origin.svg could not be loaded: Invalid BaseTexture
    loadTexture http://localhost:30000/scripts/foundry.js:36234
foundry.js:36238:13

Error: The requested texture icons/target-current.svg could not be loaded: Invalid BaseTexture
    loadTexture http://localhost:30000/scripts/foundry.js:36234

They work fine as a GM.

This is happening in version 2.8.1

Following the most recent update of the dnd5e system my players get error messages when other players are added to combat trackers that they do not belong to. The error messages are as in the title. This seems to be a TurnMarker fault as the error appears only when TurnMarker is activated (even alone) and disappears when deactivated.

Kreals has been updating a version of Turn Marker here: https://github.com/Kreals/TurnMarker

It already has a bunch of fixes and feature enhancements in it. Perhaps it is worth merging the two.

When the turn marker is applied to rectangular tokens it scales into an awkward oval that wobbles as it rotates. The starting marker is also scaled oddly if it is enabled.

Versions

Foundry VTT: 0.7.9
Turn Marker: 2.7.3

To Recreate

1. Set the Width or Height for a token's image to be different values
2. Enable that marker's turn in combat

My Suggestion

It would be nice if the turn marker remained a circle no matter the dimensions of the token, with a diameter of either the shortest or longest edge of the token (maybe configurable in options, but probably just whichever looks nicest when tested).

#29 will introduce on deck markers. As of now, I've simply shifted the index, so on deck markers will use the same set, but off by one. It would be ideal if someone could make an on deck marker since I'm not much of an artist myself.

I believe the only requirements for these markers are that they're 1:1 ratio so they will fit the squares and resize well.

Full /src/ directory included in Released Zip, causing the module to appear as if it is multiple modules (one at the root of the zip, as is proper, an additional one inside the /src/ folder.

The On Deck marker only works sporadically. What info do you want to know to help troubleshoot? Thanks.