Git Product home page Git Product logo

georgia's People

Contributors

0xothik avatar jimmywan avatar kbuffington avatar marc2k3 avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

georgia's Issues

Track title font looks a little ugly compared to others

I installed the fonts on installation fine (I did this a few updates ago, but I don't think the fonts changed?) and while most of the fonts are pretty (as you can see in the rest of the image), this one just looks a little bit more jagged. It's on Windows 10.

image

Possible to show lyrics?

I wondered how I can show the lyrics of the song (.lrc file).
The .lrc-files get detected fine with the LyricShowPanel-Component, but they don't get displayed in the theme.
What can I do to get the lyrics to display?

Playlist - Too many tags, or size causes tags to lack rendering space

When using a larger font (neccessary for me to even see it), and actually even with a smaller font, sometimes a cd has enough tags to do the following:
image

I realize that in most cases having the vanilla font size probably doesn't have this issue; but I'm wondering what the best solution would be for people with this setup? Maybe to count the length of the compiled label string, and if it's above that allotted space estimate (I've seen this in the code in other places) or maybe even just a preference size max? then start trimming labels (e.g. only showing 3) until it fits or something?

The labels proceed | flac | n track | y time and finally on the right; aligned is the record label itself, so if there are too many rendered labels those 2 entities run out of horizontal space to draw on.

For reference, my display where it occurs is a 22" 1920x1080 display. Thanks again for making this awesome theme, and I'm willing to help come up with a fix if you want.

How to display full screen?

I guess this isn't really an 'issue' as such, but the instructions say that this is best used full screen...but as far as I can tell, there's no way to actually use it full-screen (ie, without title bar and over the task bar). Is there something in the instructions I'm missing, some component or context option I don't know about, or is 'full screen' best read as 'maximized'?

Image Pack Locations

This is awesome man! Any hints on how to get the label images working? What specific meta data does it use? Do the image packs go in sub directories within the images directory?

Some issues with the readme doc

Hi, thanks for this great theme. I was reading along the installation instruction and found some issues.

  • Links to individual image pack needs to be updated, right now they all return 404
  • The foo_script_panel dependency has been updated to v2.2.1.1 and old versions were removed from the release page. However after some digging I found historical versions in its wiki: https://github.com/marc2k3/foo_jscript_panel/wiki/Old-Versions so maybe you want to instead point to this one?

Thanks!

Issue when playing a song

Thanks for the amazing update !
I encounter this issue when I click on a song to play it :

JScript Panel v2.2.2.2 (Georgia by Mordred) JavaScript runtime error: Unable to get property 'setColors' of undefined or null reference File: C:\Users\Freed\AppData\Roaming\foobar2000\georgia\js\themes.js Line: 101, Col: 5

Hope it can help you improve it, and as always, thanks for your amazing work :D

Runtime error after install and config with JScript Panel v2.2.2.2

JScript Panel v2.2.2.2 (Georgia by Mordred)
JavaScript runtime error:
Unable to get property '0' of undefined or null reference
File: C:\Users\Splunk\AppData\Roaming\foobar2000\js\georgia-main.js
Line: 2968, Col: 2

Running Foobar 1.4.6, CUI v1.2.0b (gowngraded to 1.1.0 as well).
I also edited the georgia.txt to have full paths to the files.

I checked previous Issues and to use 2.1.7.1, but the link 404's.

I replied back to a comment on your r/foobar reddit thread :)

Some non-English characters render in a bolder font

I'm sure you aware of this one, but I wanted to make a report in case there's any sort of possible fix.

Sometimes, foreign characters render in a slightly bolder form. It happens, for example, with the ź in Łódź (but not the Ł, curiously), the ō in Kayō and the ą in benzyną. See below:

image

image

image

I'm guessing this issue is caused by the font not having these characters, but I don't know if there's some sort of fix, or extended version of the font to add, or any other solution?

Problem with hover over on menu items and UI buttons.

I have installed your Georgia theme after seeing it mentioned on Reddit and I really enjoy it.
However, I have one issue that I can't seem to fix and I have looked at all your faq locations and could not find the solution.
Whenever I hover over the menu tabs or the transport buttons or the option buttons, all the icons have a white background that I can't seem to get rid off.
help1

High CPU Usage

I noticed that the seekbar refreshed a lot in a second. It looks awesome but will cause high CPU usage( the 'on_paint' function will be executed every time....)

I believe the strategy used by thanhdat1710 in https://www.deviantart.com/thanhdat1710/art/Album-Library-Search-WSH-Script-396270784 is quite good that he separated the panel into two and repaint them respectively(say if only the inputbox area be refreshed, code lines of the album list (in on_paint function) would not be executed)

Track title looks ugly compared to others (volume 2)

Hi. I installed the updated theme and the result is as below:

image

You had indicated when you closed the issue that you'd implemented the change on the track title but if anything it looks uglier than before here. I can't make the same changes as before though because now the lines you mentioned don't correspond to the same code.

Report is partly because you said you'd implemented it officially yet this doesn't seem to be the case, and partly to ask how I can make the necessary changes to get it pretty again. For the time being I've continued using the old version of the theme :)

Volume control missing from 1.8 stable

After updating to the stable 1.8 stable release, I noticed that the volume control is now missing.
It was there in 1.1.8-beta2.

Capture

Jscript panel shows:
// @import "%fb2k_profile_path%georgia\js\volume.js"

The file is present inside the js folder.

Date+Year field in ID3 tags causing calcAgeDateString function to fail

Hello!

Absolutely loving Georgia and don't think I'll be able to go back to stock Foobar now.

However, I seem to be struggling with certain tracks.

Taking you through my investigation for a min...

Symptom:

I'll go to play a track and Georgia will crash (but the track continues to play and stock Foobar works fine) with this error.

JScript Panel v2.4.1.1 (Georgia by Mordred)
JavaScript runtime error:
'fail' is undefined
File: C:\Users\Michael\AppData\Roaming\foobar2000\georgia\js\helpers.js
Line: 237, Col: 4

Digging in a bit, it looks like it's having an issue with the calcAgeDateString(date) function.

Examples of tags against songs that work
image
image

Examples of tags on songs that don't
image
image

Looking at them side by side like this, it looks like it could be the Date (DDMM) field causing an issue? Possibly conflicting with the parameter as part of the calcAgeDateString function.

However, then using Cyndi Lauper's 1983 non-working classic to experiment with and understand workarounds:

Tag set that doesn't work
image

Removing just the Year field (so it looks like this) works
image

Removing just the Date field (so it looks like this) also works.
image

So something is getting very upset about the combination of Year and Date fields being present.

I have no issue with just removing the Date field from my files but would rather see if the root cause can be solved before going ahead and doing that.

Let me know if you need any more info from me :)

Thanks,
Michael

Changing the displayed tags

Hi,

Sorry if this has been asked before, but is it possible to change the displayed tags on the current playing song?

image

What I want is to change for example "Last Played" to the song's bitrate. Is this possible?

Crashing when cycling through art

If there is 10 or more image files and a cd.png is loaded, Georgia will crash while going from image no.9 to image no. 10.
This is the error message:
2020-09-26 (2)
(that means Javascript runtime error in Portuguese)

Screenshot(s), maybe?

It's not an issue in the truest sense of the word, but I think some screenshots would be nice, and may motivate some people to give the theme a try :)

Lyrics display bug

When the lyrics player shows the first line of a verse, it doesn't get marked yellow like all the other lines.

demonstration-georgia

Jscript panel crash when scrolling the playlist quickly on a 4K screen

Error: JScript Panel v2.1.4 (Georgia by Mordred)
JavaScript runtime error:
LogicError:
first_item_to_draw can't be null!

File: E:\Users\Artins\Desktop\foobar2000\georgia\js\CaTRoX_QWR\Common.js
Line: 262, Col: 9

I can replicate this crash every time, just grab the scroll bar and pull it down quickly.
Probably the play list needs to include a large enough number of albums, 50 albums should suffice.

Transport button icons display improperly

The icons display improperly like this:

image

Everything was just fine yesterday and I did nothing to my computer besides a system upgrade. (Windows 10 2004 -> Windows 10 20H2) What could be the cause of this problem?

Album Art Displaying in Low Resolution

For some reason the album art always displays in very low resolution. All of my albums are using album art that's at least 600x600, but the now playing display is much lower than that.

Installation errors due to JScript Panel v2.3.0+

JScript Panel v2.3.0.1 (Georgia by Mordred)
JavaScript runtime error:
Wrong number of arguments or invalid property assignment
File: C:\Users\Aerjay\Portable\foobar2000\georgia\js\CaTRoX_QWR\Panel_Playlist.js
Line: 2821, Col: 9

I got this error after I pasted the contents of Georgia.txt to the JScript Panel. It's probably due to the new version of JScript Panel (starting from v2.3.0). In particular there's the following change:

- CHG: plman.PlayingPlaylist is now a read-only property.

Also, if I play a track before pasting Georgia.txt at the panel, this shows up:

JScript Panel v2.3.0.1 (Georgia by Mordred)
JavaScript runtime error:
Object doesn't support property or method 'FileTest'
File: C:\Users\Aerjay\Portable\foobar2000\georgia\js\georgia-main.js
Line: 2857, Col: 3

this is probably due to this change in JScript Panel:

- CHG: utils.FileTest has been removed and replaced with the following 4 methods:
       utils.Chardet(filename)
       utils.GetFileSize(filename)
       utils.IsFile(filename)
       utils.IsFolder(folder)
       There is no replacement for "split" mode.

Using JScript Panel v2.2.2.4 instead of the latest one removes the errors.

Fonts

You're not doing anything wrong at all but I think one of the users in your thread on HA is having problems because of foo_ui_hacks. This lets you place a fonts folder inside your foobar folder when running portable mode and lets you use custom fonts without actually installing them.

The problem here is that utils.CheckFont cannot detect fonts loaded in this manner and will always return false but if you actually try and use the font with gdi.Font, there is no problem and everything works as expected. This "limitation" was reported and added to component docs some time ago..

https://github.com/marc2k3/foo_jscript_panel/issues/24

You might consider checking the return value of gdi.Font is null to really detect if the font is available or not. Incidentally, I noticed your code is inside a try/catch but it doesn't throw so it isn't necessary.

First running worked ok, then I closed it, added the image packs, run for 2nd time and...

JScript Panel v2.2.2.2 (Georgia by Mordred)
Error en tiempo de ejecución de JavaScript:
No se puede obtener la propiedad 'setColors' de referencia nula o sin definir
File: C:\Users\xxx\AppData\Roaming\foobar2000\georgia\js\themes.js
Line: 101, Col: 5

JavaScript runtime error:
Cannot get property 'setColors' of null or undefined reference
File: C:\Users\xxx\AppData\Roaming\foobar2000\georgia\js\themes.js
Line: 101, Col: 5

AFAIK, Paths are ok, script engine is chakra, ... I follow the installation instructions line by line
Thanks for this theme, it shows soo beatiful. Also Codec logos and band logos? I see these packs in your images repo screenshot, thanks!!!

JS Panel crashes on several interactions

I just installed this theme, but I'll get js scrashes, the JPanel turns red with a white "Error" showing.

This happens e.g. when I click on text (artist, title), with:

JScript Panel v2.4.1.1 (Georgia by Mordred)
JavaScript runtime error:
Number expected
File: %AppData%\Roaming\foobar2000\georgia\js\helpers.js
Line: 192, Col: 5

.. at other times, I get:

JScript Panel v2.4.1.1 (Georgia by Mordred)
JavaScript runtime error:
Object doesn't support this action
File: %AppData%\Roaming\foobar2000\georgia\js\georgia-main.js
Line: 41, Col: 2

Anything I possibly did wrong?

Library Tree Zoom and Scaling Issues

here is another bug I found on top of the ones involving scaling issues with the library tree. There other library or playlist manager thing constantly zooms in every single time I click full screen on foobar while still having the playlist manager selected and it will not zoom back out or scale back down. Here's is a picture, although it doesn't look like much because it zoomed in soo much towards the top left corner of that window, that it just looks like a black box now. https://imgur.com/gallery/PBp5gd7 https://imgur.com/gallery/WLIB9IZ edit another clearer example of the first issue https://imgur.com/a/C2vW9zU .

Also Clicking Library Settings - > Reset library zoom did not change anything.

Crash when creating a new playlist

Selecting playlists > Create New Playlist seems to cause a crash with an error:

Error: JScript Panel v2.1.7.1 (Georgia by Mordred)
JavaScript runtime error:
Invalid procedure call or argument
File: ........\foobar2000\georgia\js\CaTRoX_QWR\Control_Button.js
Line: 309, Col: 4
<source text only available at compile time>

Last.fm logo glitches on larger play counts

It falls off the side and onto the top of the album art and also increases in size.

See the below:

image

I can replicate this on any track that's sending the bar tally that far out. Windows 10, foobar2000 v1.3.4, large screen and the theme is full width.

No country flags or record logos appear

No matter what song I play, I can't get country flags or record label logos to appear. There's a very good chance I'm doing something wrong here as I'm new to foobar.

Library Tree: compatibility fixes for JSPv2.3.0+

Here is a version of library tree with compatibility fixes for JSPv2.3.0+. It also has a few other optimisations and fixes.

Library Tree 1.4.0.4 beta1.txt

You can do a diff (or document compare etc) between 1.4.0.2 & 1.4.0.4 beta1 to easily identify the changes.

Main changes are:
CHG: View by folder structure now uses faster GetLibraryRelativePaths(), instead of defunct GetLibraryRelativePath. It effects both library initialisation and the library update methods. There are also some bug fixes in there and reworking of the library update code that effect all views. Likely you can just copy & paste the new functions.
CHG: Removed the 500,000 limit in sending tracks to playlist (push.apply to concat in various places).
CHG: Some optimisation of sorting (lines 431 & 491).
FIX: Tree lines. Now should always join properly at junctions at all dpi setttings (search for l_w, l_wc, l_wf); but I think you already made some high dpi adjustments.
CHG: Themes: switched to GetColourSchemeJSON, due to removal of GetColourScheme (but I think you removed that for Georgia).
CHG: Added workaround for changed behaviour of fb.GetFocusItem() in JSPv2.2.2.1+ (lines 223-225; 1722-1724; effects blur & cover background image drawing: but I think you removed that for Georgia).
CHG: Other minor JSP compatibility changes.

Line numbers are as in 1.4.04 beta1

HTH

Cover art potential bug in playlist view

I am not sure if this is strictly related to Georgia of if it's caused by other factors, I noticed that there is a line going across the last cover and song name in the playlist.
Resizing the window allows me to move this line up and down, this is on a 4K screen.
Line when placed in the last slot:
Capture2
No line on the cover when scrolling the same album 1 position up from the last position, the line moves to the track number 2 instead:
Capture3

It might be hard to see, here is a zoomed version:
Capture3

Oi!

Since your theme contains the Catrox playlist... I'm going to comment here. I noticed your post in the Catrox thread on HA saying JScript Panel couldn't write tags to files - it can!!

Even WSH panel mod has basic functionality but I completely rewrote it in v1.3 and it's documented here.

https://github.com/marc2k3/foo_jscript_panel/wiki/Breaking-Changes#v130

The handle list section in the docs also contains a link to this info.

Suggestion for Instructions

I'm super casual on this kind of thing (Not even coding, just installing)

So, the roadblock I ran into was on step 8. I didn't understand how to add the Jscript Pannel, specifically as I'm ultra new to Foobar.

Luckily your video helped me out there, through some reddit skimming, and happening to run across it on youtube.

It may seem super trivial, but a little bit of a more direct explanation on adding a Jscript Pannel more specifically targeted at someone who had just downloaded Fubar for the first time (Like myself) could prove helpful in progressing through the install process.

Simple suggestion would be View>Layout>New Scratchbox, ect.. added to the instruction flow.

Awesome configuration, and beautiful design. Keep up the amazing work!

Jscript Panel error when attempting install

Hi there

I LOVE the look of this theme from the imgur pictures I saw.

I've followed the steps as per your instructions but when I copy & paste the text from the Georgia.txt I get the following error message:-Panel v2.2.0-Beta 2 (Georgia by Mordred)
JavaScript runtime error:
Object doesn't support this property or method
File: C:\Users\Simon\AppData\Roaming\foobar2000\georgia\js\CaTRoX_QWR\Panel_Library.js
Line: 1056, Col: 1

Does Foobar have to be installed as portable mode for this to work properly, or will the standard mode work fine?

Please help, not sure where I've gone wrong :(

Cheers

Force display of front cover when switching albums

Currently, when switching tracks the artwork is displayed in alphabetical order. This means when you start up a new album the first thing you see is back.jpg. It would be much better to show the front cover (front.jpg, cover.jpg, folder.jpg, etc) first, and then continue cycling artwork in alphabetical order.

Error in JScript?

This style is single-handedly what made me go with foobar2000 for my music player, but I can't seem to get the JScript working. I placed everything in the correct folders, but when I try to paste in the code, I fet the following error.

Error: JScript Panel v2.1.7.1 (Georgia by Mordred)
JavaScript runtime error:
Invalid procedure call or argument
File: D:\Programs\foobar2000\georgia\js\CaTRoX_QWR\Panel_Playlist.js
Line: 2824, Col: 9
<source text only available at compile time>

I'm not sure what I'm doing wrong, and this code is definitely not my strong suit.

Crash on 4k/1080p monitor pair

I tried installing Georgia on my work computer today and it crashes on startup. I can make the crash stop by removing "auto" from the "detect 4k" field, but everything gets very small. If I reload after the crash, the theme will load. I'm using the latest version of everything and am attempting to run fb2k on my 1080p monitor (there is a 4k monitor on the system though).

Date with .CUE

Georgia theme is insane! It's my first time using and really love it.
i've one question, i'm using .cue + flac but for date i'm getting this: 0000

on .CUE:

REM DATE 1991 / 2009
2020-06-13_18-03-33
2020-06-13_18-02-55

Weird crash issue when filtering

I'm not sure why this happens, but whenever I try to filter for certain artists or albums, Georgia crashes.

It happens specifically with the album The Iron Soul of Nothing by Sunn 0))) Meets Nurse With Wound.

It happened a few more times, but I didn't note down what artists and albums.

I also ran into a crash when trying to show albums that are currently being added to the folders that foobar2000 is scanning. So if I'm using beets or something to add my tracks one by one, and I go to the artist that it's currently adding files to, it crashes. I had this problem specifically with The Dear Hunter's Color Spectrum album.

If you need the files that are causing the crash, I can PM them to you or something.

JScript error?

I can't see to make this work ):

Error: JScript Panel v2.3.0 (Georgia by Mordred)
JavaScript runtime error:
Invalid procedure call or argument
File: C:\Users\ggrit\AppData\Roaming\foobar2000\georgia\js\CaTRoX_QWR\Panel_Playlist.js
Line: 2821, Col: 9

Any ideas?

Error added album

hi,
I have an indication error for the date of the album selected for playback. And that's true for all albums!
SharedScreenshot

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.