kbirken / dbus-emf-model Goto Github PK

When reading a dbus model file we currently use franca's DBusConnector. The 
class brings a dependency to franca, which is not required when just reading a 
dbus introspection file. I propose to create a helper class in the 
dbus-emf-model which can read a dbus introspection file. This would remove the 
dependency to the franca files when just working with dbus.

The model class DBusBasicType contains a list of literals for all basic types 
supported by DBus. One of those is DBUS_TYPE_INT8, which should be replaced by 
DBUS_TYPE_BYTE. D-Bus and its type signatures do not support an "int8" type, 
but only a byte type ("y", which is an unsigned 8-bit integer). 

This is a non-compatible model API change.

Adding a doc attribute to a property, eg.
<property access="read" name="INFO_PHONE_HANDSET_MODE" 
type="u"><doc><line>enum: OnOffType</line><line>OnOffType[Type_ON, 
Type_OFF]</line></doc></property>

Result in following error:
org.eclipse.emf.ecore.resource.impl.ResourceSetImpl$1DiagnosticWrappedException:
 org.eclipse.emf.ecore.xmi.FeatureNotFoundException: Feature 'doc' not found. 

When integrating the dbus-emf-model in a custom eclipse project mwe2 get's 
automatically included. Please change the MANIFEST.MF of the model.emf.dbusxml 
to delcare only optional dependencies to mwe2. We can then create a filter for 
mwe2 plug-ins when creating our product.

The dbus-emf model maps the D-Bus data types 'g' and 'o' to DBUS_TYPE_STRING 
and 'h' to DBUS_TYPE_UINT32. When using the dbus-emf model in our code 
generator we are not able to serialize 'g', 'h' and 'o' types, because we lost 
the information during the transformation.
Therefore the dbus-emf model need to have also dedicated types for that.

GDBus support annotation tag also for ArgType elements, e.g. see 
http://sourcecodebrowser.com/glib2.0/2.25.5/gdbus-example-server_8c_source.html

Using dbus-emf-model for such an ArgType will fail by the following error:
org.eclipse.emf.ecore.resource.impl.ResourceSetImpl$1DiagnosticWrappedException:
 org.eclipse.emf.ecore.xmi.FeatureNotFoundException: Feature 'annotation' not 
found. 

In contrast the D-Bus specification states:
Method, interface, property, and signal elements may have "annotations", which 
are generic key/value pairs of metadata.

Anyhow, GDBus interfaces using the annotation tag on ArgType can't be used with 
dbus-emf-mode.