katsutedev / settings-repository Goto Github PK

Operating System

Windows 10

VSCode Version

1.70.2

Extension Version

1.0.0

Issue

When an extension is updated the old one isn't removed until the second pull, causing extra unnecessary commits.

first commit

    {
        "identifier": "streetsidesoftware.code-spell-checker",
        "version": "2.5.4",
        "enabled": true
    },
++  {
++      "identifier": "streetsidesoftware.code-spell-checker",
++      "version": "2.6.0",
++      "enabled": true
++  },

second commit

--  {
--      "identifier": "streetsidesoftware.code-spell-checker",
--      "version": "2.5.4",
--      "enabled": true
--  },
    {
        "identifier": "streetsidesoftware.code-spell-checker",
        "version": "2.6.0",
        "enabled": true
    },

How to replicate

1. Pull settings
2. Extension updates
3. Push settings
4. Pull settings
5. Push settings

Log

No response

Additional information

Seems to be caused by these lines:

When an extension is updated the old folder doesn't get removed until closed, two versions exist during a push, causing the duplicate until the next push.

Should be resolved by always using the latest version, if someone is using a set version this change should be fine, since the extension wouldn't get updated.

Operating System

MacOS Sonoma

VSCode Version

Version: 1.88.0-insider (Universal)

Extension Version

v1.0.8

Issue

After uninstalling an extension, in this case ShipitSmarter.sops-edit, when we trigger manual push to a remote repo, this payload gets pushed:

{
        "identifier": "ShipitSmarter.sops-edit",
        "version": "1.0.0",
        "enabled": false
}

and upon restart, said extension is reinstalled, and a manual push to remote repo will send this:

{
        "identifier": "ShipitSmarter.sops-edit",
        "version": "1.0.0",
        "enabled": true
}

However, this is not correct. The extension should not be disabled to begin with, it should be uninstalled and the whole stanza should be completely deleted from extensions.json. Instead, it is only marked as "enabled": false.

This causes a major problem: if an extension is uninstalled in vscode but in a git commit pushed by Settings Repository it is marked only as disabled, it will be actually reinstalled by Settings Repository next time vscode is launched. This will make it installed and active: "enabled": true. This process will always bring back uninstalled extensions, resulting in endless circle of manual extension removal and automatic reinstallation after vscode restart.

N.B.: I am running vscode-insiders, could be a factor here.

How to replicate

Install extension
Push to Settings Repository remote repo
Close vscode
Start vscode
See uninstalled extension be automatically installed again (because it is only marked as "enabled": false)
Extension is installed again
Uninstall, repeat the whole process and see it installed again.

Log

No response

Additional information

Version: 1.88.0-insider (Universal)
Commit: 8c2b09c0443b94d75a73819ed35610f7e09375ae
Date: 2024-02-28T18:55:25.510Z (4 hrs ago)
Electron: 28.2.2
ElectronBuildId: 26836304
Chromium: 120.0.6099.276
Node.js: 18.18.2
V8: 12.0.267.19-electron.0
OS: Darwin x64 23.3.0