Cannot get ready when there are more than two people.
How to check what happens? It is a network issue?

Hiya, Thanks for this awesome idea, i really miss the fact i dont hear my own voice when singing, can you implement this as an option to toggle on or off?

Regards.

Currently, if you a join a party in the middle of a song, and keep pressing "Ready", you get an updated version of everyone's scores for each press. I propose that this behavior to extended, to create a rudimentary spectator mode.

Useful for people not familiar with songs.

Outside a certain octave, notes will render above or below the colored line, rather than on it, even for correct singing.

Unknown what causes this, but the notes and score will occasionally not appear for the play. The song still plays and the player returns to the lobby. Resizing does not solve the issue.

Some album art isn't loading as intended due to incorrect filenames.

On the edges of the note fields, both the required and sung notes will stay on the edges even after the next measure appears.

If a player enters a long string, the game session locks forever

Summary:

Chrome 81 changed the behaviour of RTCPeerConnection close to not fire a signalingstatechange event when close is called directly. https://bugs.chromium.org/p/chromium/issues/detail?id=699036

Ponytone currently relies on this behaviour to remove a player when they leave the game.

https://github.com/Katharine/ponytone/blob/0702367/assets/js/lib/party/p2p.ts#L130-L141
https://github.com/Katharine/ponytone/blob/0702367/assets/js/lib/party/comms.ts#L133-L136

Affected Browsers:

• Chrome 81 onwards.

Expected Behaviour

When a player leaves the party they should be removed and the remaining players should be able to continue with their game.

Current Behaviour

Due to the change in behaviour in Chrome when a player leaves the party their RTCPeerConnection is not removed from the rtcConnections hashTable used by the other players. This causes exceptions when messages are broadcasted and breaks the party as no additional communication can be done between the players. To fix this the players must setup a new party and join it instead.

Example Exception.

Uncaught DOMException: Failed to execute 'send' on 'RTCDataChannel': RTCDataChannel.readyState is not 'open'
    at e.PeerConnection.send (https://ponytone.online/static/party-d25a40a65fe468cece0b.js:1:40635)
    at e.NetworkSession.broadcast (https://ponytone.online/static/party-d25a40a65fe468cece0b.js:1:32830)
    at e.Party.setReady (https://ponytone.online/static/party-d25a40a65fe468cece0b.js:1:31792)
    at e.GameController._handleReady (https://ponytone.online/static/party-d25a40a65fe468cece0b.js:1:27739)
    at e.Ready.<anonymous> (https://ponytone.online/static/party-d25a40a65fe468cece0b.js:1:25472)
    at e.Ready.n.emit (https://ponytone.online/static/party-d25a40a65fe468cece0b.js:1:1364)
    at e.Ready._handleReady (https://ponytone.online/static/party-d25a40a65fe468cece0b.js:1:89654)
    at HTMLButtonElement.button.onclick (https://ponytone.online/static/party-d25a40a65fe468cece0b.js:1:88492)

Possible Solution

Either;

• Call 'this.emit("close")' when closing PeerConnection to re-introduce the previous behaviour. https://github.com/Katharine/ponytone/blob/0702367/assets/js/lib/party/p2p.ts#L44
• Check if the PeerConnection's signalingState is 'closed' before use and trigger it to be removed from rtcConnections.

I'm not familiar with WebRTC so I don't know which of the above is better or if there is another more appropriate solution.

When the user has sung a note and it's rendered as the black dots over the needed notes, points are given under certain conditions where the dots are not matching with the song's notes.

Most of the songs includes videos. Which looks great indeed. But it sadly makes the song loading very long. In some cases, loading is even more long than the song itself.

So I suggest an option that enable or disable videos in songs. This way, one can have the option of downloading only the audio and other stuff, making the loading time really less long.

Song selection list needs:

• Sort by title, artist, album, instrumental
• Search by song, artist, album
• Browse by filter (artist, duets, instrumental, etc)

"Fade in animation is tied to frame rate. When you're tabbed out, you have a frame rate of 0, so the animation never starts, thus neither does the song."

Hello Dev Team,

I tried to sing in your software today in Chrome 61.0 and 62.0 but at all times when I am in a Song my microphone is not picked up by the software. I tried another webapp at: https://www.onlinemictest.com/ to see if my browser can pick up my microphone and it works flawlessly.

Newer songs have started to use the ogg format in favour of mp3. Example: A Final Twilight

I have created a fix for this problem in a branch, by just using the general mutagen importer instead of the mp3-specific one: https://github.com/barbeque-squared/ponytone/tree/import-ogg
However, I literally cannot tests if this actually works in browsers, otherwise I'd have created a pull request instead.

For reference, without the fix you get this error when importing ogg:

$ docker exec ponytone_web_1 python importmlk.py https://www.mylittlekaraoke.com/store/beta/dotmlk/Community/4EverfreeBrony%20-%20A%20Final%20Twilight%20%28Cover%29.tar.mlk  postgres://postgres:postgres@db:5432/postgres
Traceback (most recent call last):
  File "importmlk.py", line 155, in <module>
    info = song_info(tar, filename)
  File "importmlk.py", line 82, in song_info
    duration = mutagen.mp3.MP3(tar.extractfile(mp3_path)).info.length
  File "/usr/local/lib/python3.6/site-packages/mutagen/_file.py", line 49, in __init__
    self.load(*args, **kwargs)
  File "/usr/local/lib/python3.6/site-packages/mutagen/_util.py", line 129, in wrapper
    return func(self, h, *args, **kwargs)
  File "/usr/local/lib/python3.6/site-packages/mutagen/id3/_file.py", line 406, in load
    self.info = self._Info(fileobj, offset)
  File "/usr/local/lib/python3.6/site-packages/mutagen/_util.py", line 158, in wrapper
    return func(*args, **kwargs)
  File "/usr/local/lib/python3.6/site-packages/mutagen/mp3/__init__.py", line 396, in __init__
    raise HeaderNotFoundError("can't sync to MPEG frame")
mutagen.mp3.HeaderNotFoundError: can't sync to MPEG frame