kashalls / kromgo Goto Github PK

When I wrote this 12 hours ago, I planned for most people to use an external source of ratelimiting like NGINX or Cloudflare. Some people are calling it tacky and overcomplicated, so I need to figure out a way to put it in the already condensed app.

I figured out how to middleware it, its just that its difficult to figure out what the real clients ip is for the sake of ratelimiting. You have to trust the proxy thats forwarding to the app to make sure it trusts the X-Forwarded-For or X-Real-Ip or CF-Connecting-IP, plus these IPs have a chance to be non-rfc compliant often having the forwarded ips seperated with commas like: 192.168.1.1,192,168.1.2,etc.

I guess I could set it up so that in the config, you have to specify which header to retrieve the connecting ip with? The http.Request.RemoteAddr in Go has been told to be very very unreliable as per stackoverflow.

There's a debug: true you can flag in the config to put more verbose in the replies from prometheus, but other than that its a design flaw in my part.

Initial configuration attempt left me with:

panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0x6eeedf]
goroutine 1 [running]:
main.main()
/go/src/github.com/kashalls/kromgo/main.go:64 +0x27f

I tracked it down to having this defined:

    globalMounts:
      - path: /kromgo/config.yaml
        subPath: config.yaml
        readOnly: true

Yet, mistakenly the configmap.data had a mismatched extension:

configMaps:
  configmap:
    enabled: true
    data:
      config.yml: |
      ...

I assume that left the pod with either a missing config file or a zero-byte, etc.

The ask is for some additional checks on the config file to log something more friendly and not a panic message.

It would be cool to add something like label_values to extract values of labels.

e.g.

label_values(kubernetes_build_info{instance="192.168.42.10:10257"}, git_version)

would return 1.29.1

The endpoint format seems to be more often used than the raw endpoint, leading me to believe we should default the format to the shields supported format.

This issue lists Renovate updates and detected dependencies. Read the Dependency Dashboard docs to learn more.

Open

These updates have all been created already. Click a checkbox below to force a retry/rebase of any.

• fix(deps): update module github.com/prometheus/client_golang to v1.19.1
• fix(deps): update module github.com/prometheus/common to v0.53.0
• fix(deps): update module gopkg.in/yaml.v2 to v3
• Click on this checkbox to rebase all open PRs at once

Detected dependencies

• Check this box to trigger a request for Renovate to run again on this repository