Git Product home page Git Product logo

Comments (6)

mdholloway avatar mdholloway commented on May 25, 2024

I have a demo of this up on GitHub at https://github.com/mdholloway/kartotherian-lerna. If that looks about as expected, I'll open up a PR.

from kartotherian.

mdholloway avatar mdholloway commented on May 25, 2024

It does indeed make dependency management much easier!

from kartotherian.

mdholloway avatar mdholloway commented on May 25, 2024

@mateusbs17

from kartotherian.

nyurik avatar nyurik commented on May 25, 2024

@mdholloway this is awesome!!! Thanks for tackling this. I have been observing a very similar effort by https://github.com/vega/vega -- they recently did the same migration (I initially suggested it to them, but did not actually participate in the migration itself), and they ended up using workspace feature as being much easier to handle than the hackish Lerna-own dependency hoisting, and instead relies on yarn's native support for workspaces. I think it would make sense for us to follow the same model and use their experience with this.

from kartotherian.

nyurik avatar nyurik commented on May 25, 2024

@mdholloway I have re-done the merge in order to keep the original structure, and migrated to yarn. yarn supports workspaces, thus linking is done on the level of the package manager, not lerna (thus it is far more reliable). Also, I kept the tilelive-vector because it has been significantly altered in order to support language param passing. I'm not sure if WMF is using it, but I think we should keep it in the monorepo. #89

from kartotherian.

mdholloway avatar mdholloway commented on May 25, 2024

Hey @nyurik, sorry but I've been head-down recently trying to get a new MW extension shipped for the Android team. The yarn/workspaces approach sounds interesting and I hope to have a look soon. In the meantime I'll close this PR, since it appears to be obsolete.

from kartotherian.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.