Comments (4)
On the other side this modules add node-mapnik dependency. And it would be better to break the hard dependency between Kartotherian and Mapnik.
from kartotherian.
I'm on the fence on this. You are right about upstream PRs and fork network. But that means that we will need a workaround on linking packages, which is nothing different from the past but makes monorepo pointless and add an extra layer on top development.
In case we decide to revert them, what will do next? Some kind of git submodules control?
from kartotherian.
@mateusbs17 you do bring a good point about submodules - even though I really dislike them, for some limited use like this they might be ok. Also, out of 20ish merged repos, having just the 3 as submodules might be ok... I'm also on the fence on this one, feels dirty either way :)
from kartotherian.
@nyurik we need to discuss it more deeply with the new changes I made for kartotherian to support node 10. I had to "fork" a few packages and it was extremely painful to track every node-mapnik dependency, without yarn workspaces it would be even harder.
from kartotherian.
Related Issues (20)
- Support no-scaling mode
- Mapbox GL HOT 2
- Using Tilerator in the real world HOT 5
- Invalid zoom param - an integer zoom value was expected HOT 2
- Medium severity vulnerability affecting this repo HOT 1
- Discussion: docker packaging, upgrading to latest dependencies HOT 4
- Independencies installation failed HOT 2
- Tilerator performance HOT 1
- Generation job immediate finish HOT 2
- Some jobs of tilerator are invalid
- Support Node.js 10+ HOT 1
- Docker building HOT 2
- 429 status code response when using leaflet map with zoom >= 10 HOT 6
- Archive the project? HOT 1
- Refactor configuration system HOT 1
- Support env variables in config HOT 1
- checkType returns false after setting default value of field HOT 1
- sort hangs if sortFiles gets an empty list HOT 1
- Airbnb eslint rules hard-code es6 rules and are unable to disable it HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from kartotherian.