Git Product home page Git Product logo

Comments (4)

frodrigo avatar frodrigo commented on May 25, 2024 1

On the other side this modules add node-mapnik dependency. And it would be better to break the hard dependency between Kartotherian and Mapnik.

from kartotherian.

thesocialdev avatar thesocialdev commented on May 25, 2024

I'm on the fence on this. You are right about upstream PRs and fork network. But that means that we will need a workaround on linking packages, which is nothing different from the past but makes monorepo pointless and add an extra layer on top development.

In case we decide to revert them, what will do next? Some kind of git submodules control?

from kartotherian.

nyurik avatar nyurik commented on May 25, 2024

@mateusbs17 you do bring a good point about submodules - even though I really dislike them, for some limited use like this they might be ok. Also, out of 20ish merged repos, having just the 3 as submodules might be ok... I'm also on the fence on this one, feels dirty either way :)

from kartotherian.

thesocialdev avatar thesocialdev commented on May 25, 2024

@nyurik we need to discuss it more deeply with the new changes I made for kartotherian to support node 10. I had to "fork" a few packages and it was extremely painful to track every node-mapnik dependency, without yarn workspaces it would be even harder.

from kartotherian.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.