invalid city-name, i dont get it.. about kartotherian HOT 4 CLOSED

For the reference, this is https://maps.wikimedia.org/?uselang=en#13/47.2381/9.5982 and specifically this tile: https://maps.wikimedia.org/osm-intl/13/4314/[email protected]?lang=en (JSON: https://maps.wikimedia.org/osm-intl/13/4314/[email protected]?lang=en ). Looks like the language picking algorithm prefers choosing any definite language to default label.

from kartotherian.

@mdholloway Head's up -- got a patch up in Babel. I am having trouble locally testing this (I don't have the entire stack running locally anymore), but I added a test for the specific edge case (with a comment to explain) so it should work well. If you still have the system set up for testing locally, please test, merge if good, and deploy; might need to update the npm package for babel + extension.json in kartotherian.

from kartotherian.

This latinization part of language picker seems to be bugous in its other aspects too, or at least it doesn't do quite what the description says. It seems to pick language with Latn suffix where name key with different name variant already is in Latin script (T195318) and it picks Latin-script name for language that isn't in Latin script (T208927), while it doesn't pick up name with pinyin suffix for Latin-script language (like Sanming name for Finnish here). @mooeypoo, can you take a look?

from kartotherian.

btw: this fix is meanwhile reflected also now in maps.wikimedia.org. it shows the correct therm "Feldkirch"
thanks.

from kartotherian.