Added additional parameters for configuration and cleaned up/optimized code.

Using this code from the docs:

Html::listGroup([
    [
        'content' => 'Cras justo odio',
        'url' => '#',
        'badge' => '14'
    ],
    [
        'content' => 'Dapibus ac facilisis in',
        'url' => '#',
        'badge' => '2'
    ],
    [
        'content' => 'Morbi leo risus',
        'url' => '#',
        'badge' => '1'
    ],
], [], 'ul', 'li');

Generates this:

<ul class="list-group">
    <a class="list-group-item" href="#"><span class="badge">14</span>Cras justo odio</a>
    <a class="list-group-item" href="#"><span class="badge">2</span>Dapibus ac facilisis in</a>
    <a class="list-group-item" href="#"><span class="badge">1</span>Morbi leo risus</a>
</ul>

But should be this:

<ul class="list-group">
    <li class="list-group-item"><a href="#"><span class="badge">14</span>Cras justo odio</a></li>
    <li class="list-group-item"><a href="#"><span class="badge">2</span>Dapibus ac facilisis in</a></li>
    <li class="list-group-item"><a href="#"><span class="badge">1</span>Morbi leo risus</a></li>
</ul>

Even without the $options, $tag and $itemTag variables, generates the incorrect output.

-------Html.php-------------

protected static function getPanelContent($content, $type)
{
    $out = ArrayHelper::getValue($content, $type, '');
    //return Enum::isEmpty($out) ? $out . "\n" : '';
    return !Enum::isEmpty($out) ? $out . "\n" : '';
}

I'm using a simple call to Enum::getBrowser() and now get this error since I updated to yesterday's update.

Enum.php, line 838: "opera" => Yii::t("kvenum", "Opera").

Many thanks.
Pierre

The new timeInterval method will allow an interval in seconds to be directly specified.

The \kartik\helpers\Html::panel() method phpdoc implies the 'body' option will be wrapped with a <div class="panel-body">...</div> yet there does not seem to be any code performing this.
Is this on purpose as the panel-body wrap should certainly be optional?

For a while now, Yii2 supports getting the users' IP from request headers in a secure manner.

The current implementation of Enum::userIP() is not secure (since it blindly trusts headers) and therefore should not be used.

Furthermore it directly uses the global $_SERVER variable which is is considered bad practice.

If a custom implementation is needed (for filtering local IPs), in my opinion it should at the very least use the Yii2 request object.
Note that in most cases filtering local IPs isn't needed if the request object has been properly configured to trust the correct headers.

Hello!
I'm trying to use radioButtonGroup like this

echo Html::radioButtonGroup('status', $searchModel->status,
    [
        "" => 'All',
        1 => 'Correct',
        0 => 'Neutral',
        -1 => 'Incorrect'
    ],
    [
        'style' => 'white-space: nowrap',
        'encode' => false,
        'item' => function ($index, $label, $name, $checked, $value) {
        $radioButton = Html::radio($name, $checked, [
            'value' => $value,
        ]);
        return Html::label($radioButton . $label, null, [
            'class' => 'btn' . ($checked ? ' active' : '') . ($value > 0 ? ' btn-success' : ($value < 0 ? ' btn-danger' : ' btn-default')),
        ]);
        }
    ]
)

Closure named 'item' is ignored and even die() inside function does not stop execution.
Similar method in ActiveField class work fine. I think it's a bug because I found such code in its definition:
if (!isset($options['item'])) {
This code is missing in Html class and 'item' is rewritten and forgotten by application.

Please respond and/or fix this in your plugin. Thanks!

Steps to reproduce the issue

1. Upgrade PHP from 7.0 to 7.2
2. Upgrade to kartik-v/yii2-helpers 1.3.9 (from 1.3.8 highly likely)

Expected behavior and actual behavior

I had this code with ommited optional args for HTML::listGroup and it worked well before:

echo Html::panel([
        'heading' => 'Тесты:',
        'body' => HTML::listGroup($tabBody,[],'ul','li'),
        'headingTitle' => true
]);

After update of php and Helper module this code with (!!!) ommiting optional args (!!!) produces a bug.

Unsupported operand types
A non-numeric value encountered

The fix is easy --> change code to fill in optional args like that:

echo Html::panel([
        'heading' => 'Тесты:',
        'body' => HTML::listGroup($tabBody,[],[],[],'ul','li'),
        'headingTitle' => true
]);

That`s now a big error but really annoying to redo the code ))
What i am did wrong? Thanks.