karma-runner / karma-dojo Goto Github PK

Can you please republish karma-dojo to npm registry with updated peerDependencies option for karma (053df4b)

npm ERR! peerinvalid Peer [email protected] wants karma@>=0.9.3
npm ERR! peerinvalid Peer [email protected] wants karma@~0.9
npm ERR! peerinvalid Peer [email protected] wants karma@>=0.9
npm ERR! peerinvalid Peer [email protected] wants karma@>=0.9
npm ERR! peerinvalid Peer [email protected] wants karma@>=0.9
npm ERR! peerinvalid Peer [email protected] wants karma@>=0.9
npm ERR! peerinvalid Peer [email protected] wants karma@>=0.9
npm ERR! peerinvalid Peer [email protected] wants karma@>=0.9
npm ERR! peerinvalid Peer [email protected] wants karma@>=0.9

Thanks.

@garcimouche would you like to change the LICENSE to be with your name?

I'm a Google employee and so Karma is owned by Google. I'm changing all the licenses to "Google", which means dealing with CLA and other bullshit. I didn't contribute to this plugin at all, so I think it would make more sense if we change the license to your name. Let me know what you think.

It could be useful to have some information about configuring karma to allow html files to be served.

After a few searches, i found out that :
{pattern: '**/*.html', watched: true, included: false, served: true}
and
preprocessors: { "**/*.html": [] },

Make it works, (not sure about that cause i also had to copy dojo has a local lib)

Thanks to karma-runner/karma#756

I'd like to be able to optionally specify in my Karma config the location of a loader that I want to use. For example:

    dojo: {
      loader: 'http://ajax.googleapis.com/ajax/libs/dojo/1.10.1/dojo/dojo.js'
    },

or

    dojo: {
      loader: 'src/dojo/dojo.js'
    },

I've started on this, but it's not quite ready for PR. It works for CDN hosted loaders (like the first example, but for local paths to the loader, I'm only able to specify an absolute path like:

    dojo: {
      loader: 'C:/code/git/esri-karma-tutorial/src/dojo/dojo.js'
    },

If I use 'src/dojo/dojo.js' or '/base/src/dojo/dojo.js' I get the following errors when starting Karma:

$ karma start
INFO [karma]: Karma v0.12.31 server started at http://localhost:9876/
INFO [launcher]: Starting browser Chrome
WARN [watcher]: Pattern "src/dojo/dojo.js" does not match any file.
INFO [Chrome 41.0.2272 (Windows 7)]: Connected on socket Fzr3afU9HMpd3qBfCVHx with
id 27787735
Chrome 41.0.2272 (Windows 7) ERROR
  Uncaught TypeError: Cannot read property 'getText' of undefined
  at C:/code/git/karma-dojo/lib/adapter.js:54
Chrome 41.0.2272 (Windows 7): Executed 0 of 0 ERROR (0.444 secs / 0 secs)

Seems like I'm really close, so I'm hoping someone has a quick insight to this so I can make a PR.

Thanks!

Chrome updated it's regex around September 2014. It no longer matches the output from dojo.js:319. Trying to debug code is hard without this change.

Please see: https://bugs.dojotoolkit.org/ticket/18248#no1

The fix is simple. Change lib/dojo.js line 319 to.

return eval_(text + "\r\n//# sourceURL=" + hint);

@garcimouche and @vojtajina

I just realized that karma-dojo on npm is pointing to https://github.com/garcimouche/karma-dojo (which is a mirror of this one).

The problem is, all the issues and PRs are being logged here.

Should npm be pointing to this repo, or should we be logging issues on @garcimouche's fork?

Also, I haven't seen any responses to the issues that are being opened here. As a user of this karma plugin that has created a tutorial on and given talks on how to use it, as well as created a yeoman generator based on it, I think the issues recently raised around replacing the outdated copy of the dojo loader source code in this repo by registering dojo as a dependency (#6 and #7) and allowing users to specify the location of their own dojo loader (#5) are important improvements that will make this plugin much more useful. If you want someone to help bring those ideas into this repo and help maintain it, I'd be glad to be made a contributor collaborator.