Git Product home page Git Product logo

Comments (11)

rkimoakbioinformatics avatar rkimoakbioinformatics commented on May 29, 2024

Hi Eugene, thanks for letting us know. We'll take a look.

from open-cravat.

rkimoakbioinformatics avatar rkimoakbioinformatics commented on May 29, 2024

@EugeneEA The issue was due to how OpenCRAVAT was handling liftover for the regions which were inverted between hg19 and hg38. This fix will be included in our next release of OpenCRAVAT. If you want to try this fix now, a workaround is:

1. Find and download cravat_convert.py in 2.1.1 branch of this repo.
2. Put the cravat_convert.py into your OpenCRAVAT pip package directory (which can be found with "pip list -v|grep open-cravat". Add "cravat" to the found site-packages directory).

from open-cravat.

EugeneEA avatar EugeneEA commented on May 29, 2024

Awesome - thanks!
PS I was suspecting that it is due to complicated changes in that region between builds, but I thought that under the hood Cravat uses some third party software for lift over task.
Best, Eugene

from open-cravat.

rkimoakbioinformatics avatar rkimoakbioinformatics commented on May 29, 2024

@EugeneEA Yes, OpenCRAVAT uses pyliftover internally and pyliftover uses 0-based coordinates while OpenCRAVAT uses 1-based coordinates. How OpenCRAVAT handled the communication between the two was the cause of the issue related to the genomic regions which were inverted from hg19 to hg38.

from open-cravat.

EugeneEA avatar EugeneEA commented on May 29, 2024

Hi, I'veagain noticed some problems with liftover procedure:
here is the results of hg19 mapped vcf, submitted to the oc (version 2.2.3) with -l hg19 parameter, notice the absence of the gnomad3 annotation:
image

and here is the same vcf file, which was lifted over to hg38 with gatk picard tool, as you can see now, the gnomad3 annotation is present:
image

Basically cravat maneges to liftover the position but failed to swap alleles (the ref allele was changed between hg19 to hg38), therefore new SNP became unic in the hg38 and absent from gnomad. Could you, please, comment on this bug? Should I just routinely run picard before cravat? (btw why you do not use pickard internally?)

Best, Eugene

from open-cravat.

rkimoakbioinformatics avatar rkimoakbioinformatics commented on May 29, 2024

@EugeneEA Thanks for finding the bug and sorry for the inconvenience. A fix will be included in the next release of OpenCRAVAT. Meanwhile, you can try the fix as follows.

  1. Download cravat_convert.py at
    https://drive.google.com/file/d/1y5Yx1tiJoM5jd380bTiWIQLkYOWCDeas/view?usp=sharing
  2. pip list -v|grep open-cravat
    (This will show you where OpenCRAVAT is installed.)
  3. Overwrite cravat_convert.py in the folder found in (2) with the downloaded cravat_convert.py.

Let me know if works for you.

We didn't use Picard because we wanted to keep minimal dependencies and to use only Python dependencies.

from open-cravat.

EugeneEA avatar EugeneEA commented on May 29, 2024

@rkimoakbioinformatics thanks a lot for such quick reply! It did work out,
best, Eugene

from open-cravat.

rkimoakbioinformatics avatar rkimoakbioinformatics commented on May 29, 2024

@EugeneEA That's great. Glad it worked.

from open-cravat.

EugeneEA avatar EugeneEA commented on May 29, 2024

@rkimoakbioinformatics Hi, I've noticed that you have not change the file in your latest version? was it by mistake or are there any meaningfull reasons?
Best, Eugene

from open-cravat.

rkimoakbioinformatics avatar rkimoakbioinformatics commented on May 29, 2024

@EugeneEA If you mean the fix at #35 (comment), this fix came after the latest version, open-cravat 2.2.3. We are close to releasing the next version, open-cravat 2.2.4, and this version will have the fixed cravat_convert.py file.

from open-cravat.

rkimoakbioinformatics avatar rkimoakbioinformatics commented on May 29, 2024

@EugeneEA I hope that OpenCRAVAT is working for you well. We are conducting interviews to learn what else we could do for genomic variant researchers. Would you be available for such an interview? It will take just about 15 minutes and your input will be invaluable to make OpenCRAVAT even better. It does not have to be about your experience with OpenCRAVAT. We just would like to hear what your experience has been with genomic variant analysis tools. If so, please let me know at [email protected].

from open-cravat.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.