kanewallmann / rtcc-mcp7940n-arduino Goto Github PK

Hi,

Method HasPowerFailed should receive two time structures pointers and read timestamp registers (store power failure and power restore times). So, it will return true when a power failure has occurred but also will read when it happened before clear the state bit (what also clears the registers).

BRs,
Benito

I think you have a typo on line 532 of RTCC_MCP7940N.cpp

to->tm_year = ((from->yrten * 10) + from->yrten) + 100;

shouldn't it be

to->tm_year = ((from->yrten * 10) + from->yrone) + 100;

In the function

bool RTCC_MCP7940N::GetCourseTrimEnabled() { return this->GetFlag(0x08, B100); }

you maybe reading from the wrong register. Register 8 holds the trim value but register 7 holds the enable bit value. You had it correct in the set function.

void RTCC_MCP7940N::SetCourseTrimEnabled(bool enabled) { this->SetBits(0x07, B100, enabled << 2); }