kanecheshire / showtime Goto Github PK

Hello,
This is more of an observation from our team than a bug but

  public static var enabled: ShowTime.Enabled = .never {
    didSet {
      UIWindow.swizzle()
    }
  }

essentially swizzles an event irrespective of .enabled value even if its never. Shouldn't UIWindow.swizzle() only on .debugOnly and .always?

It would be awesome if there was a mode that automatically enabled ShowTime if there was an external screen connected or a screen recording started. It seems like you could do this via observing the following Notifications:

UIScreen.didConnectNotification
UIScreen.capturedDidChangeNotification

I don't install Cocoapods onto my M1 Mac so I'll have to release it on another, so this ticket is to remind me!

looking for touch event data.
thanks in advance!

I've seen this crash on my device since iOS 16.1. I can trigger the issue by deleting a row in a List backed by CoreData in SwiftUI.

Is there any programmatic way to check whether user wear watch or not in watch extension??

This warning shows

The iOS deployment target 'IPHONEOS_DEPLOYMENT_TARGET' is set to 8.2, but the range of supported deployment target versions is 9.0 to 14.4.99.

Please upgrade, like wtw-software/UTMConversion#12 did :)

Hi, how can I visualize taps in a SFSafariViewController that is presented programmatically from another view controller? Will I have to use WKWebView instead?

Thanks for this great tool @KaneCheshire !

I am working on a react native project and pulled in ShowTime using CocoaPods.
I would like to disable ShowTime by default and only enable it for recording videos.
What I don't understand is: where do I change the settings/where does the config file (?) go?
Maybe, I am the only one, but maybe it makes sense to add this info to the readme.

Sorry for the n00b question!

Thank you!
Cheers
Tim

Hello,

I tried enabling Complete Strict Concurrency Checking in Xcode 14.1 (in the Build Settings of my target) and a warning appeared on the line where I was setting ShowTime.enabled.

In particular my code is:

AppDelegate.swift

func applicationDidBecomeActive(_ application: UIApplication) {
    ShowTime.enabled = ...
    ...
}

Please find a minimal sample project attached, it's entirely SwiftUI so no AppDelegate but the behavior is the same.
ShowTimeTest.zip

Thank you.

Hi! Could you fix some warnings to support latest iOS 13.4? Thanks

This is compiling for iOS 9.0 as target, on Xcode 9.2. In a React Native (0.53) project. I installed manually by dropping ShowTime.swift into my project.

Type 'UIFontWeight' (aka 'CGFloat') has no member 'bold'

Solution: https://stackoverflow.com/questions/31771679/uifont-how-to-get-system-thin-font

I can compile by changing the line to end with weight: UIFontWeightBold. I don't do Swift development so I'm not going to say whether this is a correct fix for PR.

Hello, how can i use this framework in my objective-c project ? if possible

I naturally use ShowTime a lot, but one thing I've found is setting it up with our project's colours is a bit tedious. We can make it 1 line of code easier by making it so that by default, ShowTime just uses the outline's colour for the fill color set to 50%.

Would be ace to show key commands like cmd+r etc in a HUD.

I use ShowTime in one app and i really like the visual user interactions. It is very helpful for demoing features and reporting bugs via screen recordings.

The app detects if it runs on an internal test device or not (by looking for an installed other non public app which enables test mode even on release builds) and uses for non-test devices
ShowTime.enabled = EnabledNever
and i expected it would then use close to zero CPU time in this case.

I run into performance issues with the app and analysed it with Instruments. I found ShowTime using more than 24% of all the app's CPU time even when disabled:

284.00 ms 24.2% @objc UIWindow.swizzled_sendEvent(_:) ShowTime
283.00 ms 24.1% UlWindow.swizzled sendEvent(:) ShowTime

Can i fix this by myself?

Thanks for you work, but i see some problems in youre solutions.

It's bad practice to make extension UIWindow and use swizzling to intercept methods. You can potentially create serious problems for your application even though ShowTime can be turned off. ShowTime.enabled = never will ignored with youre code.

Also always is not good for default value, beacuse turn on should be explicit action.