If the default value is provided - ContextEntryConverter uses the wrong entry name.

Let's say this is my logback pattern
%contextEntry{MyValue:MyDefault}

If we follow the code at

we will see that getFirstOption will have value MyValue:MyDefault where it should be MyValue. Therefore if the default is specified - the original value will be always ignored.

When having kamon.instrumentation.logback.mdc.copy.tags = yes the tags are put into the MDC will stay in the MDC forever (well... on that thread ... as long as the thread lives...)

In

Is it ok to remove tags as well?

Hi there,
I attach in here a simple project we crafted at work that shows how we get different output based on the appender type FileAppender and AsyncAppender into the logback.

If you take the project and do an sbt run changing the value of appender-ref (line 25) once with FILE and then with ASYNCFILE you can see that the log/app.log in one case just returns empty and the other it prints the span operationName.

We guess it can be due to some bugs into the kamon-logback or the kanela-agent.
Could you please have a look at the code and let us know?
Thank you so much

example_project_kamon_logback_async.zip

At the moment, it's unclear from the README exactly what I get from adding kamon-logback. The Kamon README says "Logback comes with utilities for adding trace IDs to your logs and instrumentation to keep context when using async appenders.", but doesn't provide much in the way of other details.

See https://gitter.im/kamon-io/Kamon?at=5ab19258e4ff28713a569316

@liff reported getting this error on gitter and I don't see any reason not to limit the weaver filter to the specific class/package where the async appender is.

[AppClassLoader@18b4aac2] error can't determine superclass of missing type org.codehaus.janino.ScriptEvaluator
when weaving type ch.qos.logback.core.boolex.JaninoEventEvaluatorBase