Git Product home page Git Product logo

auctionfaster's People

Contributors

eke00372 avatar iron217 avatar kaminariss avatar pwilkowski avatar thatnerdjosh avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar

auctionfaster's Issues

Sell Items Tab error

Currently getting an error on one of my 3 characters I've tested on. After reloading and opening the auction frame I get
1x AuctionFaster\auctions-Auctions.lua:127: attempt to concatenate local 'itemName' (a nil value) AuctionFaster\auctions-Auctions.lua:127: in function GetLowestPrice'
AuctionFaster\inventory.lua:95: in function AddItemToInventory' AuctionFaster\inventory.lua:19: in function ScanInventory'
AuctionFaster\tabs\sell\ui.lua:41: in function AddSellAuctionHouseTab' AuctionFaster\main.lua:24: in function ?'
...edia-3.0\CallbackHandler-1.0\CallbackHandler-1.0-6.lua:147: in function <...edia-3.0\CallbackHandler-1.0\CallbackHandler-1.0.lua:147>
[string "safecall Dispatcher[1]"]:4: in function <[string "safecall Dispatcher[1]"]:4>
[C]: ?
[string "safecall Dispatcher[1]"]:13: in function ?' ...edia-3.0\CallbackHandler-1.0\CallbackHandler-1.0-6.lua:92: in function Fire'
ElvUI\Libraries\AceEvent-3.0\AceEvent-3.0-4.lua:120: in function <ElvUI\Libraries\AceEvent-3.0\AceEvent-3.0.lua:119>

Locals:
nil`

Working fine on 2 other characters. All running the same addons enabled. If I close the auction window and reopen I get the Buy Items tab and it works, but Sell Items remains blank. Also getting ERROR 54 in chat, but no additional Lua errors when I go attack a training dummy in town. This Error prints even after just logging in before visiting the AH.
edit: After looking it seems these are just printing standard game errors like "Spell is not ready yet."

CN server

HI, when i click refresh auction, alway need to wait 1-2mineutes to show the latest item price(my lowest price item), i have no idea why?

Suggestion: reset filters button

A "Reset filters" button should be added in the Filters page (in the Sell Items page). It would simply reset any filters to the default value.

Auction Info

Auction Info title overlays contents - sell page

image

Suggestion: feedback printout for posted auctions

I'd like to see some printout when I post items to make sure it was the right stack size and price, similar to Auctionator (like "posted Stuff x20 for 300g), preferably showing both per item and per stack prices.

Delayed tooltip

I'd like for the tooltip to only be displayed if left over the item for a reasonable time. It currently makes it hard to see the other items in the list.

Chidori

Issue: Buying own auctions does not return error message

Just tried to buy my own auction with "Buy Item" in the "Sell items" window. Gives back no error, auction just disappears in the window without message. Auction is back in the list after refresh.

Also tried "Chain Buy" while cheapest auction was my own. "Chain Buy" breaks down completely without returning error or message ("Buy" button greys out without being able to make more purchases, even those that aren't my own).

Adding manually my own auction, which was not the cheapest, to the Chain Buy Queue and buying it also breaks the Chain Buy without returning error message.

Naturally not really errors as nobody should buy his own auctions but it should return an error message though :)

Problem with auction interface while using elvui

ui_probl

I've never used github before but I've tried to upload an image above showing whats wrong. I'm using elvui and when I load the auction house all is well until I go to use your addon, then the backgrounds of other tabs in the auction window go transparent until I next reload my UI.
I hope you can fix this because this addon is just what I've been looking for!

thanks

EDIT: i see someone else suggested a transparency slider, i know that would probably be hard to do, but the transparency/ default ui of auctionfaster may have something to do with it or conflict with elvui transparency?

Auction Info Frame Overlap

There seems to be an overlapping frame when you open Auction Info on any item in the Sell Items tab.

auctioninfoframeoverlap

Also an issue in menu options. Enable AuctionFaster appears to not toggle. No visual toggle and addon does not toggle between enabled and disabled. No Lua errors.

New Feature Suggestions

Love the addon but I'd love to see a few quality of life changes.

  • Disable "Incomplete Sell" popup box altogether
  • Shift Clicking item in back auto searches the buy tab without having to click on the search bar then click the item(Auctionator and other addons do this if you don't understand what I'm trying to explain)
  • Alt clicking items in bag when at the auction house auto switches you to the sell tab and starts searching the AH so that you can list your item. (Again Auctionator does this I believe it is a optional keybind though in it's settings.)

Just a few small things I wish the addon currently had implemented overall though this has become my favorite AH addon so Thank you.

Can't sell Pets

When trying to sell a pet auctionfaster populates the price fields, but when pressing any of the available sell options nothing happens.

Not working at all..

I just installed this addon from the Twitch app. At first it said "addon disabled because too old". After reloading my UI the error message doesn't appear anymore but I simply can't sell items. Bid and Buy price is set but after I press "post o.." or "post all" nothing happens.

Suggestion: Set Default Tab

Would like to be able to set the AH to default to the Buy and/or Sell Page of the addon rather than the base auction house being the default tab.

Also Happy to finally see this make it's way to the curse client.

Don't always show "Incomplete sell"

What happens a lot is this:

  • I sell all my items
  • One item gets selected in the sell window
  • I close the auction house
  • I open the auction house again later on
  • "Incomplete sell" is displayed for the item that was previously unintentionally selected

I would suggest to only show the "Incomplete sell" popup after actively selecting an item. (Or remove it completely / add the ability to disable that feature.)

Suggestion: Tooltip for other sale items

It would be nice to have a tooltip show for other seller's items when you're selling a piece of gear in case you want to quick check things like sockets or secondary stats. Sometimes the boe items can have a bit more value if the secondaries are more desirable so to be able to see the other items listed on the fly could be useful when you hover over.
image

Suggestion: add a drag&drop slot for selling

Just as with default UI, add an empty drag&drop slot where people would manually drag an item from their bags in order to quickly post it without searching through the (sometimes incredibly long) left-side inventory items list.

Is this addon abandoned?

I was looking forward to something to kill the other horrendously interfaced AH-related addons. Shame if it isn't going to see life, before it dies.

Error Report

Message: ...nterface\AddOns\AuctionFaster\tabs\buy\functions.lua:118: attempt to perform arithmetic on field 'lastPage' (a nil value)
Time: Sat Oct 6 13:49:49 2018
Count: 1
Stack: ...nterface\AddOns\AuctionFaster\tabs\buy\functions.lua:118: attempt to perform arithmetic on field 'lastPage' (a nil value)
...nterface\AddOns\AuctionFaster\tabs\buy\functions.lua:118: in function UpdatePager' ...nterface\AddOns\AuctionFaster\tabs\buy\functions.lua:27: in function OnShow'
Interface\AddOns\AuctionFaster\tabs\buy\ui.lua:16: in function <Interface\AddOns\AuctionFaster\tabs\buy\ui.lua:15>
[C]: in function Show' Interface\FrameXML\UIParent.lua:3134: in function <Interface\FrameXML\UIParent.lua:3129> [C]: ? [C]: in function ShowUIPanel'
...ace\AddOns\Blizzard_AuctionUI\Blizzard_AuctionUI.lua:174: in function `AuctionFrame_Show'
Interface\FrameXML\UIParent.lua:1660: in function <Interface\FrameXML\UIParent.lua:1090>

Locals: self =

{
SetDefaultModuleLibraries = defined @interface\AddOns\AuctionFaster\Libs\AceAddon-3.0\AceAddon-3.0.lua:367
AddToFavorites = defined @interface\AddOns\AuctionFaster\tabs\buy\functions.lua:153
EnableModule = defined @interface\AddOns\AuctionFaster\Libs\AceAddon-3.0\AceAddon-3.0.lua:332
modules =
{
}
baseName = "AuctionFaster"
IterateEmbeds = defined @interface\AddOns\AuctionFaster\Libs\AceAddon-3.0\AceAddon-3.0.lua:442
SecureHook = defined @interface\AddOns\AuctionFaster\Libs\AceHook-3.0\AceHook-3.0.lua:336
RawHookScript = defined @interface\AddOns\AuctionFaster\Libs\AceHook-3.0\AceHook-3.0.lua:395
OnShow = defined @interface\AddOns\AuctionFaster\tabs\buy\functions.lua:20
UpdateFavoriteFrame = defined @interface\AddOns\AuctionFaster\tabs\buy\ui.lua:314
SetDefaultModulePrototype = defined @interface\AddOns\AuctionFaster\Libs\AceAddon-3.0\AceAddon-3.0.lua:409
defaultModuleState = true
DrawSearchPane = defined @interface\AddOns\AuctionFaster\tabs\buy\ui.lua:37
DisableModule = defined @interface\AddOns\AuctionFaster\Libs\AceAddon-3.0\AceAddon-3.0.lua:350
AddToQueue = defined @interface\AddOns\AuctionFaster\tabs\buy\functions.lua:270
RegisterMessage = defined @interface\AddOns\AuctionFaster\Libs\CallbackHandler-1.0\CallbackHandler-1.0.lua:90
UnregisterMessage = defined @interface\AddOns\AuctionFaster\Libs\CallbackHandler-1.0\CallbackHandler-1.0.lua:153
hooks =
{
}
AUCTION_ITEM_LIST_UPDATE = defined @interface\AddOns\AuctionFaster\tabs\buy\functions.lua:229
helpBtn = {
}
RemoveCurrentSearchAuction = defined @interface\AddOns\AuctionFaster\tabs\buy\functions.lua:193
SetEnabledState = defined @interface\AddOns\AuctionFaster\Libs\AceAddon-3.0\AceAddon-3.0.lua:424
Hook = defined @interface\AddOns\AuctionFaster\Libs\AceHook-3.0\AceHook-3.0.lua:274
enabledState = true
buyTabAdded = true
RegisterEvent = defined @interface\AddOns\AuctionFaster\Libs\CallbackHandler-1.0\CallbackHandler-1.0.lua:90
DrawFilterFrame = defined @interface\AddOns\AuctionFaster\tabs\buy\ui.lua:79
IterateModules = defined @interface\AddOns\AuctionFaster\Libs\AceAddon-3.0\AceAddon-3.0.lua:437
RawHook = defined @interface\AddOns\AuctionFaster\Libs\AceHook-3.0\AceHook-3.0.lua:313
SearchStacksCallback = defined @interface\AddOns\AuctionFaster\tabs\buy\functions.lua:303
DrawSearchResultsTable = defined @interface\AddOns\AuctionFaster\tabs\buy\ui.lua:319
CreateFavoriteFrame = defined @interface\AddOns\AuctionFaster\tabs\buy\ui.lua:290
SearchAuctionsCallback = defined @interface\AddOns\AuctionFaster\tabs\buy\functions.lua:92
AddBuyAuctionHouseTab = defined @interface\AddOns\AuctionFaster\tabs\buy\ui.lua:8
Enable = defined @interface\AddOns\AuctionFaster\tabs\buy\functions.lua:15
Un

Suggestion: aggregate identical auctions

It would be really helpful if in the current auctions' list, identical auctions were being listed in one row, showing the count of auctions somewhere (either in the Qty column or a separate one).

Feature Request: When selling, match price to selected item

Like Auctionator, I would like to be able to choose a price in the list, not necessarily the absolute lowest, and undercut that one instead. Basically just make it so I can click any entry in the list and have it set the Bid/Buy amounts to that minus one copper.

Auto Refreshing

Simply make a button that just refreshes the page every 10 seconds (adjustable), just like sniper in TSM.
This would be very great to get deals faster than everyone, as sniper only scans first page of ALL AUCTIONS.
Whereas this would only scan the page under a specific name example "Akunda's Bite".
Very effective option!

Suggestion: Font Selection

Not sure if you're planning to add, but maybe support for the Shared Media support of font selections in the Interface options. Grabbed the latest release and everything else still looks good.

Suggestion : Keybind + Click Search Funtion

Love the addon one of the features I find personally that it is currently lacking is a Shift+Click or Alt+Click to auto fill that item name into the search bar and start searching for that item.

List dissapears when I have pets in my bags.

2x AuctionFaster\tabs\sell\functions.lua:126: attempt to compare string with number
AuctionFaster\tabs\sell\functions.lua:126: in function <AuctionFaster\tabs\sell\functions.lua:115>
(tail call): ?
[C]: in function sort' AuctionFaster\tabs\sell\functions.lua:108: in function DoFilterSort'
AuctionFaster\tabs\sell\functions.lua:42: in function ?' ...que\Libs\CallbackHandler-1.0\CallbackHandler-1.0-7.lua:119: in function <...que\Libs\CallbackHandler-1.0\CallbackHandler-1.0.lua:119> [C]: ? ...que\Libs\CallbackHandler-1.0\CallbackHandler-1.0-7.lua:29: in function <...que\Libs\CallbackHandler-1.0\CallbackHandler-1.0.lua:25> ...que\Libs\CallbackHandler-1.0\CallbackHandler-1.0-7.lua:64: in function SendMessage'
AuctionFaster\modules\inventory.lua:49: in function ScanInventory' AuctionFaster\tabs\sell\functions.lua:24: in function OnShow'
AuctionFaster\tabs\sell\ui.lua:18: in function <AuctionFaster\tabs\sell\ui.lua:17>
[C]: in function Show' AuctionFaster\main.lua:71: in function ?'
...eBartender4\libs\AceHook-3.0\AceHook-3.0-8.lua:90: in function `AuctionFrameTab_OnClick'
[string ":OnClick"]:1: in function <[string ":OnClick"]:1>

Suggestion: one click search for favorites

Current behavior: clicking any of the Favorite Searches in the Buy Items window fills the Search field of the AH with the saved/favorite item; after that, the user has to click the Search button. This is a redundant step.
Proposed behavior: clicking any of the Favorite Searches should automatically start searching for that favorite item.

Editbox remove focus on enter

After I enter a custom amount and then press enter the text box keeps focus, meaning if I start typing it continues to add text.

image
In the above screenshot I entered a new price and then pressed enter. The price updates just fine, but the cursor still blinks allowing me to type more text. Maybe could just clear it on enter being pressed when setting a new price?

Suggestion: sorting types for inventory items

Add some small buttons in the Sell Items frame that would change how the list of Inventory Items are sorted.
Example:

  1. Alphabetically
  2. By price value
  3. By rarity
    Use case: being able to always leave the list sorted by price or rarity so that the most valuable sellable items are always at the top, for easy posting

attempt to call method 'ObjectList' (a nil value) when loaded together with TSM4

1x AuctionFaster\tabs\sell\ui.lua:77: attempt to call method 'ObjectList' (a nil value)
AuctionFaster\tabs\sell\ui.lua:77: in function `DrawItems'
AuctionFaster\tabs\sell\ui.lua:51: in function `DrawItemsFrame'
AuctionFaster\tabs\sell\ui.lua:25: in function `AddSellAuctionHouseTab'
AuctionFaster\tabs\sell\ui.lua:11: in function <AuctionFaster\tabs\sell\ui.lua:10>
(tail call): ?
AuctionFaster\main.lua:31: in function `?'
...que\Libs\CallbackHandler-1.0\CallbackHandler-1.0-6.lua:145: in function <...que\Libs\CallbackHandler-1.0\CallbackHandler-1.0.lua:145>
[string "safecall Dispatcher[1]"]:4: in function <[string "safecall Dispatcher[1]"]:4>
[C]: ?
[string "safecall Dispatcher[1]"]:13: in function `?'
...que\Libs\CallbackHandler-1.0\CallbackHandler-1.0-6.lua:90: in function `Fire'
Bartender4\libs\AceEvent-3.0\AceEvent-3.0-4.lua:120: in function <Bartender4\libs\AceEvent-3.0\AceEvent-3.0.lua:119>

Locals:
nil

Issue: unable to select items in the Buying tab

  1. Open the AH and the AF Buying tab
  2. Search for any item (tested on: Siren's Pollen)
  3. After the results are shown, click on any of the items

Expected behavior: an item gets highlighted and becomes available for a purchase

Current behavior: the item wouldn't highlight and the Buy button doesn't do anything

If you switch to the default AH buying page, you can buy any items from the results
Client language: Russian

8.0 Bugs

Broken Buy Tab
image

Also a suggestion for the buy tab: Add option/Clickable button for max # of stacks
image

Suggestion: search box for inventory items

A simple search box with filter-as-you-type feature should be implemented at the top of the Inventory Items list in the Sell Items page. This would help with quickly finding the desired items to be posted when the player has a lot of different items in bags.

New option suggestions

I have a handful of suggestions, primarily for the Sell Items functionality...

New Options:

  • Ability to choose a default for "Remember Last Price" setting for all newly encountered items
  • Ability to choose a default for "Always Undercut" setting for all newly encountered items
  • A global setting to override the above two item-specific settings
  • Option to assume numbers in sell (bid/buy) boxes represent gold, so don't have to type a 'g' at the end
  • Disable "Incomplete Sell" popup box altogether

Functionality Improvements (Sell Tab):

  • Improve tabbing between fields, particularly the two sell price fields. Tabbing order is buggy, and some fields get tabbed to and then you can't tab or shift-tab out of them such as Stack Size.
  • Automatically highlight all text in fields when tabbed to, so don't have to ctrl-A to replace all text.

Apologies if any of these are already implemented. I've only just started playing around with the addon. Thanks!

infoPane.lua:65: attempt to concatenate a nil value

I get this error and a warning "This addon has been disabled. you should install an updated version" when attempting to post.

2x AuctionFaster\tabs\sell\infoPane.lua:65: attempt to concatenate a nil value
AuctionFaster\tabs\sell\infoPane.lua:65: in function UpdateInfoPaneText' AuctionFaster\tabs\sell\validators.lua:75: in function ValidateStackSize'
AuctionFaster\tabs\sell\ui.lua:217: in function OnValueChanged' AuctionFaster\Libs\StdUi\widgets\EditBox.lua:102: in function Validate'
AuctionFaster\Libs\StdUi\widgets\EditBox.lua:84: in function SetValue' AuctionFaster\tabs\sell\functions.lua:136: in function UpdateStackSettings'
AuctionFaster\tabs\sell\functions.lua:160: in function SelectItem' AuctionFaster\tabs\sell\functions.lua:181: in function CheckIfSelectedItemExists'
AuctionFaster\tabs\sell\functions.lua:23: in function ?' ...que\Libs\CallbackHandler-1.0\CallbackHandler-1.0-7.lua:119: in function <...que\Libs\CallbackHandler-1.0\CallbackHandler-1.0.lua:119> [C]: ? ...que\Libs\CallbackHandler-1.0\CallbackHandler-1.0-7.lua:29: in function <...que\Libs\CallbackHandler-1.0\CallbackHandler-1.0.lua:25> ...que\Libs\CallbackHandler-1.0\CallbackHandler-1.0-7.lua:64: in function SendMessage'
AuctionFaster\modules\inventory.lua:47: in function ScanInventory' AuctionFaster\modules\inventory.lua:23: in function ?'
...que\Libs\CallbackHandler-1.0\CallbackHandler-1.0-7.lua:119: in function <...que\Libs\CallbackHandler-1.0\CallbackHandler-1.0.lua:119>
[C]: ?
...que\Libs\CallbackHandler-1.0\CallbackHandler-1.0-7.lua:29: in function <...que\Libs\CallbackHandler-1.0\CallbackHandler-1.0.lua:25>
...que\Libs\CallbackHandler-1.0\CallbackHandler-1.0-7.lua:64: in function `Fire'
Bartender4\libs\AceEvent-3.0\AceEvent-3.0-4.lua:120: in function <Bartender4\libs\AceEvent-3.0\AceEvent-3.0.lua:119>

Suggestion: blacklist for Inventory Items

Add a form of blacklisting items right from the inventory list (maybe shift + right click or something like this, or ctrl + shift + left click). The blacklisted items would go to the bottom of the list and be grayed out (so that you can also see and un-blacklist them).
Use case: I (and probably many others too) have a lot of items in inventory that are always carried with me and not for sale (consumables, profession reagents such as vellums/parchments/etc, for which there's no reason to be shown in the list.

OneClickBuyout

Simply make this addon work with "OneClickBuyOut", where when you hold shift and right click it will instantly buyout auctions and skip the confirmation.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.