Keep param in the link to first page about kaminari HOT 9 CLOSED

Having the first page link contain the page param is also necessary when there are multiple things being paginated on a single page. +1 for implementing the above gist.

from kaminari.

Also, the instructions in the README under "Creating friendly URLs and caching" fail on page 2 due to the :page parameter being set to nil when creating a link to the previous page.

You can fix it in your routes like this:

resources :my_resources do
  get 'page/:page', :action => :index, :on => :collection, :defaults => {:page => 1}
end

from kaminari.

I think this is something that could be configurable but not the default behavior.

from kaminari.

@amatsuda @zzak could you take a look at https://github.com/yuki24/kaminari/compare/master...44-first-page-param? It adds skip_first_page_param config and I would like you to review the change.

from kaminari.

+1 for this change. I have a view which contains items with a datetime. When opening this view (without a page set), I would like to jump immediately to the page with the first item after the current time. This works fine, however, when going back to the first page, it again jumps (because the page param is not set) and displays a page somewhere in the middle. Personally I see no reason for not simply including the page param for the first page as well.

from kaminari.

+1 for this change also. Without it I will be obliged to "monkey patch" or switch away. There has been no reason not to release this change for ... quite a while.

from kaminari.

Please, merge it

from kaminari.

+1 to merge in yuki24's change. I have my Gemspec pointing to his branch instead of the official release. Please update!

from kaminari.

I would add also this functionality, to make it possible to setup this option locally, not globally:
(https://github.com/amatsuda/kaminari/pull/543) https://github.com/amatsuda/kaminari/pull/543/files

from kaminari.