Git Product home page Git Product logo

arkhamdb-json-data's People

Contributors

akaan avatar alfonsolumera avatar cfergeau avatar derornos avatar drawntotheflame avatar elkeinkrad avatar evgeny727 avatar fabrice2 avatar fafranco82 avatar fblampe avatar feyrbert avatar fragarch avatar gizmo8690 avatar grabben2 avatar javnik36 avatar kamalisk avatar kamiben avatar kynailsorg avatar mattschaffrath avatar robert-huang avatar sarnetsky avatar sheff73 avatar shkuo avatar tengounplan avatar tjanu avatar traxx0r avatar tvaru avatar vittek82 avatar youbifox avatar zzorba avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

arkhamdb-json-data's Issues

Consider adding 'scenario_position' field for 'scenario' cards.

What do people think about adding a new scenario_position field to the Scenario cards.

One of the recent FFG articles suggests The Forgotten Age will have a 'forked' scenario choice (A and B variants, like Dunwich's Extracurricular Activities + The House Always Wins), meaning that position + pack cycle_position alone can't determine campaign scenario order.

I'd propose we add a new 'scenario_position' field. Using Dunwich as an example, we could set it to the same # for A/B variants (i.e both Extracurricular Activities + The House Always Wins will have scenario_position: 1 and The Miskatonic Museum would be scenario_position: 2. Position in the pack would determine 'a' vs 'b' for now.

This would be helpful for anyone building campaign trackers off of ArkhamDB.

Website still in English

Hey there,
Is there a particular reason why the Italian section is still in English in the last TFA packs, even though I translated those a couple weeks ago?

Separate "Books" card entries per novella (book)?

Has any thought been given to separate the "Books" card entries each into its own "Promotional" sub-entry? I have to assume that some ArkhamDB users have some of the novellas (books) but not all of them.

Encounter code mismatch for K'n-yan

There is a mismatch with the encounter code used for K'n-yan (HotE)

This mismatch is preventing the encounter cards being imported on a clean install of arkhamdb, with the error

[Exception]                                                                                                                                                                                              
  Invalid code [knyan] for key [encounter_code] in {... "encounter_code":"knyan", ...}

Changing the encounter code in encounters.json to simply knyan allows the cards to be imported normally. Is this an appropriate change to make?

Dim Carcosa Story/Location cards missing encounter attributes & images

The Dim Carcosa Location cards are special in that they do not have "unrevealed" sides. Instead, they are linked to Story cards. In checking out the scenario in the DB I noticed that the Story cards all have incorrect images and are missing encounter codes. I managed to find corrected images for some of the Story cards, but I could not source all the images.

These are the suggested fixes to be made:

Add the following attributes:

    encounter_code = "dim_carcosa"
    encounter_name = "Dim Carcosa"

To these cards:

    03325b
    03326b
    03326d
    03327b
    03327d
    03327f
    03328b
    03328d
    03328f
    03329b
    03329d
    03330b
    03331b

Replace imagesrc (with the attached images below) for these cards:

    03325b - Songs That the Hyades Shall Sing
    03326d - Bleak Desolation
    03327f - The Coffin
    03328f - The Archway
    03329d - Steps of the Palace
    03330b - The Fall
    03331b - Hastur's End

I was unable to find images for the following cards. Their current images are incorrect:

    03326b
    03327b
    03327d
    03328b
    03328d
    03329b

03325b
03326d
03327f
03328f
03329d
03330b
03331b

Missing translations

Certain cards are remaining in English, even though the translation seems correct.
What can the issue be?

Talking about Defiance (2), Premonition, Live and Learn and Take Heart from hoe
Well Prepared (2), Truth from Fiction, True Understanding, Hatchet Man, High Roller (2) and Enraptured from tbb

About the translation of TFA

This is a question more then an issue: do I need to fill in the packs myself just copying the code of the card I'm referring to and using the standard scheme?
As there's no skeleton of the file already on the translation directory

Importing Cards - problem

Hello. I get an error when trying to import arkhamdb-json-data. What could it be because of?

screenshot - https://prnt.sc/u7jr6j

Importing Cards...
17:29:02 ERROR [console] Error thrown while running command "app:import:std ark". Message: "No repository found at [arkpack/core]" ["exception" => Exception { …},"command" => "app:import:std ark","message" => "No repository found at [arkpack/core]"]

In ImportStdCommand.php line 861:

No repository found at [arkpack/core]

EoE investigator deck building requirements

The Edge of the Earth investigators deck building requirements are incorrect. They should all read “up to 5 other insert class cards level 0” this is the same wording that should be applied to the tabooed version of Norman Withers (Ire of the Void).

spoiler tag missing on a few cards

Came across a few cards that don't have spoiler marked on them:

The other last king VIP cards seem to have spoiler marked on the linked_card part, but not on the main card. Just as an FYI, seems to be working okay on the side

Can we have a shared account to upload to the site?

Hey there,
This was probably asked before but I didn't find it in the archived questions.
Is there a way we can have a shared account so we can upload the files directly on the site?
So that Kamalisk doesn't have to do it every time we upload, like, five cards with every new pack or we correct something.

Bonus question: how do I make multiple corrections in a single pull request?
I created 10 of those with the syntax fixes ^^"

Card 53016 is incorrectly subtyped as a weakness

Card 53016 "Return to The Untamed Wilds" is a scenario card, and incorrectly has a subtype_code and subtype_name indicating it is a weakness. Looks like the fix is to remove these attributes from the card.

Adding the rest of the investigator starter pack cards

Does anyone have a fork where they're working on adding the rest of the leaked investigator starter cards? Text only, of course, until the official images come out.

I've probably got enough time/willpower to add the remaining cards for one faction, and don't want to duplicate effort. Perhaps we could use this issue to co-ordinate?

Some people have got lucky and already received theirs, so there is no chance of text on the cards changing — I hope there's nothing against me adding some?

Cards from Undimensioned and Unseen are incorrectly labeled as in the Dunwich Legacy Deluxe

In particular, Quick Thinking (https://arkhamdb.com/card/02229), Rite of Seeking (4) (https://arkhamdb.com/card/02233) and Esoteric Formula (https://arkhamdb.com/card/02254) are all listed as being in Dunwich Legacy, instead of in the unreleased Undimensioned and Unseen mythos pack (source: https://www.fantasyflightgames.com/en/news/2017/1/25/undimensioned-and-unseen/)

This causes issues when deckbuilding with Dunwich Legacy.

Translation question of new language

Hello, I'm a Korean arkham horror card game fan.
I find that arkhamDB site may be able to be translated by translating of json data of this hub.

For translation, is it enough that I PR the translated json files in /translation/kr folder?

Thanks!

Front and back side for location type cards mixed up

Hi,
i think that the front and back sides of location based cards are mixed up. For example the two cards:

https://arkhamdb.com/card/02245
https://arkhamdb.com/card/01113

show that the back_flavor is sometimes on the wrong side (according to picture) and sometimes on the right side. Also i have a feeling, that it would be better if the front card is shows the unrevealed side of the card and the back side the revealed effects. Just like it is done with act and agenda cards.

regards,
Mike

Links between cards 51026 and 51026b should be reversed

Card 51026 is an Act card. It's back side (51026b) is an Enemy card.

As I file this, the linkage is set up this way:

  • Act 51026 hidden
  • Enemy 51026b is linked to 51026

This should really be reversed, making the Enemy card the hidden back image for the Act card. Fix would be:

Card 51026:

  • Remove hidden=true
  • Add link to 51026b

Card 51026b:

  • Add hidden=true
  • Remove link to 51026

Card 02041 is incorrectly subtyped as a weakness

Card 02041 "Extracurricular Activity" is a scenario card, and incorrectly has a subtype_code and subtype_name indicating it is a basic weakness. Looks like the fix is to remove these attributes from the card.

Encode the different types and quantities of 'Uses' into structured data.

There are a number of cards that target a specific type of use (supplies, charges), and Akachi has a deckbuilding restriction that is currently implemented as a regex.

Would it be worth putting the concept of uses into the structured json?

Maybe something like:

uses: 'charges',
uses_count: 4,

Happy to make a PR if there's consensus.

Wrong syntax (is this how it's called?)

Hey Allan,
There's an issue on the main page of the github where you write wich codes to use for the symbols on the card to show.
They are not [will],[lore] and [strength] as it is written, but [willpower], [intellect] and [combat]
So I have to rewrite all the Italian cards for the proper formatting.

Is there a way it can be done with a formula on the site?
Otherwise I'll just correct it one by one :)

UAU agenda and act cards don't have a back_name

The cards:

  • Rampaging Creatures (agenda)
  • Biding Its Time (agenda)
  • Horrors Unleashed (agenda)
  • Saracenic Script (act)
  • They Must Be Destroyed! (act)

from "Undimensioned and Unseen" don't have their respective back_name (back_flavor is missing too)

New field for 'vengeance' on cards for TFA

Its a keyword with a rule -- would be nice to have an encoding of some kind for this (even if its just a 'miscellaneous field' of some kind), so that we can search/filter for the cards.

Standard for per investigator identifier of numerical values (such as health/clues/etc)

Is there a standard way to be able to indicate that a particular field (i.e. clues) should be 'per investigator' in the json?

While I don't see a way in the card_schema.json to do this, I do see that in the tfa_encounter.json, a 'health_per_investigator' boolean field was used for the Harbinger of Valusia. Is this a standard field we should expect across all numerical fields? I ask because I don't see a similar "clues_per_investigator" field for locations that have variable clues in that same tfa_encounter.json.

Would it make more sense to have a single field that designates all fields which should be adjusted by number of investigators? i.e. "per_investigator_fields":"clues,health"
(I understand that it will be highly unlikely to have a template of a location with health, or an enemy with clues, but it would also allow for flexibility if fields we aren't expecting to have 'per investigator' suddenly gained them. (i.e. enemy_fight - shutter))

Help understanding back_link, double_sided and hidden attributes

Hello, I'm attempting to understand the intended usage of back_link, double_sided and hidden attributes.

Mythos card code 03325b for instance, has a back_link to 03325 but is not double_sided and is also hidden. The front side, code 03325 is also not double_sided but does not contain a back_link to 03325b

Conversely, code 05264 contains both double_sided and back_link to 05264b. And code 05264b has neither double_sided nor back_link but does contain hidden.

Many cards contain double_sided but no back_link, so I speculate that for these cases we just assume to append 'b' for the back code.

For hidden, it seems to appear mostly on back_sides ... but not always - for example: code 03221 (The Organist)

I'd appreciate any clarification. I'm happy to help make changes if some of this data is in error.

Typo in back_link entry

Hi,

in pack/tde/pnr_encounter.json, line 287
"back_link": "06259"
should likely be:
"back_link": "06259b"

Cheers,

New Import of Data

I am doing a new import of ArkhamDB Json data using:
php app/console app:import:std ../arkhamdb-json-data/

and I keep running into an [Exception]
Missing key [shroud] in {"back_text":"As an additional cost for you to enter Catacombs, investigators at your location must spend
1[per investigator] clues, as a group.","clues":2,"code":"03247","double_sided":true,"encounter_code":"the_pallid_mask","faction
_code":"mythos","flavor":"Skulls and bones decorate the walls of this wide hallway in a macabre fashion.","illustrator":"Greg Bob
rowski","name":"Catacombs","pack_code":"tpm","position":247,"quantity":1,"text":"Forced</b> - When The Gate to Hell is reveal
ed: Put the top 2 Catacombs in the Catacombs deck into play above and below The Gate to Hell.","type_code":"location"}

It is happening in (Changing the encounter_code of Catacombs.

when I look at this pack tpm_encounter.json, doesn't look like any of these cards have a Shroud value.

metadata for traits & autometic traits update for translation

Since traits are managed just as text format, such as Item. Weapon., I tried to generate a script for it (ko translation purpose, currently).

This python script traits.py may work:

  • generating traits metadata as json format: traits.json (for translation placeholder)
  • updating traits for translation: ko/traits.json; working like update_locale.coffeescript, by filling new traits from english one.
  • updating translation json files from traits metadata. (the below example is autometically updated json file)
    pmp

My forked repo link about it: https://github.com/elkeinkrad/arkhamdb-json-data/tree/traits

I think this may be helpful for someone, but I wonder that this work may be pulled or not; also, what I will be do more (such as argparse, menual and so on).

Translations ignored

Hi, on 9 April I have opened a pull request with many translations in italian, but my pull request was ignored and now is pending yet... Why?

Card data 03321a & 03321b are incorrect

Card 03321a "Search For the Stranger (v.I)" has no backimagesrc, nor does it have linked_card or linked_to_code. This is an Act card, so it seems like it should have either a back image or link data.

Card 03321b "The Pallid Mask" image asset is incorrect. The card does have an imagesrc, and the path is correct (bundles/cards/03321b.jpg), but the actual .jpg is the wrong image.

03321b also has links to card 03321a, but it looks like the link is actually meant to go in the reverse direction. Please see rationale in details for card 03321a above.

Proposed Fix:

It looks like these two cards are meant to be paired in the same way that 01121a and 01121b are paired. If that's the case, I think this can be fixed by:

03321a:

  • Add the correct link info to 03321b.
  • Remove hidden: true attribute

03321b:

  • Remove the link to 03321a
  • Add hidden: true attribute
  • Replace the imagesrc asset .jpg with the correct image

Translating Site wording

Is it possible to have a file to translate things like the site menu, traits, slots and such?
It would be helpful for the search filters in other languages

Consistent formatting for JSON files

Hi !

The formatting is not consistent among the various JSON files of this repo : some use tabs, some use 2 spaces, some use 4 spaces.
Each time I edit a file, I struggle with my editor to try keeping the current formatting so that the diff looks clean.

Can we settle on formatting rules and enforce them with Prettier and EditorConfig ?

@Kamalisk If you're OK with that I can submit a PR for it which will :

  • add Prettier and associated configuration
  • add a package.json script to prettify all JSON files
  • add a .editorconfig file
  • fix all JSON files according to the formatting rules we agreed uppon

octgn_id is missing in data files

Hi,

it seems, that the data files doesn't contain the octgn_id. This attribute can be found through the API on arkhamdb.com.

How is the process of getting the octgn_id into arkhamdb.com? (I'm trying to extends the OCTGN Plugin with UAU and WDA)
Is there any other information missing in the JSON Files?

regards,
Mike

Red clock wrong traits

The new spoiled The Red Clock is actually Item and Relic traited, instead of the currently shown Favor trait.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.