Git Product home page Git Product logo

flowwy's People

Contributors

kakajansh avatar

Stargazers

avatar avatar

Watchers

avatar avatar

Forkers

dcsan

flowwy's Issues

hardcoded local deps

looks like you have some local paths hardcoded into the smart.require

    "famodev": {
        "path": "/Users/rubyist/meteor/packages/famodev/src"
    }

=> Started proxy.                             
=> Meteor 1.1.0.2 is available. Update this project with 'meteor update'.
=> Started MongoDB.                           
   Building the application                  \
Ensure dependencies...
 Famono:  git update "famous" is up-to-date
 Famono:  git update "famous.polyfills" is up-to-date
 Famono:  git update "library" is up-to-date
 Famono:  Library created for "famous-polyfills" via alias
 Famono:  git update "flex" is up-to-date
=> Errors prevented startup:                  

   While building the application:
   fs.js:696:18: ENOENT, no such file or directory
   '/Users/rubyist/meteor/packages/famodev/src' (compiling lib/smart.require)
   at Object.fs.statSync (fs.js:696:18)
   at Object.sourceFetchers.path
   (packages/compileRequirejs/compile_requirejs.js:1102:1)
   at checkLibrarySource
   (packages/compileRequirejs/compile_requirejs.js:1292:1)
   at ensureDependencies
   (packages/compileRequirejs/compile_requirejs.js:1495:1)
   at Package (packages/compileRequirejs/compile_requirejs.js:2661:1)


=> Your application has errors. Waiting for file change.

removed flex but still get errors

this was causing a weird 'split' error

    "flex": {
        "git": "https://github.com/IjzerenHein/famous-flex.git",
        "root": "src"
    },

now i get this

meteor
[[[[[ ~/dev/ref/flowwy ]]]]]                  

=> Started proxy.                             
=> Meteor 1.1.0.2 is available. Update this project with 'meteor update'.
=> Started MongoDB.                           
   Building the application                  |
Ensure dependencies...
 Famono:  git update "famous" is up-to-date
 Famono:  git update "famous.polyfills" is up-to-date
 Famono:  git update "library" is up-to-date
 Famono:  The alias for "famous-polyfills" is up-to-date
 Famono:  remove dep "flex" /Users/dc/dev/ref/flowwy/.meteor/.famono-repos/flex
 Famono:  git update "famodev" is up-to-date
 Famono:  Warning, could not load library "famodev/Node" file: /Users/dc/dev/ref/flowwy/src/Each
 Famono:  Warning, could not load library "famodev/Modifier" file: /Users/dc/dev/ref/flowwy/src/Each
 Famono:  Warning, could not load library "famodev/reactive/ReactiveCursor" file: /Users/dc/dev/ref/flowwy/src/Each
 Famono:  Warning, could not load library "famodev/reactive/ReactiveSession" file: /Users/dc/dev/ref/flowwy/src/ReactiveSurface
I20150516-15:26:04.840(-7)? hello webstorm    
W20150516-15:26:04.842(-7)? (STDERR) 
W20150516-15:26:04.842(-7)? (STDERR) /Users/dc/.meteor/packages/meteor-tool/.1.0.45.1rbfldw++os.osx.x86_64+web.browser+web.cordova/mt-os.osx.x86_64/dev_bundle/server-lib/node_modules/fibers/future.js:245
W20150516-15:26:04.842(-7)? (STDERR)                        throw(ex);
W20150516-15:26:04.843(-7)? (STDERR)                              ^
W20150516-15:26:04.843(-7)? (STDERR) Error: Famous "define" cannot run on the server
W20150516-15:26:04.843(-7)? (STDERR)     at global.define (packages/raix:famono/requirejs_server.js:7:1)
W20150516-15:26:04.843(-7)? (STDERR)     at app/src/Each.js:10:1
W20150516-15:26:04.843(-7)? (STDERR)     at app/src/Each.js:213:3
W20150516-15:26:04.843(-7)? (STDERR)     at /Users/dc/dev/ref/flowwy/.meteor/local/build/programs/server/boot.js:222:10
W20150516-15:26:04.843(-7)? (STDERR)     at Array.forEach (native)
W20150516-15:26:04.843(-7)? (STDERR)     at Function._.each._.forEach (/Users/dc/.meteor/packages/meteor-tool/.1.0.45.1rbfldw++os.osx.x86_64+web.browser+web.cordova/mt-os.osx.x86_64/dev_bundle/server-lib/node_modules/underscore/underscore.js:79:11)
W20150516-15:26:04.844(-7)? (STDERR)     at /Users/dc/dev/ref/flowwy/.meteor/local/build/programs/server/boot.js:117:5
=> Exited with code: 8
   Building the application                  |
Ensure dependencies...
I20150516-15:26:07.506(-7)? hello webstorm    
W20150516-15:26:07.507(-7)? (STDERR) 
W20150516-15:26:07.507(-7)? (STDERR) /Users/dc/.meteor/packages/meteor-tool/.1.0.45.1rbfldw++os.osx.x86_64+web.browser+web.cordova/mt-os.osx.x86_64/dev_bundle/server-lib/node_modules/fibers/future.js:245
W20150516-15:26:07.507(-7)? (STDERR)                        throw(ex);
W20150516-15:26:07.507(-7)? (STDERR)                              ^
W20150516-15:26:07.513(-7)? (STDERR) Error: Famous "define" cannot run on the server
W20150516-15:26:07.513(-7)? (STDERR)     at global.define (packages/raix:famono/requirejs_server.js:7:1)
W20150516-15:26:07.513(-7)? (STDERR)     at app/src/Each.js:10:1
W20150516-15:26:07.513(-7)? (STDERR)     at app/src/Each.js:213:3
W20150516-15:26:07.513(-7)? (STDERR)     at /Users/dc/dev/ref/flowwy/.meteor/local/build/programs/server/boot.js:222:10
W20150516-15:26:07.513(-7)? (STDERR)     at Array.forEach (native)
W20150516-15:26:07.513(-7)? (STDERR)     at Function._.each._.forEach (/Users/dc/.meteor/packages/meteor-tool/.1.0.45.1rbfldw++os.osx.x86_64+web.browser+web.cordova/mt-os.osx.x86_64/dev_bundle/server-lib/node_modules/underscore/underscore.js:79:11)
W20150516-15:26:07.514(-7)? (STDERR)     at /Users/dc/dev/ref/flowwy/.meteor/local/build/programs/server/boot.js:117:5
=> Exited with code: 8
                                             |
Ensure dependencies...
^C                                            
➜  flowwy git:(master) ✗

build fails with latest flex layout

using current master from famous-flex project will crash.
placeholder ticket to ask that team for suggestions too

bin/run.sh 
[[[[[ ~/dev/ref/flowwy-dcsan/app ]]]]]        

=> Started proxy.                             
=> Started MongoDB.                           
   Building the application                  \
Ensure dependencies...

/Users/dc/.meteor/packages/meteor-tool/.1.1.3.ylpo7g++os.osx.x86_64+web.browser+web.cordova/mt-os.osx.x86_64/dev_bundle/lib/node_modules/fibers/future.js:245
                        throw(ex);
                              ^
TypeError: Cannot call method 'split' of undefined
  at Object.exports.parse (/Users/dc/.meteor/packages/meteor-tool/.1.1.3.ylpo7g++os.osx.x86_64+web.browser+web.cordova/mt-os.osx.x86_64/tools/parse-stack.js:18:26)
  at Object.exception (/Users/dc/.meteor/packages/meteor-tool/.1.1.3.ylpo7g++os.osx.x86_64+web.browser+web.cordova/mt-os.osx.x86_64/tools/buildmessage.js:478:28)
  at /Users/dc/.meteor/packages/meteor-tool/.1.1.3.ylpo7g++os.osx.x86_64+web.browser+web.cordova/mt-os.osx.x86_64/tools/compiler.js:778:20
  at Array.forEach (native)
  at Function._.each._.forEach (/Users/dc/.meteor/packages/meteor-tool/.1.1.3.ylpo7g++os.osx.x86_64+web.browser+web.cordova/mt-os.osx.x86_64/dev_bundle/lib/node_modules/underscore/underscore.js:79:11)
  at compileUnibuild (/Users/dc/.meteor/packages/meteor-tool/.1.1.3.ylpo7g++os.osx.x86_64+web.browser+web.cordova/mt-os.osx.x86_64/tools/compiler.js:338:5)
  at /Users/dc/.meteor/packages/meteor-tool/.1.1.3.ylpo7g++os.osx.x86_64+web.browser+web.cordova/mt-os.osx.x86_64/tools/compiler.js:136:26
  at Array.forEach (native)
  at Function._.each._.forEach (/Users/dc/.meteor/packages/meteor-tool/.1.1.3.ylpo7g++os.osx.x86_64+web.browser+web.cordova/mt-os.osx.x86_64/dev_bundle/lib/node_modules/underscore/underscore.js:79:11)
  at Object.compiler.compile (/Users/dc/.meteor/packages/meteor-tool/.1.1.3.ylpo7g++os.osx.x86_64+web.browser+web.cordova/mt-os.osx.x86_64/tools/compiler.js:132:5)
  at /Users/dc/.meteor/packages/meteor-tool/.1.1.3.ylpo7g++os.osx.x86_64+web.browser+web.cordova/mt-os.osx.x86_64/tools/bundler.js:2090:24
  at /Users/dc/.meteor/packages/meteor-tool/.1.1.3.ylpo7g++os.osx.x86_64+web.browser+web.cordova/mt-os.osx.x86_64/tools/buildmessage.js:264:13
  at [object Object]._.extend.withValue (/Users/dc/.meteor/packages/meteor-tool/.1.1.3.ylpo7g++os.osx.x86_64+web.browser+web.cordova/mt-os.osx.x86_64/tools/fiber-helpers.js:115:14)
  at /Users/dc/.meteor/packages/meteor-tool/.1.1.3.ylpo7g++os.osx.x86_64+web.browser+web.cordova/mt-os.osx.x86_64/tools/buildmessage.js:257:29
  at [object Object]._.extend.withValue (/Users/dc/.meteor/packages/meteor-tool/.1.1.3.ylpo7g++os.osx.x86_64+web.browser+web.cordova/mt-os.osx.x86_64/tools/fiber-helpers.js:115:14)
  at /Users/dc/.meteor/packages/meteor-tool/.1.1.3.ylpo7g++os.osx.x86_64+web.browser+web.cordova/mt-os.osx.x86_64/tools/buildmessage.js:255:18
  at [object Object]._.extend.withValue (/Users/dc/.meteor/packages/meteor-tool/.1.1.3.ylpo7g++os.osx.x86_64+web.browser+web.cordova/mt-os.osx.x86_64/tools/fiber-helpers.js:115:14)
  at /Users/dc/.meteor/packages/meteor-tool/.1.1.3.ylpo7g++os.osx.x86_64+web.browser+web.cordova/mt-os.osx.x86_64/tools/buildmessage.js:246:23
  at [object Object]._.extend.withValue (/Users/dc/.meteor/packages/meteor-tool/.1.1.3.ylpo7g++os.osx.x86_64+web.browser+web.cordova/mt-os.osx.x86_64/tools/fiber-helpers.js:115:14)
  at Object.capture (/Users/dc/.meteor/packages/meteor-tool/.1.1.3.ylpo7g++os.osx.x86_64+web.browser+web.cordova/mt-os.osx.x86_64/tools/buildmessage.js:245:19)
  at Object.exports.bundle (/Users/dc/.meteor/packages/meteor-tool/.1.1.3.ylpo7g++os.osx.x86_64+web.browser+web.cordova/mt-os.osx.x86_64/tools/bundler.js:2040:31)
  at /Users/dc/.meteor/packages/meteor-tool/.1.1.3.ylpo7g++os.osx.x86_64+web.browser+web.cordova/mt-os.osx.x86_64/tools/run-app.js:554:24
  at time (/Users/dc/.meteor/packages/meteor-tool/.1.1.3.ylpo7g++os.osx.x86_64+web.browser+web.cordova/mt-os.osx.x86_64/tools/profile.js:231:28)
  at Function.run (/Users/dc/.meteor/packages/meteor-tool/.1.1.3.ylpo7g++os.osx.x86_64+web.browser+web.cordova/mt-os.osx.x86_64/tools/profile.js:377:12)
  at bundleApp (/Users/dc/.meteor/packages/meteor-tool/.1.1.3.ylpo7g++os.osx.x86_64+web.browser+web.cordova/mt-os.osx.x86_64/tools/run-app.js:544:34)
  at [object Object]._.extend._runOnce (/Users/dc/.meteor/packages/meteor-tool/.1.1.3.ylpo7g++os.osx.x86_64+web.browser+web.cordova/mt-os.osx.x86_64/tools/run-app.js:591:35)
  at [object Object]._.extend._fiber (/Users/dc/.meteor/packages/meteor-tool/.1.1.3.ylpo7g++os.osx.x86_64+web.browser+web.cordova/mt-os.osx.x86_64/tools/run-app.js:821:28)
  at /Users/dc/.meteor/packages/meteor-tool/.1.1.3.ylpo7g++os.osx.x86_64+web.browser+web.cordova/mt-os.osx.x86_64/tools/run-app.js:402:12

coding style

I'm still getting to know famous, so when things are passed around always as "this" using syntax like:

_createMain = ->
   ...
   this.add(surf)

@StoryListView = ->
  View.apply this, arguments
  _createBack.call this

I find it a bit hard to follow what is what - lots of implicit objects are being passed around.

I know this is how famous has structured a lot of their code but it takes time to parse for me at least.

# declare we're expecting a rendertree (or view or node or whatever it is)
_createMain = (tree) ->
  ....
  tree.add(surf)

@StoryOneView = ->
  View.apply this, arguments   # this could also be clearer....
  _createMain(this)

this may potentially lose some flexibility in abstraction but it makes things clearer.
in future if we ever did switch to using typescript or something to check parameters it could be helpful too.

repo organization

I usually use this structure for apps:

/app
/bin
/docs
/packages
  • app
    this means that the app itself goes one layer down.
  • packages
    if separate packages are created these are put in /packages/ and can be sym linked.
    this makes it very easy to create a separate top level app that just uses a couple of the packages in isolation. I find this very useful for building quick tests to isolate problems.
  • docs
    it also keeps any docs or notes, or other files out of the deployed app directory.
    you could put a .idea project here too.
  • bin
    any scripts for deploying, setting up server etc. these also should not be in the app dir.

I adopted this in my fork of the repo, however its a big change so it completely breaks git merges... if you adopt this it would help, or i can setup a new cleaner repo.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.