kahkhang / inquirer.sh Goto Github PK

Keyboard keys like up, down should be ignored

Also, left, right should move the cursor accordingly

OPTIONS=()
OPTIONS+=( "One" )
list_input "Which one?" OPTIONS CHOICE

When you use the above code, pressing up or down causes "One" to repeat on every line, vs forcing you to stay in place.

Unable to enter any of the following characters in text_input prompt. ` \ ; ' ~ # % & ( ) | : " < >

If we press ctrl-c during execution the final position of the cursor can be improved. Ideally preserve the screen and place the cursor at the end of screen.
Steps to recreate:

1. execute ./examples/showcase_example.sh
2. give some input to first name and press enter
3. when the screen prompts for hawker centers press ctrl-c
   The final position of screen is as shown
   

source checkbox_input.sh

hawker_centres=( 'Old Airport Road Hawker Centre' 'Golden Mile Food Complex' 'Maxwell Food Centre' 'Newton Food Centre' )

checkbox_input selected_hawkers "Which hawker centres do you prefer?" hawker_centres
echo "Selected indices $(join "${selected_hawkers[@]}")"
echo "Selected Hawker Centers:"
for i in $(seq 1 ${#selected_hawkers[@]}); do
  echo "${hawker_centres[${selected_hawkers[$i]}]}"
done

Somehow there's this lex behind the Selected Hawker Centers:

Perhaps this is user error with the new version, but there is no example that demonstrates how to use anything but the default when default is set.

For instance, from https://github.com/kahkhang/Inquirer.sh/blob/master/examples/text_input_example.sh, there is:

text_input "Gender" gender "Male"

However, if you use this, it doesn't show a default, instead it fails validation unless your answer is the default. So basically, you MUST type "Male" to get out of the prompt.

I also don't see any details on how to use the validation. I'd like to do something like this:

text_input "What IP range should the server use?" IP_RANGE "192.168.99.1/24" "Invalid IP range format." ???????

But even if this was working, I'm not sure what to include here. The name of a previously defined function?

Thanks!

Any luck with zsh & bash support?

That's a nice a project.
Just wanted to let you know that I wrote a list selection script in pure bash/zsh.

Take a look (redundant link in case project rename):

• https://github.com/hinell/options-select-bash
• https://github.com/hinell/options-select.bash

If there are any line wraps, lists will be rendered incorrectly

This issue can be recreated as below

1. run ./examples/checkbox_input_example.sh
2. select any (hawker center(s)) and press enter (no issue here)
3. select one preferred drink or none and press enter
   But in final output it displays all the drinks.
   

If you source dist/Inquirer.sh after running text_input, list_input, or checkbox_input, the shell stays in stty -echo mode.

It also uses the “exit on error” option (set -e) that will force the shell to exit on any command with a non-zero exit status, which in turn may break scripts that source the inquirer scripts.

I suggest optionally enabling the set -e option is the script is not sourced, or better yet, unset the e flag if it was not set prior to the inquirer scripts:

#!/usr/bin/env bash <- I also recommend this instead of #!/bin/bash
# save the set options
OLD_SET=$-
...
# in cleanup part
if [[ $OLD_SET =~ e ]]
then set -e
else set +e
fi