Git Product home page Git Product logo

gnome-shell-extension-modern-calc's People

Contributors

awamper avatar jonnius avatar kaer avatar snouf avatar

Stargazers

avatar avatar avatar avatar

Watchers

avatar avatar

Forkers

jonnius snouf prtuson

gnome-shell-extension-modern-calc's Issues

Calc dialog is always open after login/screen unlock, on a multiple monitor setup

Hi,
Thanks for writing this extension, it's been useful. However, there's a small annoyance. Each time I login or if I step afk and return to unlock my system I see this on my dual-screen setup.

single screenshot of my dual-screen setup -- left half is my primary display

...and I have to click on the calc icon on the taskbar, to have it show up on my current primary desktop (the left half in that screenshot) and then again to close it.

I'm running gnome-shell-3.10.4-9.fc20.x86_64 on Fedora 20. I'm sorry I can't send in a pull request or even isolate the code that causes this behavior since I don't know much about g-s-extensions but can help with any debugging that you might need me to do.

dual monitor problems

Hi,
When using Modern Calc with dual monitor system (where primary screen is on the left) the calc appears on the left side of the right monintor. On login it appears and still visible, on toggle on it appears and slides to first monitor, and when toggle off, it slides to the second monitor and go transparent.

Can't open extension settings on Ubuntu 19.04 

The settings of extension modern-calc@kaer had an error:

Error: Requiring Clutter, version none: Typelib file for namespace 'Clutter' (any version) not found

Stack trace:
@/home/ubuntu/.local/share/gnome-shell/extensions/modern-calc@kaer/utils.js:31:7
@/home/ubuntu/.local/share/gnome-shell/extensions/modern-calc@kaer/prefs.js:38:7
_getExtensionPrefsModule@resource:///org/gnome/shell/extensionPrefs/main.js:59:13
_selectExtension@resource:///org/gnome/shell/extensionPrefs/main.js:74:31
_onCommandLine@resource:///org/gnome/shell/extensionPrefs/main.js:320:17
main@resource:///org/gnome/shell/extensionPrefs/main.js:635:5
@<main>:1:43

js warning

i find this warning in the log (GS 3.14.2):

gen 17 12:17:31 ArchBox gnome-session[732]: Gjs-Message: JS WARNING: [/home/iacopodeenosee/.local/share/gnome-shell/extensions/modern-calc@kaer/module_data/unit_converter/quantities15.js 348]: function Qty does not always return a value
gen 17 12:17:31 ArchBox gnome-session[732]: Gjs-Message: JS WARNING: [/home/iacopodeenosee/.local/share/gnome-shell/extensions/modern-calc@kaer/module_data/unit_converter/quantities15.js 510]: anonymous function does not always return a value
gen 17 12:17:31 ArchBox gnome-session[732]: Gjs-Message: JS WARNING: [/home/iacopodeenosee/.local/share/gnome-shell/extensions/modern-calc@kaer/module_data/unit_converter/quantities15.js 943]: anonymous function does not always return a value
gen 17 12:17:31 ArchBox gnome-session[732]: Gjs-Message: JS WARNING: [/home/iacopodeenosee/.local/share/gnome-shell/extensions/modern-calc@kaer/module_data/unit_converter/quantities15.js 1277]: anonymous function does not always return a value
gen 17 12:17:31 ArchBox gnome-session[732]: Gjs-Message: JS WARNING: [/home/iacopodeenosee/.local/share/gnome-shell/extensions/modern-calc@kaer/module_data/unit_converter/quantities15.js 1794]: function QtyError does not always return a value

the extension work prefectly, thx.

Don't work in gnome 3.16

I modify the metadata.json and add gome 3.16

"shell-version": [
    "3.10", 
    "3.12", 
    "3.14",
    "3.16"
  ],

After this moderncalc return an error

Error: Expected type interface for Argument for 'file' but got to type 'String'

Syslog Warnings on Gnome 3.28

I am using gnome-shell 3.26 and have been getting warnings like this in syslog:

May 7 08:30:03 oisin gnome-shell[20584]: JS WARNING: [/home/peter/.local/share/gnome-shell/extensions/modern-calc@kaer/message_view.js 88]: Too many arguments to method Clutter.Actor.add_child: expected 1, got 2

and

May 6 16:39:44 oisin gnome-shell[20584]: Some code accessed the property 'ModernCalcModule' on the module 'modern_calc_module'. That property was defined with 'let' or 'const' inside the module. This was previously supported, but is not correct according to the ES6 standard. Any symbols to be exported from a module must be defined with 'var'. The property access will work as previously for the time being, but please fix your code anyway.

I fixed this by:
a) changing all of the add_child calls so they only has the first argument, e.g. this._messageContentGroup.add_child(this._icon);

b) changing the const for the new class defined in the scripts to var.

This left a final message, which was:

May 7 09:09:51 oisin gnome-shell[3184]: JS WARNING: [/home/peter/.local/share/gnome-shell/extensions/modern-calc@kaer/modern_calc.js 52]: reference to undefined property "showMessage"

I commented the line out as there is no showMessage method in utils.js and Notify is not used.

Cannot upen extension settings Ubuntu 19.04

The settings of extension modern-calc@kaer had an error:

Error: Requiring Clutter, version none: Typelib file for namespace 'Clutter' (any version) not found

Stack trace:

@/home/scott/.local/share/gnome-shell/extensions/modern-calc@kaer/utils.js:31:7
@/home/scott/.local/share/gnome-shell/extensions/modern-calc@kaer/prefs.js:38:7
_getExtensionPrefsModule@resource:///org/gnome/shell/extensionPrefs/main.js:59:13
_selectExtension@resource:///org/gnome/shell/extensionPrefs/main.js:74:31
_onCommandLine@resource:///org/gnome/shell/extensionPrefs/main.js:320:17
main@resource:///org/gnome/shell/extensionPrefs/main.js:635:5
@<main>:1:43

Prevents gnome-shell from returning to desktop after lock

Whenever I lock the screen and try to login, the screen freezes and have to go to console to kill -s 9 gnome-shell pid to restart gnome-shell and be able to login. I narrowed down the culprit to this extension. Removing this extension allows me to login again after a screen lock.

Here are the logs from journalctl /usr/bin/gnome-shell:

Nov 22 18:37:11 shemgp-x230t gnome-shell[11063]: JS WARNING: [/home/shemgp/.local/share/gnome-shell/extensions/modern-calc@kaer/message_view.js 88]: Too many arguments t
o method Clutter.Actor.add_child: expected 1, got 2
Nov 22 18:37:11 shemgp-x230t gnome-shell[11063]: JS WARNING: [/home/shemgp/.local/share/gnome-shell/extensions/modern-calc@kaer/message_view.js 115]: Too many arguments 
to method Clutter.Actor.add_child: expected 1, got 2
Nov 22 18:37:11 shemgp-x230t gnome-shell[11063]: JS WARNING: [/home/shemgp/.local/share/gnome-shell/extensions/modern-calc@kaer/message_view.js 121]: Too many arguments 
to method Clutter.Actor.add_child: expected 1, got 2
Nov 22 18:37:11 shemgp-x230t gnome-shell[11063]: JS WARNING: [/home/shemgp/.local/share/gnome-shell/extensions/modern-calc@kaer/message_view.js 127]: Too many arguments 
to method Clutter.Actor.add_child: expected 1, got 2
Nov 22 18:37:11 shemgp-x230t gnome-shell[11063]: JS WARNING: [/home/shemgp/.local/share/gnome-shell/extensions/modern-calc@kaer/message_view.js 159]: Too many arguments 
to method Clutter.Actor.add_child: expected 1, got 2
Nov 22 18:37:11 shemgp-x230t gnome-shell[11063]: JS WARNING: [/home/shemgp/.local/share/gnome-shell/extensions/modern-calc@kaer/message_view.js 165]: Too many arguments 
to method Clutter.Actor.add_child: expected 1, got 2
Nov 22 18:37:11 shemgp-x230t gnome-shell[11063]: JS WARNING: [/home/shemgp/.local/share/gnome-shell/extensions/modern-calc@kaer/message_view.js 171]: Too many arguments 
to method Clutter.Actor.add_child: expected 1, got 2
Nov 22 18:37:11 shemgp-x230t gnome-shell[11063]: JS WARNING: [/home/shemgp/.local/share/gnome-shell/extensions/modern-calc@kaer/message_view.js 178]: Too many arguments 
to method Clutter.Actor.add_child: expected 1, got 2
Nov 22 18:37:11 shemgp-x230t gnome-shell[11063]: JS WARNING: [/home/shemgp/.local/share/gnome-shell/extensions/modern-calc@kaer/message_view.js 184]: Too many arguments 
to method Clutter.Actor.add_child: expected 1, got 2
Nov 22 18:37:11 shemgp-x230t gnome-shell[11063]: JS WARNING: [/home/shemgp/.local/share/gnome-shell/extensions/modern-calc@kaer/message_view.js 190]: Too many arguments 
to method Clutter.Actor.add_child: expected 1, got 2
Nov 22 18:37:11 shemgp-x230t gnome-shell[11063]: JS WARNING: [/home/shemgp/.local/share/gnome-shell/extensions/modern-calc@kaer/message_view.js 197]: Too many arguments 
to method Clutter.Actor.add_child: expected 1, got 2
Nov 22 18:37:11 shemgp-x230t gnome-shell[11063]: JS WARNING: [/home/shemgp/.local/share/gnome-shell/extensions/modern-calc@kaer/message_view.js 203]: Too many arguments 
to method Clutter.Actor.add_child: expected 1, got 2
Nov 22 18:37:11 shemgp-x230t gnome-shell[11063]: JS WARNING: [/home/shemgp/.local/share/gnome-shell/extensions/modern-calc@kaer/calculus_history.js 72]: Too many arguments to method Clutter.Actor.add_child: expected 1, got 2
Nov 22 18:37:11 shemgp-x230t gnome-shell[11063]: JS WARNING: [/home/shemgp/.local/share/gnome-shell/extensions/modern-calc@kaer/calculus_history.js 226]: Too many arguments to method Clutter.Actor.add_child: expected 1, got 2
Nov 22 18:37:11 shemgp-x230t gnome-shell[11063]: Attempting to add actor of type 'StBoxLayout' to a container of type 'StBoxLayout', but the actor has already a parent of type 'StBoxLayout'.

Buttons moving when the 'pi' replacement is done

Hi, thanks for this great extension. In the current setup, the buttons below the entry space move when the text 'pi' is replaced by the character 'ฯ€' and move again when it is deleted. I suggest hardcoding a height for .calc-entry, for example, adding

.display-group .calc-entry {
height:1.4em;
}

in stylesheet.css solves it for me

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.